struct Rav1dContext: Make frame contexts a Box<[_]>
#1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinon
force-pushed
the
sjc/rav1dframecontext/split_mutability
branch
from
b66f230
to
6a9559a
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/owned
branch
from
0d6cbc5
to
6ff6d35
Compare
kkysen
changed the title
Rav1dContext: Make frame contexts a boxed slicestruct Rav1dContext: Make frame contexts a Box<[_]>
kkysen
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Generally LGMT. Only little things are that we should just use % instead of .wrapping_rem. .wrapping_rem is only there since other operations have .wrapping_* versions, but this one does nothing extra. Also, for the place where you did .fc_iter and .nth, I think we should do % and indexing like is done for the other places, and is done in C.
kkysen
reviewed
Apr 24, 2024
kkysen
reviewed
Apr 24, 2024
rinon
force-pushed
the
sjc/rav1dframecontext/split_mutability
branch
3 times, most recently
from
934c8d1
to
7928da5
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/owned
branch
from
6ff6d35
to
da70a54
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/split_mutability
branch
from
7928da5
to
5a07699
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/owned
branch
from
da70a54
to
7793631
Compare
kkysen
reviewed
Apr 24, 2024
kkysen
reviewed
Apr 24, 2024
rinon
force-pushed
the
sjc/rav1dframecontext/split_mutability
branch
from
5a07699
to
e2b4317
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/owned
branch
2 times, most recently
from
3626706
to
7d53b2f
Compare
kkysen
approved these changes
Apr 24, 2024
rinon
force-pushed
the
sjc/rav1dframecontext/split_mutability
branch
from
e2b4317
to
5ac674d
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/owned
branch
from
7d53b2f
to
16e15d6
Compare
Replaces the C allocation and `fc` array pointer of `Rav1dFrameContext` structures with a Rust boxed slice.
rinon
force-pushed
the
sjc/rav1dframecontext/split_mutability
branch
from
5ac674d
to
32bc8ba
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/owned
branch
from
16e15d6
to
b83c712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the C allocation and
fcarray pointer ofRav1dFrameContextstructures with a Rust boxed slice.