Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Dav1dContext::fc to be a Vec #10

Closed
randomPoison opened this issue Feb 24, 2023 · 1 comment · Fixed by #1000
Closed

Convert Dav1dContext::fc to be a Vec #10

randomPoison opened this issue Feb 24, 2023 · 1 comment · Fixed by #1000
Assignees
@rinon
Labels
good first issue Good for newcomers refactoring Cleaning up transpiled code

Comments

@randomPoison
Copy link
Collaborator

The fc and n_fc fields of Dav1dContext (source) represent a dynamically-sized array. We should be able to replace this with a Vec in the ported Rust code and update usages of it to make them use safe Vec methods.
@randomPoison randomPoison added good first issue Good for newcomers refactoring Cleaning up transpiled code labels Feb 24, 2023
@rinon rinon self-assigned this Dec 2, 2023
@kkysen kkysen mentioned this issue Dec 8, 2023
Closed
@randomPoison
Copy link
Collaborator Author

Blocked on #695, or at least it will be easier to do this once that issue is addressed.

@rinon rinon self-assigned this Feb 16, 2024
@rinon rinon linked a pull request Apr 26, 2024 that will close this issue
struct Rav1dContext: Make frame contexts a Box<[_]> #1000
Merged
@rinon rinon closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rinon rinon

Labels
good first issue Good for newcomers refactoring Cleaning up transpiled code
Projects
None yet
Milestone
No milestone
2 participants
@rinon @randomPoison