Fixes #33 #43 : Create ps4-controller role #39

yannis-mlgrn · 2022-04-16T12:57:10Z

yannis-mlgrn · 2022-04-16T20:40:20Z

first error :

    arm-image.raspbian: TASK [ps4-controller : Clone the ds4drv repository in /home/pi] ****************
    arm-image.raspbian: task path: /tmp/packer-provisioner-ansible-local/625b28f9-51c3-55b2-c21d-3c1f3ca9e40c/roles/ps4-controller/tasks/main.yml:14
    arm-image.raspbian: <127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: root
    arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c 'echo ~root && sleep 0'
    arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1650141472.0488725-11603-132371019639580 `" && echo ansible-tmp-1650141472.0488725-11603-132371019639580="` echo /root/.ansible/tmp/ansible-tmp-1650141472.0488725-11603-132371019639580 `" ) && sleep 0'
    arm-image.raspbian: Using module file /tmp/ansible/venv/lib/python3.7/site-packages/ansible/modules/git.py
    arm-image.raspbian: <127.0.0.1> PUT /root/.ansible/tmp/ansible-local-111721d0mpmvq/tmp4d5_dimo TO /root/.ansible/tmp/ansible-tmp-1650141472.0488725-11603-132371019639580/AnsiballZ_git.py
    arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1650141472.0488725-11603-132371019639580/ /root/.ansible/tmp/ansible-tmp-1650141472.0488725-11603-132371019639580/AnsiballZ_git.py && sleep 0'
    arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c '/tmp/ansible/venv/bin/python /root/.ansible/tmp/ansible-tmp-1650141472.0488725-11603-132371019639580/AnsiballZ_git.py && sleep 0'
    arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1650141472.0488725-11603-132371019639580/ > /dev/null 2>&1 && sleep 0'
    arm-image.raspbian: The full traceback is:
    arm-image.raspbian:   File "/tmp/ansible_ansible.builtin.git_payload_usrqki9e/ansible_ansible.builtin.git_payload.zip/ansible/module_utils/basic.py", line 1419, in get_bin_path
    arm-image.raspbian:     bin_path = get_bin_path(arg=arg, opt_dirs=opt_dirs)
    arm-image.raspbian:   File "/tmp/ansible_ansible.builtin.git_payload_usrqki9e/ansible_ansible.builtin.git_payload.zip/ansible/module_utils/common/process.py", line 42, in get_bin_path
    arm-image.raspbian:     raise ValueError('Failed to find required executable "%s" in paths: %s' % (arg, os.pathsep.join(paths)))
    arm-image.raspbian: fatal: [127.0.0.1]: FAILED! => {
    arm-image.raspbian:     "changed": false,
    arm-image.raspbian:     "invocation": {
    arm-image.raspbian:         "module_args": {
    arm-image.raspbian:             "accept_hostkey": false,
    arm-image.raspbian:             "archive": null,
    arm-image.raspbian:             "archive_prefix": null,
    arm-image.raspbian:             "bare": false,
    arm-image.raspbian:             "clone": true,
    arm-image.raspbian:             "depth": null,
    arm-image.raspbian:             "dest": "/home/pi/",
    arm-image.raspbian:             "executable": null,
    arm-image.raspbian:             "force": true,
    arm-image.raspbian:             "gpg_whitelist": [],
    arm-image.raspbian:             "key_file": null,
    arm-image.raspbian:             "recursive": true,
    arm-image.raspbian:             "reference": null,
    arm-image.raspbian:             "refspec": null,
    arm-image.raspbian:             "remote": "origin",
    arm-image.raspbian:             "repo": "https://github.com/Benvii/ds4drv.git",
    arm-image.raspbian:             "separate_git_dir": null,
    arm-image.raspbian:             "single_branch": true,
    arm-image.raspbian:             "ssh_opts": null,
    arm-image.raspbian:             "track_submodules": false,
    arm-image.raspbian:             "umask": null,
    arm-image.raspbian:             "update": true,
    arm-image.raspbian:             "verify_commit": false,
    arm-image.raspbian:             "version": "193_limit_simultaneous_controllers"
    arm-image.raspbian:         }
    arm-image.raspbian:     },
    arm-image.raspbian:     "msg": "Failed to find required executable \"git\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"
    arm-image.raspbian: }

+ error fixed when git is installed with `sudo apt install git`

yannis-mlgrn · 2022-04-16T21:03:43Z

Error :

fatal: [127.0.0.1]: FAILED! => {
    arm-image.raspbian:     "changed": false,
    arm-image.raspbian:     "cmd": "/usr/bin/git clone --origin origin --single-branch --branch 193_limit_simultaneous_controllers https://github.com/Benvii/ds4drv.git /home/pi",
    arm-image.raspbian:     "invocation": {
    arm-image.raspbian:         "module_args": {
    arm-image.raspbian:             "accept_hostkey": false,
    arm-image.raspbian:             "archive": null,
    arm-image.raspbian:             "archive_prefix": null,
    arm-image.raspbian:             "bare": false,
    arm-image.raspbian:             "clone": true,
    arm-image.raspbian:             "depth": null,
    arm-image.raspbian:             "dest": "/home/pi/",
    arm-image.raspbian:             "executable": null,
    arm-image.raspbian:             "force": true,
    arm-image.raspbian:             "gpg_whitelist": [],
    arm-image.raspbian:             "key_file": null,
    arm-image.raspbian:             "recursive": true,
    arm-image.raspbian:             "reference": null,
    arm-image.raspbian:             "refspec": null,
    arm-image.raspbian:             "remote": "origin",
    arm-image.raspbian:             "repo": "https://github.com/Benvii/ds4drv.git",
    arm-image.raspbian:             "separate_git_dir": null,
    arm-image.raspbian:             "single_branch": true,
    arm-image.raspbian:             "ssh_opts": null,
    arm-image.raspbian:             "track_submodules": false,
    arm-image.raspbian:             "umask": null,
    arm-image.raspbian:             "update": true,
    arm-image.raspbian:             "verify_commit": false,
    arm-image.raspbian:             "version": "193_limit_simultaneous_controllers"
    arm-image.raspbian:         }
    arm-image.raspbian:     },
    arm-image.raspbian:     "msg": "fatal: destination path '/home/pi' already exists and is not an empty directory.",
    arm-image.raspbian:     "rc": 128,
    arm-image.raspbian:     "stderr": "fatal: destination path '/home/pi' already exists and is not an empty directory.\n",
    arm-image.raspbian:     "stderr_lines": [
    arm-image.raspbian:         "fatal: destination path '/home/pi' already exists and is not an empty directory."
    arm-image.raspbian:     ],
    arm-image.raspbian:     "stdout": "",
    arm-image.raspbian:     "stdout_lines": []
    arm-image.raspbian: }

+ error fixed, 'est' variable should be `dest: /home/pi/ds4drv`

yannis-mlgrn · 2022-04-16T21:24:32Z

 arm-image.raspbian: task path: /tmp/packer-provisioner-ansible-local/625b317c-2f7a-fe46-3dfa-4102dc5877cd/roles/ps4-controller/tasks/main.yml:29
 arm-image.raspbian: <127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: root
 arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c 'echo ~root && sleep 0'
 arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1650143682.742238-20754-193998516308194 `" && echo ansible-tmp-1650143682.742238-20754-193998516308194="` echo /root/.ansible/tmp/ansible-tmp-1650143682.742238-20754-193998516308194 `" ) && sleep 0'
 arm-image.raspbian: Using module file /tmp/ansible/venv/lib/python3.7/site-packages/ansible/modules/pip.py
 arm-image.raspbian: <127.0.0.1> PUT /root/.ansible/tmp/ansible-local-18328v1hnneyx/tmpxpwst1qt TO /root/.ansible/tmp/ansible-tmp-1650143682.742238-20754-193998516308194/AnsiballZ_pip.py
 arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1650143682.742238-20754-193998516308194/ /root/.ansible/tmp/ansible-tmp-1650143682.742238-20754-193998516308194/AnsiballZ_pip.py && sleep 0'
 arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c '/tmp/ansible/venv/bin/python /root/.ansible/tmp/ansible-tmp-1650143682.742238-20754-193998516308194/AnsiballZ_pip.py && sleep 0'
 arm-image.raspbian: <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1650143682.742238-20754-193998516308194/ > /dev/null 2>&1 && sleep 0'
 arm-image.raspbian: The full traceback is:
 arm-image.raspbian:   File "/tmp/ansible_pip_payload_0jzjyzvk/ansible_pip_payload.zip/ansible/module_utils/basic.py", line 1419, in get_bin_path
 arm-image.raspbian:     bin_path = get_bin_path(arg=arg, opt_dirs=opt_dirs)
 arm-image.raspbian:   File "/tmp/ansible_pip_payload_0jzjyzvk/ansible_pip_payload.zip/ansible/module_utils/common/process.py", line 42, in get_bin_path
 arm-image.raspbian:     raise ValueError('Failed to find required executable "%s" in paths: %s' % (arg, os.pathsep.join(paths)))
 arm-image.raspbian: fatal: [127.0.0.1]: FAILED! => {
 arm-image.raspbian:     "changed": false,
 arm-image.raspbian:     "invocation": {
 arm-image.raspbian:         "module_args": {
 arm-image.raspbian:             "chdir": "/home/pi/ds4drv",
 arm-image.raspbian:             "editable": false,
 arm-image.raspbian:             "executable": null,
 arm-image.raspbian:             "extra_args": "-e",
 arm-image.raspbian:             "name": [
 arm-image.raspbian:                 "setup.py"
 arm-image.raspbian:             ],
 arm-image.raspbian:             "requirements": null,
 arm-image.raspbian:             "state": "present",
 arm-image.raspbian:             "umask": null,
 arm-image.raspbian:             "version": null,
 arm-image.raspbian:             "virtualenv": "/home/pi/venv/",
 arm-image.raspbian:             "virtualenv_command": "virtualenv",
 arm-image.raspbian:             "virtualenv_python": null,
 arm-image.raspbian:             "virtualenv_site_packages": false
 arm-image.raspbian:         }
 arm-image.raspbian:     },
 arm-image.raspbian:     "msg": "Failed to find required executable \"virtualenv\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"
 arm-image.raspbian: }

+ Fixes : added 'virtualenv_command: /usr/bin/python3 -m venv'

yannis-mlgrn · 2022-04-16T21:31:48Z

    arm-image.raspbian:     "changed": false,
    arm-image.raspbian:     "cmd": [
    arm-image.raspbian:         "/home/pi/venv/bin/pip3",
    arm-image.raspbian:         "install",
    arm-image.raspbian:         "-e",
    arm-image.raspbian:         "setup.py"
    arm-image.raspbian:     ],
    arm-image.raspbian:     "invocation": {
    arm-image.raspbian:         "module_args": {
    arm-image.raspbian:             "chdir": "/home/pi/ds4drv",
    arm-image.raspbian:             "editable": false,
    arm-image.raspbian:             "executable": null,
    arm-image.raspbian:             "extra_args": "-e",
    arm-image.raspbian:             "name": [
    arm-image.raspbian:                 "setup.py"
    arm-image.raspbian:             ],
    arm-image.raspbian:             "requirements": null,
    arm-image.raspbian:             "state": "present",
    arm-image.raspbian:             "umask": null,
    arm-image.raspbian:             "version": null,
    arm-image.raspbian:             "virtualenv": "/home/pi/venv/",
    arm-image.raspbian:             "virtualenv_command": "/usr/bin/python3 -m venv",
    arm-image.raspbian:             "virtualenv_python": null,
    arm-image.raspbian:             "virtualenv_site_packages": false
    arm-image.raspbian:         }
    arm-image.raspbian:     },
    arm-image.raspbian:     "msg": "\n:stderr: setup.py should either be a path to a local project or a VCS url beginning with svn+, git+, hg+, or bzr+\n"
    arm-image.raspbian: }
    arm-image.raspbian:

~ Not really fixed but this error can be because missing a / in chdir

yannis-mlgrn · 2022-04-16T21:38:31Z

    arm-image.raspbian: fatal: [127.0.0.1]: FAILED! => {
    arm-image.raspbian:     "changed": false,
    arm-image.raspbian:     "cmd": [
    arm-image.raspbian:         "/home/pi/venv/bin/pip3",
    arm-image.raspbian:         "install",
    arm-image.raspbian:         "setup.py"
    arm-image.raspbian:     ],
    arm-image.raspbian:     "invocation": {
    arm-image.raspbian:         "module_args": {
    arm-image.raspbian:             "chdir": "/home/pi/ds4drv/",
    arm-image.raspbian:             "editable": false,
    arm-image.raspbian:             "executable": null,
    arm-image.raspbian:             "extra_args": null,
    arm-image.raspbian:             "name": [
    arm-image.raspbian:                 "setup.py"
    arm-image.raspbian:             ],
    arm-image.raspbian:             "requirements": null,
    arm-image.raspbian:             "state": "present",
    arm-image.raspbian:             "umask": null,
    arm-image.raspbian:             "version": null,
    arm-image.raspbian:             "virtualenv": "/home/pi/venv/",
    arm-image.raspbian:             "virtualenv_command": "/usr/bin/python3 -m venv",
    arm-image.raspbian:             "virtualenv_python": null,
    arm-image.raspbian:             "virtualenv_site_packages": false
    arm-image.raspbian:         }
    arm-image.raspbian:     },
    arm-image.raspbian:     "msg": "stdout: Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple\nCollecting setup.py\n\n:stderr: Could not install packages due to an EnvironmentError: 404 Client Error: Not Found for url: https://pypi.org/simple/setup-py/\n\n"

~ Not fixed : OHHHH yess , it search to install setup.py trought pythons modules, or setup.py is a local file
might be because i've removed this line : `extra_args: '-e'`
+ Fixed in d817964 commit

yannis-mlgrn · 2022-04-16T22:17:08Z

This role seen good, except the pip install setup.py tasks . Idk really why

Benvii · 2022-04-17T09:49:05Z

No working on a raspberry pi you need at least on this branch a default environment file in /etc/donkeycar/ds4drv.env :

pi@raspberrypi:~ $ sudo systemctl status ds4drv.service 
● ds4drv.service - ds4drv daemon
   Loaded: loaded (/etc/systemd/system/ds4drv.service; enabled; vendor preset: enabled)
   Active: failed (Result: resources)

Apr 17 10:40:50 raspberrypi systemd[1]: ds4drv.service: Failed to load environment files: No such file or directory
Apr 17 10:40:50 raspberrypi systemd[1]: ds4drv.service: Failed to run 'start' task: No such file or directory
Apr 17 10:40:50 raspberrypi systemd[1]: ds4drv.service: Failed with result 'resources'.
Apr 17 10:40:50 raspberrypi systemd[1]: Failed to start ds4drv daemon.
pi@raspberrypi:~ $ cat /etc/systemd/system/ds4drv.service
[Unit]
Description=ds4drv daemon
Requires=bluetooth.service
After=bluetooth.service

[Service]
EnvironmentFile=/etc/donkeycar/ds4drv.env
ExecStart=sudo /home/pi/env/bin/ds4drv --controller-limit 1 --led 00CED1
Restart=on-abort

[Install]
WantedBy=bluetooth.targetpi@raspberrypi:~ $ cat /etc/donkeycar/ds4drv.env
cat: /etc/donkeycar/ds4drv.env: No such file or directory

Benvii

A lot of small bugs, biggest is the missing environment file for the service.

ansible/donkeycar.yml

ansible/roles/ps4-controller/tasks/main.yml

ansible/roles/ps4-controller/handlers/main.yml

ansible/roles/ps4-controller/tasks/main.yml

ansible/roles/ps4-controller/templates/ds4drv-service.j2

Benvii · 2022-04-17T10:09:04Z

Also don't forget to rebase before submitting for review (change were made yesterday)

ansible/roles/ps4-controller/templates/ds4drv.service.j2

Benvii · 2022-04-18T21:52:58Z

My tests :

More details :

dhcpd failed at startup just after having found it's wlan0 IP adress, it was killed by systemd, some sort of timeout issue. A restart made it work, no error found in dhcpd logs. We should maybe change the service to restart on failure or find a way to increase systemd timeout for dhcpd.
ds4drv :
- Wrong venv path
- Wrong environment variable name (not matching the one in DOT env file)
pwd : didn't investigate that issue for now

Benvii · 2022-04-18T21:53:03Z

Benvii · 2022-04-18T22:31:41Z

For dhcpd issue we can also increase the timeout :
https://support.microfocus.com/kb/doc.php?id=7024396

The issue might be related to first-boot only as the raspberry pi tries to do a lot of stuff that might slow down dhcpd.

yannis-mlgrn · 2022-04-19T11:47:29Z

My path file for dhcpd service on my personal raspberry pi 3 B+

/etc/systemd/system/dhcpcd5.service

The content of the service :

[Unit]
Description=dhcpcd on all interfaces
Wants=network.target
Before=network.target

[Service]his i
Type=forking
PIDFile=/run/dhcpcd.pid
ExecStart=/usr/lib/dhcpcd5/dhcpcd -q -b
ExecStop=/sbin/dhcpcd -x

[Install]
WantedBy=multi-user.target
Alias=dhcpcd5.service

The content of the service if we want to restart the service on failure and wait his ip

( I hope )
I have follow this page

[Unit]
Description=dhcpcd on all interfaces
Wants=network.target
Before=network.target
Restart=always

[Service]his i
Type=forking
PIDFile=/run/dhcpcd.pid
ExecStart=/usr/lib/dhcpcd5/dhcpcd -w -q -t 0 %I
ExecStop=/sbin/dhcpcd -x

[Install]
WantedBy=multi-user.target
Alias=dhcpcd5.service

Lines added :

+ ExecStart=/usr/lib/dhcpcd5/dhcpcd -w -q -t 0 %I
+ Restart=always

Fixed in c617978 commit

yannis-mlgrn · 2022-04-19T12:54:39Z

build with commits passed !!

Benvii

I'll make the small changes and start a build, so I can test it tonight.

ansible/roles/raspi-config/templates/dhcpd5.service.j2

ansible/roles/raspi-config/tasks/main.yml

ansible/roles/raspi-config/templates/dhcpd5.service.j2

…, such as DHCPD path

Benvii · 2022-04-19T19:44:53Z

Test report

Last 2 errors aren't directly related to the issue we can resolve them on #44

More details

python manage.py drive --js issue

I noticed 2 errors :

Scripts are writing as root (in mycar folder)
A missing dependency, I have attached a pip freeze ( pipFreezeDs4Drv.txt ) for further investigation we should compare it to dababycar

venv) pi@bluecar:~/mycar $ python manage.py drive --js
python: can't open file 'manage.py': [Errno 13] Permission denied
(venv) pi@bluecar:~/mycar $ ^Cthon manage.py drive --js
(venv) pi@bluecar:~/mycar $ sudo chown -R .
chown: missing operand after ‘.’
Try 'chown --help' for more information.
(venv) pi@bluecar:~/mycar $ ls -lisha
total 124K
254250 4.0K drwxr-xr-x 5 root root 4.0K Apr 19  2022 .
   825 4.0K drwxr-xr-x 6 pi   pi   4.0K Dec  2 02:36 ..
254257 8.0K -rwx------ 1 root root 4.8K Apr 19  2022 calibrate.py
254255  32K -rw-r--r-- 1 root root  32K Apr 19  2022 config.py
254252 4.0K drwxr-xr-x 2 root root 4.0K Apr 19  2022 data
254253 4.0K drwxr-xr-x 2 root root 4.0K Apr 19  2022 logs
254254  40K -rwx------ 1 root root  37K Apr 19  2022 manage.py
254251 4.0K drwxr-xr-x 2 root root 4.0K Apr 19  2022 models
 14107  20K -rw-r--r-- 1 root root  17K Apr 19  2022 myconfig.py
254256 4.0K -rwx------ 1 root root  728 Apr 19  2022 train.py
(venv) pi@bluecar:~/mycar $ sudo chown -R pi:pi .
(venv) pi@bluecar:~/mycar $ python manage.py drive --js
________             ______                   _________              
___  __ \_______________  /___________  __    __  ____/_____ ________
__  / / /  __ \_  __ \_  //_/  _ \_  / / /    _  /    _  __ `/_  ___/
_  /_/ // /_/ /  / / /  ,<  /  __/  /_/ /     / /___  / /_/ /_  /    
/_____/ \____//_/ /_//_/|_| \___/_\__, /      \____/  \__,_/ /_/     
                                 /____/                              

using donkey v4.3.10 ...
WARNING:donkeycar.parts.pins:pigpio was not imported.
Traceback (most recent call last):
  File "manage.py", line 27, in <module>
    from donkeycar.parts.datastore import TubHandler
  File "/home/pi/projects/donkeycar/parts/datastore.py", line 19, in <module>
    import pandas as pd
ModuleNotFoundError: No module named 'pandas'

Benvii · 2022-04-19T19:48:24Z

I'm approving this PR, errors will be fixed in #46

yannis-mlgrn added enhancement New feature or request Software labels Apr 16, 2022

yannis-mlgrn self-assigned this Apr 16, 2022

Benvii added this to the V0 - Demonstration version milestone Apr 17, 2022

Benvii marked this pull request as draft April 17, 2022 09:49

Benvii requested changes Apr 17, 2022

View reviewed changes

yannis-mlgrn force-pushed the 33-ps4-controller_role branch from bfe1413 to 1dd44bf Compare April 17, 2022 16:56

yannis-mlgrn requested a review from Benvii April 17, 2022 18:12

yannis-mlgrn linked an issue Apr 17, 2022 that may be closed by this pull request

[Ansible] Add to ds4drv service bindings to shutdown the car #43

Closed

yannis-mlgrn changed the title ~~Fixes #33 : Create ps4-controller role~~ Fixes #33 #43 : Create ps4-controller role Apr 17, 2022

Benvii force-pushed the 33-ps4-controller_role branch from 462f507 to c2c3ddf Compare April 17, 2022 19:25

yannis-mlgrn force-pushed the 33-ps4-controller_role branch from c2c3ddf to 6a8052d Compare April 18, 2022 11:32

Benvii force-pushed the 33-ps4-controller_role branch from d6e62e5 to 6a8052d Compare April 18, 2022 13:44

yannis-mlgrn and others added 9 commits April 18, 2022 15:46

Fixes mdl29#33 : Create ps4-controller role

f42163c

add color var

f9fd2e8

fixed 3 first errors

1ee1dd6

Might be the final commit

1b3ae37

remove sudo for run setup.py

a25af7e

removed wrong python path for run setup.py

3db2917

Another bad path resolved

453f166

Uncomment roles in donkeycar.yml

b307ee2

fixing ds4drv install using pip and git URL

8195670

yannis-mlgrn and others added 4 commits April 18, 2022 15:46

Fixes all @Benvii reviews

e28500f

add modif

0666301

add sleep in ds4drv.service

c05179f

Fix line issue after rebasing

b35b11e

Benvii force-pushed the 33-ps4-controller_role branch from 6a8052d to b35b11e Compare April 18, 2022 13:47

yannis-mlgrn force-pushed the 33-ps4-controller_role branch from b35b11e to d059c31 Compare April 18, 2022 17:35

Benvii force-pushed the 33-ps4-controller_role branch from d059c31 to b35b11e Compare April 18, 2022 17:37

yannis-mlgrn linked an issue Apr 18, 2022 that may be closed by this pull request

Joystick pair only one controller at once #31

Closed

yannis-mlgrn marked this pull request as ready for review April 18, 2022 18:40

remove path env typoq

0b2ede9

Benvii marked this pull request as draft April 18, 2022 21:45

Benvii requested changes Apr 18, 2022

View reviewed changes

ansible/roles/ps4-controller/templates/ds4drv.service.j2 Outdated Show resolved Hide resolved

fixes typos variable in ds4drv.env

5e0010d

yannis-mlgrn requested a review from Benvii April 18, 2022 22:00

modifie the dhcpd5 service

c617978

Benvii requested changes Apr 19, 2022

View reviewed changes

Benvii added 2 commits April 19, 2022 19:58

Fixing some issues after review and also that comes from rpi4 (maybe)…

d824573

…, such as DHCPD path

Mistake in jinja template file name for DHCP

255e301

Benvii mentioned this pull request Apr 19, 2022

Fixes #44: Launch donkeycar.service at startup #46

Merged

Benvii approved these changes Apr 19, 2022

View reviewed changes

Benvii marked this pull request as ready for review April 19, 2022 19:48

Benvii merged commit 32843a0 into mdl29:main Apr 19, 2022

yannis-mlgrn mentioned this pull request Apr 20, 2022

[Ansible] Error with requirements and TensorFlow #48

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #33 #43 : Create ps4-controller role #39

Fixes #33 #43 : Create ps4-controller role #39

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

yannis-mlgrn commented Apr 16, 2022

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

yannis-mlgrn commented Apr 16, 2022

Benvii commented Apr 17, 2022

Benvii left a comment

Benvii commented Apr 17, 2022

Benvii commented Apr 18, 2022

Benvii commented Apr 18, 2022 •

edited by yannis-mlgrn

Loading

Benvii commented Apr 18, 2022

yannis-mlgrn commented Apr 19, 2022 •

edited

Loading

Lines added :

yannis-mlgrn commented Apr 19, 2022

Benvii left a comment

Benvii commented Apr 19, 2022 •

edited

Loading

Benvii commented Apr 19, 2022

Fixes #33 #43 : Create ps4-controller role #39

Fixes #33 #43 : Create ps4-controller role #39

Conversation

yannis-mlgrn commented Apr 16, 2022 • edited Loading

yannis-mlgrn commented Apr 16, 2022 • edited Loading

yannis-mlgrn commented Apr 16, 2022 • edited Loading

yannis-mlgrn commented Apr 16, 2022

yannis-mlgrn commented Apr 16, 2022 • edited Loading

yannis-mlgrn commented Apr 16, 2022 • edited Loading

yannis-mlgrn commented Apr 16, 2022

Benvii commented Apr 17, 2022

Benvii left a comment

Choose a reason for hiding this comment

Benvii commented Apr 17, 2022

Benvii commented Apr 18, 2022

Benvii commented Apr 18, 2022 • edited by yannis-mlgrn Loading

Benvii commented Apr 18, 2022

yannis-mlgrn commented Apr 19, 2022 • edited Loading

The content of the service :

The content of the service if we want to restart the service on failure and wait his ip

Lines added :

Fixed in c617978 commit

yannis-mlgrn commented Apr 19, 2022

Benvii left a comment

Choose a reason for hiding this comment

Benvii commented Apr 19, 2022 • edited Loading

Test report

More details

python manage.py drive --js issue

Benvii commented Apr 19, 2022

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

yannis-mlgrn commented Apr 16, 2022 •

edited

Loading

Benvii commented Apr 18, 2022 •

edited by yannis-mlgrn

Loading

yannis-mlgrn commented Apr 19, 2022 •

edited

Loading

Benvii commented Apr 19, 2022 •

edited

Loading