Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ts/components/nav): remove unused allowViews prop #2276

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

firestack
Copy link
Member

@firestack firestack commented Nov 8, 2023

Depends On: #2273
Context: #2273 (comment)
Asana Ticket: https://app.asana.com/0/1148853526253420/1205762199809559/f


Copy link

github-actions bot commented Nov 8, 2023

Coverage of commit 189f566

Summary coverage rate:
  lines......: 94.8% (3013 of 3177 lines)
  functions..: 74.6% (1259 of 1688 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack force-pushed the kf/asn/panel-behaviour-search-maps branch from 0d1a0e0 to 413d98d Compare November 14, 2023 15:44
Base automatically changed from kf/asn/panel-behaviour-search-maps to master November 14, 2023 16:33
@firestack
Copy link
Member Author

I'm still unsure on if we should remove this, @lemald, do you have a preference for keeping this and closing this PR (in the case we want to merge it in the future), or removing it now and adding it back later if we need it?

@lemald
Copy link
Member

lemald commented Nov 14, 2023

I'm still unsure on if we should remove this, @lemald, do you have a preference for keeping this and closing this PR (in the case we want to merge it in the future), or removing it now and adding it back later if we need it?

Hmm I'd err on the side of removing it if we don't need it knowing that we can always add it back later, but that's just my personal feeling.

@firestack firestack force-pushed the kf/cleanup/remove-allow-views-prop branch from 189f566 to 3361bb6 Compare November 16, 2023 15:45
Copy link

Coverage of commit 3361bb6

Summary coverage rate:
  lines......: 94.8% (3013 of 3177 lines)
  functions..: 74.6% (1259 of 1688 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack force-pushed the kf/cleanup/remove-allow-views-prop branch from 3361bb6 to 554ab0c Compare November 16, 2023 16:29
Copy link

Coverage of commit 554ab0c

Summary coverage rate:
  lines......: 94.8% (3013 of 3177 lines)
  functions..: 74.6% (1259 of 1688 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack merged commit 821f3da into master Nov 16, 2023
8 checks passed
@firestack firestack deleted the kf/cleanup/remove-allow-views-prop branch November 16, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants