cleanup(ts/components/nav): remove unused allowViews prop

mbta · Nov 16, 2023 · 3361bb6 · 3361bb6
1 parent 5a7ba3a
commit 3361bb6
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 118 deletions.
diff --git a/assets/src/components/app.tsx b/assets/src/components/app.tsx
@@ -70,7 +70,7 @@ export const AppRoutes = () => {
       </div>
       <VehiclesByRouteIdProvider vehiclesByRouteId={vehiclesByRouteId}>
         <div className="l-app__main">
-          <Nav allowViews>
+          <Nav>
             <Routes>
               <Route
                 element={

diff --git a/assets/src/components/nav.tsx b/assets/src/components/nav.tsx
@@ -9,10 +9,9 @@ import { StateDispatchContext } from "../contexts/stateDispatchContext"
 
 interface Props {
   children?: React.ReactNode
-  allowViews: boolean
 }
 
-const Nav: React.FC<Props> = ({ children, allowViews }) => {
+const Nav: React.FC<Props> = ({ children }) => {
   const [, dispatch] = useContext(StateDispatchContext)
   const deviceType = useScreenSize()
 
@@ -34,7 +33,6 @@ const Nav: React.FC<Props> = ({ children, allowViews }) => {
               defaultToCollapsed={true}
               dispatcherFlag={readDispatcherFlag()}
               closePickerOnViewOpen={true}
-              allowViews={allowViews}
             />
           </div>
         </div>
@@ -48,7 +46,6 @@ const Nav: React.FC<Props> = ({ children, allowViews }) => {
               toggleMobileMenu={() => dispatch(toggleMobileMenu())}
               defaultToCollapsed={true}
               dispatcherFlag={readDispatcherFlag()}
-              allowViews={allowViews}
             />
           </div>
         </div>
@@ -64,7 +61,6 @@ const Nav: React.FC<Props> = ({ children, allowViews }) => {
             <LeftNav
               defaultToCollapsed={false}
               dispatcherFlag={readDispatcherFlag()}
-              allowViews={allowViews}
             />
           </div>
         </div>

diff --git a/assets/src/components/nav/leftNav.tsx b/assets/src/components/nav/leftNav.tsx
@@ -30,15 +30,13 @@ interface Props {
   toggleMobileMenu?: () => void
   defaultToCollapsed: boolean
   dispatcherFlag: boolean
-  allowViews: boolean
   closePickerOnViewOpen?: boolean
 }
 
 const LeftNav = ({
   toggleMobileMenu,
   defaultToCollapsed,
   dispatcherFlag,
-  allowViews,
   closePickerOnViewOpen,
 }: Props): JSX.Element => {
   const [{ mobileMenuIsOpen, pickerContainerIsVisible }, dispatch] =
@@ -148,7 +146,6 @@ const LeftNav = ({
                   }
                 }}
                 collapsed={collapsed}
-                disabled={!allowViews}
               />
             </li>
           ) : null}
@@ -173,7 +170,6 @@ const LeftNav = ({
                 }
               }}
               collapsed={collapsed}
-              disabled={!allowViews}
             />
           </li>
           <li>
@@ -191,7 +187,6 @@ const LeftNav = ({
               }}
               name="Notifications"
               collapsed={collapsed}
-              disabled={!allowViews}
             />
           </li>
         </ul>

diff --git a/assets/tests/components/__snapshots__/app.test.tsx.snap b/assets/tests/components/__snapshots__/app.test.tsx.snap
@@ -224,7 +224,6 @@ exports[`App renders 1`] = `
                 </li>
                 <li>
                   <button
-                    aria-disabled="false"
                     class="c-left-nav__link c-left-nav__view"
                     title="Swings View"
                   >
@@ -238,7 +237,6 @@ exports[`App renders 1`] = `
                 </li>
                 <li>
                   <button
-                    aria-disabled="false"
                     class="c-left-nav__link c-left-nav__view"
                     title="Notifications"
                   >

diff --git a/assets/tests/components/__snapshots__/appStateWrapper.test.tsx.snap b/assets/tests/components/__snapshots__/appStateWrapper.test.tsx.snap
@@ -256,7 +256,6 @@ exports[`renders 1`] = `
                 </li>
                 <li>
                   <button
-                    aria-disabled="false"
                     class="c-left-nav__link c-left-nav__view"
                     title="Swings View"
                   >
@@ -270,7 +269,6 @@ exports[`renders 1`] = `
                 </li>
                 <li>
                   <button
-                    aria-disabled="false"
                     class="c-left-nav__link c-left-nav__view"
                     title="Notifications"
                   >

diff --git a/assets/tests/components/nav.test.tsx b/assets/tests/components/nav.test.tsx
@@ -29,7 +29,7 @@ describe("Nav", () => {
 
     const result = render(
       <BrowserRouter>
-        <Nav allowViews={true}>Hello, world!</Nav>
+        <Nav>Hello, world!</Nav>
       </BrowserRouter>
     )
 
@@ -44,7 +44,7 @@ describe("Nav", () => {
 
     const result = render(
       <BrowserRouter>
-        <Nav allowViews={true}>Hello, world!</Nav>
+        <Nav>Hello, world!</Nav>
       </BrowserRouter>
     )
 
@@ -57,7 +57,7 @@ describe("Nav", () => {
 
     const result = render(
       <BrowserRouter>
-        <Nav allowViews={true}>Hello, world!</Nav>
+        <Nav>Hello, world!</Nav>
       </BrowserRouter>
     )
 
@@ -70,7 +70,7 @@ describe("Nav", () => {
 
     render(
       <BrowserRouter>
-        <Nav allowViews={true}>Hello, world!</Nav>
+        <Nav>Hello, world!</Nav>
       </BrowserRouter>
     )
 
@@ -81,7 +81,7 @@ describe("Nav", () => {
   test("renders desktop nav content", () => {
     const result = render(
       <BrowserRouter>
-        <Nav allowViews={true}>Hello, world!</Nav>
+        <Nav>Hello, world!</Nav>
       </BrowserRouter>
     )