Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link VPC run number to VPP #2263

Merged
merged 20 commits into from
Oct 26, 2023
Merged

Link VPC run number to VPP #2263

merged 20 commits into from
Oct 26, 2023

Conversation

lemald
Copy link
Member

@lemald lemald commented Oct 20, 2023

Asana ticket: ⚙️ Link VPC Run # to VPP Run tab

Having the selection state for the VPP on the search maps page live in a useState hook in the component is probably not the long-term solution here, but I think it's an appropriate start for the purposes of this particular ticket.

One thing I'm not 100% sure on that I'd like feedback about is naming of callback function props and when those should or shouldn't start with on. My thinking was that clicking the run is a specific action / event handler so that should be onRunClicked, but closing the VPP can happen for a number of reasons and I opted to call it closePanel, but I'm open to changing that.

@lemald lemald temporarily deployed to dev-blue October 20, 2023 16:06 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 29d32fb

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@lemald lemald force-pushed the lem-link-vpc-run-number-to-vpp branch from 29d32fb to 3dd60e3 Compare October 20, 2023 17:17
@lemald lemald temporarily deployed to dev-blue October 20, 2023 17:18 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 3dd60e3

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@lemald lemald marked this pull request as ready for review October 20, 2023 18:20
@lemald lemald requested a review from a team as a code owner October 20, 2023 18:20
firestack
firestack requested changes Oct 20, 2023
View reviewed changes
assets/src/components/mapPage/vehiclePropertiesCard.tsx Outdated Show resolved Hide resolved
assets/tests/components/mapPage.test.tsx Outdated Show resolved Hide resolved
assets/src/components/propertiesPanel.tsx Outdated Show resolved Hide resolved
assets/tests/components/mapPage.test.tsx Outdated Show resolved Hide resolved
assets/src/components/mapPage.tsx Outdated Show resolved Hide resolved
assets/src/components/propertiesPanel/vehiclePropertiesPanel.tsx Outdated Show resolved Hide resolved
@lemald lemald temporarily deployed to dev-blue October 20, 2023 19:38 — with GitHub Actions Inactive
@lemald lemald force-pushed the lem-link-vpc-run-number-to-vpp branch 2 times, most recently from 53850aa to c8c034e Compare October 20, 2023 19:45
@github-actions
Copy link

Coverage of commit 53850aa

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@lemald lemald temporarily deployed to dev-blue October 20, 2023 19:50 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit c8c034e

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions
Copy link

Coverage of commit c8c034e

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions
Copy link

Coverage of commit 5ab9ae5

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@lemald lemald force-pushed the lem-link-vpc-run-number-to-vpp branch from 5ab9ae5 to 96d3ee7 Compare October 23, 2023 13:40
@github-actions
Copy link

Coverage of commit 96d3ee7

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@lemald lemald temporarily deployed to dev-blue October 23, 2023 13:50 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit f57cd79

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@lemald lemald temporarily deployed to dev-blue October 23, 2023 15:11 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 8f60fb0

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions
Copy link

Coverage of commit 8f60fb0

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@lemald lemald temporarily deployed to dev-blue October 23, 2023 15:34 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit 768a696

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

lemald and others added 18 commits October 24, 2023 09:37
@lemald
refactor: start lifting tab state into PropertiesPanel component
c7ccf89
@lemald
refactor: move GhostPropertiesPanel tabmode to props
12c1453
@lemald
refactor: StaleDataPropertiesPanel tabmode refactor
7349e6a
@lemald
refactor: move closing of properties panel into callback prop
abfcb05
@lemald
test: more tests for setTabMode callbacks
aef5254
@lemald
refactor: remove some reliance on useState / useEffect
10b4831
@lemald
refactor: modify mapModeForUser to prevent recursive import
42a2a0e
@lemald
feat: ability to select VPP from VPC run number
66f0f1c
@lemald
test: more tests for closePanel callback
a4f57d6
@lemald
refactor: better name for selected vehicle state variable in MapPage
f3bb22c
@lemald
refactor: consistent tense in callback names
6effc1b
@lemald @firestack
refactor(tests): better query for selected VPP tab
f879b5c 
Co-authored-by: Kayla Firestack <[email protected]>
@lemald
refactor(tests): clean up default mocks in mapPage.test.tsx
b9e6237
@lemald
refactor(tests): clean up default mocks in propertiesPanel.test.tsx
e22580c
@lemald
refactor: common type for shared properties panel props
2f4137f
@lemald
refactor: rename setTabMode to onChangeTabMode
4d699b6
@lemald
refactor: rename closePanel to onClosePanel
2642ff9
@lemald
refactor: also rename props on properties panel header component
c105b6e
@lemald lemald force-pushed the lem-link-vpc-run-number-to-vpp branch from 768a696 to c105b6e Compare October 24, 2023 13:49
@lemald lemald temporarily deployed to dev-blue October 24, 2023 13:49 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit c105b6e

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@lemald lemald temporarily deployed to dev-blue October 26, 2023 14:29 — with GitHub Actions Inactive
@github-actions
Copy link

Coverage of commit dbe26ee

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@lemald lemald merged commit 1d752ba into master Oct 26, 2023
8 checks passed
@lemald lemald deleted the lem-link-vpc-run-number-to-vpp branch October 26, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

Assignees
No one assigned
Labels
deploy-to-dev-blue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemald @firestack