refactor(tests): better query for selected VPP tab

Co-authored-by: Kayla Firestack <[email protected]>
mbta · Oct 20, 2023 · c8c034e · c8c034e
1 parent 05fabac
commit c8c034e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/assets/tests/components/mapPage.test.tsx b/assets/tests/components/mapPage.test.tsx
@@ -969,10 +969,9 @@ describe("<MapPage />", () => {
 
     expect(vehiclePropertiesPanelHeader.get()).toBeInTheDocument()
 
-    expect(screen.getByRole("tab", { name: "Run" })).toHaveAttribute(
-      "aria-selected",
-      "true"
-    )
+    expect(
+      screen.getByRole("tab", { name: "Run", selected: true })
+    ).toBeVisible()
   })
 
   describe("<VehiclePropertiesCard />", () => {

diff --git a/assets/tests/components/propertiesPanel.test.tsx b/assets/tests/components/propertiesPanel.test.tsx
@@ -211,10 +211,9 @@ describe("PropertiesPanel", () => {
   test("respects initialTab prop", () => {
     render(<PropertiesPanelWrapper vehicleOrGhost={vehicle} initialTab="run" />)
 
-    expect(screen.getByRole("tab", { name: "Run" })).toHaveAttribute(
-      "aria-selected",
-      "true"
-    )
+    expect(
+      screen.getByRole("tab", { name: "Run", selected: true })
+    ).toBeVisible()
   })
 
   test("supplied closePanel prop is used", async () => {