-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for Trusted Types that mutation observers receive the default policy value when setAttribute
is called
#1
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 516ca10 - Browse repository at this point
Copy the full SHA 516ca10View commit details -
Consider signed zeroes in min(), max() and clamp().
Differential Revision: https://phabricator.services.mozilla.com/D195180 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1867569 gecko-commit: b26966a8b4176b72a71e58e606e42940a30d70d6 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 3a75c6b - Browse repository at this point
Copy the full SHA 3a75c6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09968e7 - Browse repository at this point
Copy the full SHA 09968e7View commit details -
Bump taskcluster from 59.2.0 to 60.3.2 in /tools
Bumps [taskcluster](https://github.com/taskcluster/taskcluster) from 59.2.0 to 60.3.2. - [Release notes](https://github.com/taskcluster/taskcluster/releases) - [Changelog](https://github.com/taskcluster/taskcluster/blob/main/CHANGELOG.md) - [Commits](taskcluster/taskcluster@v59.2.0...v60.3.2) --- updated-dependencies: - dependency-name: taskcluster dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 37bcd1c - Browse repository at this point
Copy the full SHA 37bcd1cView commit details -
Bump pygithub from 2.1.1 to 2.2.0 in /tools
Bumps [pygithub](https://github.com/pygithub/pygithub) from 2.1.1 to 2.2.0. - [Release notes](https://github.com/pygithub/pygithub/releases) - [Changelog](https://github.com/PyGithub/PyGithub/blob/main/doc/changes.rst) - [Commits](PyGithub/PyGithub@v2.1.1...v2.2.0) --- updated-dependencies: - dependency-name: pygithub dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 397bc08 - Browse repository at this point
Copy the full SHA 397bc08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71ddae6 - Browse repository at this point
Copy the full SHA 71ddae6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d0bc46 - Browse repository at this point
Copy the full SHA 3d0bc46View commit details -
blink/flexbox: justify-content, space-around fallback to safe center
specified in: https://www.w3.org/TR/css-align-3/#valdef-align-content-space-around decision: w3c/csswg-drafts#5088 (comment) Bug: 1517655 Change-Id: I348273d53025d3a5389e1867e74c59aee291d0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5250231 Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255119}
Configuration menu - View commit details
-
Copy full SHA for 129ab16 - Browse repository at this point
Copy the full SHA 129ab16View commit details -
Consolidate and remove tentative from :state() WPTs
The spec was merged here, so the tests should no longer be tentative: whatwg/html#8467 Bug: 1514397 Change-Id: I121e5e734145ff4cb122fb1bc2f7a5bc146dafca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5151685 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255129}
Configuration menu - View commit details
-
Copy full SHA for 9b7754b - Browse repository at this point
Copy the full SHA 9b7754bView commit details -
Fenced frames: Make embedder-initiated fenced frame root navigation W…
…PT less flaky Bug: 1515599, 1524064 Change-Id: I6ae7dab6bae07a08437e0f7aa5c815f9a7d6a9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258720 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Garrett Tanzer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255181}
Configuration menu - View commit details
-
Copy full SHA for b077dc1 - Browse repository at this point
Copy the full SHA b077dc1View commit details -
[SAA] Implementing SharedWorker support (Part 2: Expose same-site coo…
…kie IDL) The Storage Access API provides access to unpartitioned cookies in third-party contexts. This CL is part of a series to extend that access to SharedWorkers. Before we actually provide access to SharedWorkers, we need a way for the renderer to limit the scope of SameSite cookies provided to the worker. Normally, a worker with a first-party storage key could access all cookies, but if access is via the SAA handle we want to limit that access to just SameSite: None cookies. This CL is part of a series to allow that limiting ability. For now, we expose the option in IDL but do not implement the change needed to limit cookie access in first-party contexts when the option is set to 'none'. The next CL will implement this limit. Note: The ability to request 'all' in a third-party context is not added here nor will it be added. We verify that an exception is thrown if this is attempted. Explainer: https://privacycg.github.io/saa-non-cookie-storage/shared-workers.html Part 1: Expose same-site cookie IPC Part 2: Expose same-site cookie IDL Part 3: Implement same-site cookie filtering Part 4: Add SharedWorker support to SAA handle Bug: 1484966 Change-Id: I8c56c02025950e119e3967afd49ed684446fd6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5251551 Reviewed-by: Weizhong Xia <[email protected]> Auto-Submit: Ari Chivukula <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Reviewed-by: Sun Yueru <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255183}
Configuration menu - View commit details
-
Copy full SHA for 3edd482 - Browse repository at this point
Copy the full SHA 3edd482View commit details -
[grid] Fix safe centering of space-around/space-evenly.
Similar to: https://chromium-review.googlesource.com/c/chromium/src/+/5250231 https://chromium-review.googlesource.com/c/chromium/src/+/5235235 Makes space-around/space-evenly fallback to safe centering alignment. See: w3c/csswg-drafts#5088 (comment) Bug: 1517655 Change-Id: I65b9b5e0540a53b61b61cd2c84d98b41f292ad76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258681 Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: Kurt Catti-Schmidt <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255220}
Configuration menu - View commit details
-
Copy full SHA for 146535e - Browse repository at this point
Copy the full SHA 146535eView commit details -
[FedCM] Grant sharing permission in Resolve
Bug: 1476927 Change-Id: Ia7361777d5fb1457a066d3f62cf73181c9b1f1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237290 Reviewed-by: Nicolás Peña <[email protected]> Commit-Queue: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255296}
Configuration menu - View commit details
-
Copy full SHA for e76d5be - Browse repository at this point
Copy the full SHA e76d5beView commit details -
[A11y] Handle illegal aria-owns from <br>
Fixed: 1510241 Change-Id: I1ce3571c56fcfd6cc6d57458ff644162588d233a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259102 Reviewed-by: Mark Schillaci <[email protected]> Commit-Queue: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255303}
Configuration menu - View commit details
-
Copy full SHA for 747837a - Browse repository at this point
Copy the full SHA 747837aView commit details
Commits on Feb 2, 2024
-
WebNN: Define XNNPACK Node for matmul
This CL implements DefineXnnNodeForMatmul() method that defines XNNPACK matmul Node by xnn_define_batch_matrix_multiply(). For unit tests, this CL implements MatmulTest of MLGraphTest that checks the compute results of matmul operators. Bug: 1273291 Change-Id: Ife8e1023804d4b9970bfff067fbeedbf12ba313e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5232604 Commit-Queue: Lisha Guo <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255409}
Configuration menu - View commit details
-
Copy full SHA for 755d6d2 - Browse repository at this point
Copy the full SHA 755d6d2View commit details -
[LineBreaker] Remove parallel flow break tokens when rewinding floats
When crrev.com/c/5052124 started rewinding floats, its associated parallel flow break tokens should also be reset, but it didn't. This patch fixes it. The 3 tests are for the same cause, but may produce different crash points. The `1` and `2` variants are more minimized and easier to understand, but they produce different symptoms than the original case that they may not always spot this issue as the code evolves. Bug: 1520442 Change-Id: I3546dba37d0dd2324804ad6c6a408ed162934663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5251158 Commit-Queue: Koji Ishii <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255473}
Configuration menu - View commit details
-
Copy full SHA for 6e5d970 - Browse repository at this point
Copy the full SHA 6e5d970View commit details -
Export MathML dir-* tests to WPT.
- dir-3.html/dir-5.html: These are approximative verifications of overall RTL directionality using "covering rectangles". Export them with a a specific font in order to make them a bit more robust. For dir-5.html we use scripts-spaceafterscript3000.woff and adjust the rects accordingly but the test might change later depending on the outcome of w3c/mathml-core#217. - dir-4-ref.html: Removed (the test was removed in bug 1783995). Differential Revision: https://phabricator.services.mozilla.com/D199702 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876684 gecko-commit: eb00222e557742d5a6c66534f38345ddf71deaa5 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 32af21e - Browse repository at this point
Copy the full SHA 32af21eView commit details -
Export some dynamic reftests to WPT.
- mo-movablelimits-dynamic.html: This is the same as the WPT test mathml/presentation-markup/operators/mo-movablelimits-dynamic.html - munderover-accentunder-dynamic/munderover-accent-dynamic: There does not seem to be any equivalent tests. It's possible the tests need some refinement to make sure the attributes have an effect on this testcase, but for now it's safe to just export them as is. Differential Revision: https://phabricator.services.mozilla.com/D199738 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876684 gecko-commit: 607f0b698ed2f1632afa2168bb416bfdeb2a5e25 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for f10f928 - Browse repository at this point
Copy the full SHA f10f928View commit details -
Suppress scrollable table cells when printing.
Much like we suppress most (all?) other block-level scrollframes, see: https://searchfox.org/mozilla-central/rev/5c4a45eb17423373ecb71aea9819d41a6231613e/layout/base/nsCSSFrameConstructor.cpp#4392-4394 Otherwise we try to fragment a scrollframe, not good. Differential Revision: https://phabricator.services.mozilla.com/D200370 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1877591 gecko-commit: 24dacb4bb526be404f5617ca9413a4a12c5314b7 gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for 67451f9 - Browse repository at this point
Copy the full SHA 67451f9View commit details -
[LineBreaker] Add a test for crbug.com/1520442
This patch adds a test, which was accidentally lost while renaming in PS8 of crrev.com/c/5251158. The content is the same as the one in PS7. Bug: 1520442 Change-Id: Ie9b72f63a9560b803f7cd3120c45cc3071302405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5261043 Reviewed-by: Morten Stenshorne <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255506}
Configuration menu - View commit details
-
Copy full SHA for 5a5bd1e - Browse repository at this point
Copy the full SHA 5a5bd1eView commit details -
[wdspec] add a test for verifying local storage isolation in user con…
…texts (web-platform-tests#44378)
Configuration menu - View commit details
-
Copy full SHA for 14d6dc2 - Browse repository at this point
Copy the full SHA 14d6dc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc41ddc - Browse repository at this point
Copy the full SHA fc41ddcView commit details -
Don't retarget nullptr in InvokeEvent::invoker
This fixes a bug where dispatching an InvokeEvent with a null invoker will cause a nullptr exception as it tries to retarget the Invoker based on the currentTarget. The fix returns early nullptr if invoker is a nullptr, which also skips the CHECK_EQ on eventPhase(), as just guarding the Retarget call would skip to this check which would cause the check to fail if invoker was retrieved during the bubbling phase. Bug: 1511341 Change-Id: I6e0e250a47466a502daeb8ab32335ff1521edc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260418 Commit-Queue: Joey Arhar <[email protected]> Auto-Submit: Keith Cirkel <[email protected]> Reviewed-by: David Baron <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255591}
Configuration menu - View commit details
-
Copy full SHA for 74ce315 - Browse repository at this point
Copy the full SHA 74ce315View commit details -
Update IsElementReflectionAttribute
All element reflection IDL attributes must have their attribute name return true in IsElementReflectionAttribute, or else the attribute and javascript getter will not be kept in sync. This patch adds the popovertarget and anchor attributes to that list and also adds a DCHECK to make sure that when the generated IDL code sets an element attribute, that attribute is listed in IsElementReflectionAttribute. Fixed: 1523410 Change-Id: I919153b894884507530b2bb219c4cbf7327780a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260611 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255605}
Configuration menu - View commit details
-
Copy full SHA for 8b0c670 - Browse repository at this point
Copy the full SHA 8b0c670View commit details -
The timeout is the likely culprit. If the test flakes again, we should put the TestExpectations entry back and re-investigate. Bug: 1430215 Change-Id: I27d450e37920072d04018b1e191b8e7efb1867dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5262097 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255607}
Configuration menu - View commit details
-
Copy full SHA for cf2518c - Browse repository at this point
Copy the full SHA cf2518cView commit details -
Intent-to-ship: https://groups.google.com/u/2/a/chromium.org/g/blink-dev/c/S67zJ1AYW2U Bug: 1466250 Change-Id: Idfa99b35a900440beb53b1c6a7a7af8bee2a66c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5261861 Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255674}
Configuration menu - View commit details
-
Copy full SHA for f1d9aa9 - Browse repository at this point
Copy the full SHA f1d9aa9View commit details -
Revert "Remove empty closed paths"
This reverts commit 572074cb06425797e7e110511db405134cf67e2f. Reason for revert: caused regression bug: crbug.com/1521614 Original change's description: > Remove empty closed paths > > As discussed in the github issue, > whatwg/html#1079, it's generally agreed to > skip drawing line caps for closed paths. This is a follow up cl of: > https://chromium-review.googlesource.com/c/chromium/src/+/4864061. > > In this cl, it verifies if each closed path is empty, then it removes > the empty closed subpaths from path. As the subpaths are removed, the > corresponding line caps are skipped. > > Bug: 644067 > > Change-Id: I14c5c4819a31eb9249d01574ff1b5c60826c3b9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916516 > Commit-Queue: Yi Xu <[email protected]> > Reviewed-by: Jean-Philippe Gravel <[email protected]> > Reviewed-by: Justin Novosad <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1247735} Bug: 644067 Change-Id: I33ecfd76574d6f60e6f8c471a38183f87757e3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258624 Reviewed-by: Aaron Krajeski <[email protected]> Reviewed-by: Jean-Philippe Gravel <[email protected]> Commit-Queue: Yi Xu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255711}
Configuration menu - View commit details
-
Copy full SHA for 64b75a9 - Browse repository at this point
Copy the full SHA 64b75a9View commit details -
Remove custom-elements/state/idlharness.window.js
This test doesn't actually work since it references an idl file which isn't defined. I manually verified that the CustomStateSet idl is already tested by external/wpt/html/dom/idlharness.https.html so there is no need for this separate test file anymore. Change-Id: If4aca93159724cdb9e7d007933635a2d55d06f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5253030 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Stephen McGruer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255766}
Configuration menu - View commit details
-
Copy full SHA for 117e60e - Browse repository at this point
Copy the full SHA 117e60eView commit details -
Fix some crashes in StylableSelect HTML parser
This patch forbids nested <button>s and <datalist>s to avoid setting kInSelectMode while we are technically still in a <button> or <datalist>. This patch also replaces a call to SetInsertionMode() with ResetInsertionModeAppropriately() and moves it after processing the end tag in order to avoid ending up in kInSelectMode when there is not actually an open <select> tag. The clusterfuzz crash didn't have a minimal repro but I manually verified that the crash does not repro with this patch. Bug: 1511354 Fixed: 1519396 Change-Id: I4358973b36925ea0862f4050f27f804d2676288c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5254124 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255770}
Configuration menu - View commit details
-
Copy full SHA for 78ce8e7 - Browse repository at this point
Copy the full SHA 78ce8e7View commit details -
Add unicode-bidi UA stylesheet rules
Per spec: https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering this should be in the UA stylesheet: address, blockquote, center, div, figure, figcaption, footer, form, header, hr, legend, listing, main, p, plaintext, pre, summary, xmp, article, aside, h1, h2, h3, h4, h5, h6, hgroup, nav, section, search, table, caption, colgroup, col, thead, tbody, tfoot, tr, td, th, dir, dd, dl, dt, menu, ol, ul, li, bdi, output, [dir=ltr i], [dir=rtl i], [dir=auto i] { unicode-bidi: isolate; } To avoid breakage, I just added the elements, and not the [dir] related rules, nor did I change the <bdo> rules. Firefox and WebKit are both making the same change: https://bugzilla.mozilla.org/show_bug.cgi?id=1874033 https://bugs.webkit.org/show_bug.cgi?id=267887 The stylesheet change interacts with the code at [1], and that code also handles some of the cases such as [dir=auto] and bdi/bdo. I will clean up some of the code at [1] in a followup CL. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/html_element.cc;l=344-363;drc=20fecf94cc2226674dfefd698e96d8d44485b19c Fixed: 1520671 Change-Id: Icaa32061efc59d963942b0629327bb596ac224ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5240082 Auto-Submit: Mason Freed <[email protected]> Reviewed-by: David Baron <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255819}
Configuration menu - View commit details
-
Copy full SHA for 53f8b53 - Browse repository at this point
Copy the full SHA 53f8b53View commit details
Commits on Feb 3, 2024
-
Preserve opened layer content across canvas flushes
When the canvas has to be presented while layers are opened, we cannot present the layer content, but we can present any painting that happened before the top most layer was opened. To do so, the recording has to be split into two parts: a main recording and a side recording. The side recording holds the content of all nested layers in one single recording. When the top most layer is closed, the content of the side recording is written to the main recording. Bug: 1484741 Change-Id: Id32412819c0395edd501243b2ccead30ebc0b674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5113500 Commit-Queue: Jean-Philippe Gravel <[email protected]> Reviewed-by: Fernando Serboncini <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255834}
Configuration menu - View commit details
-
Copy full SHA for 431e0d4 - Browse repository at this point
Copy the full SHA 431e0d4View commit details -
Add MP4 mimetype to the existing MediaRecorder web tests.
The change adds MP4 mime type to the relevant tests on the MediaRecorder tests where the test reached to the muxer level. There is a bug that block the change of 'PMediaRecorder-peerconnection.https.html', which will be handled with bug fix of 1523375. Bug: 1072056 Change-Id: Ie3c2c306bb454e1eb8914047137c6a5844bcdfdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5250746 Commit-Queue: Sunggook Chue <[email protected]> Reviewed-by: Hirokazu Honda <[email protected]> Reviewed-by: Dale Curtis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255836}
Configuration menu - View commit details
-
Copy full SHA for bb2ac6b - Browse repository at this point
Copy the full SHA bb2ac6bView commit details -
Add WPTs for race-network-and-fetch-handler option (web-platform-test…
…s#44345) Adds tests for `race-network-and-fetch-handler`, which is the service worker static routing API's router source option. This tests check the case when the network request wins and the fetch handler wins the race respectively, both for the main resource and subresource. Bug: 1519727 Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919 Commit-Queue: Shunya Shishido <[email protected]> Reviewed-by: Yoshisato Yanagisawa <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255046} Co-authored-by: sisidovski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 33a65d0 - Browse repository at this point
Copy the full SHA 33a65d0View commit details -
Event Timing reports EventTarget for more pointer events (web-platfor…
…m-tests#44372) Only in cases where there is not a single pointer event registered on a page, blink may entirely optimize out EventDispatch steps, since there are no observers anyway. This optimization should not normally be detectable. However, the Event Timing API still measures these events and reports them to the performance timeline. Because the EventDispatch steps are where we assign EventTarget to Event objects, the Event Timing API was effectively missing the target value whenever we skipped this step. This patch plumbs the original HitTest target which we fall back to under such situations. Bug: 1367329 Change-Id: Icf21e6103c98261e9f6e88cef1ac09f3a683751b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5246848 Commit-Queue: Michal Mocny <[email protected]> Reviewed-by: Aoyuan Zuo <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255634} Co-authored-by: Michal Mocny <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e1bc60c - Browse repository at this point
Copy the full SHA e1bc60cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 621a069 - Browse repository at this point
Copy the full SHA 621a069View commit details -
Prototype a user-find css property to control findability of text.
Nightly-only for now waiting on CSSWG discussion. Differential Revision: https://phabricator.services.mozilla.com/D199727 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1868316 gecko-commit: 6fdde7dce00345bc568706b0cf7de521b91ba75a gecko-reviewers: jfkthame
Configuration menu - View commit details
-
Copy full SHA for 385fce8 - Browse repository at this point
Copy the full SHA 385fce8View commit details -
Add wpt crashtest for this (fixed) bug.
Differential Revision: https://phabricator.services.mozilla.com/D200523 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1144434 gecko-commit: e6b6322cf7a97bfef714c3e1c901937546fb740f gecko-reviewers: TYLin
Configuration menu - View commit details
-
Copy full SHA for 9cc8dca - Browse repository at this point
Copy the full SHA 9cc8dcaView commit details -
Add null-check to aria_utils verifyLabelsBySelector (web-platform-tes…
…ts#44361) * Add null-check to aria_utils verifyLabelsBySelector Before this commit, verifyLabelsBySelector calls test_driver.get_computed_label and then does string-manipulation on the result. For some reason, this get_computed_label invocation returns null in Firefox, and so the string-manipulation causes a JS exception to be thrown, which makes for awkward test failure results. Let's just explicitly assert that the result is not-null, to make that expectation clearer and to give a cleaner test-failure in cases where it is unexpectedly null.
Configuration menu - View commit details
-
Copy full SHA for faa6d42 - Browse repository at this point
Copy the full SHA faa6d42View commit details
Commits on Feb 5, 2024
-
Router evaluation for subresources in the no fetch handler case
Before this CL, in the renderer, registered routers are not evaluated if there is no fetch handler in the service worker. This is critical and introduces unexpected behavior for the static routing API, because developer may only use static routing API, that doesn't guarantee the fetch handler existence. This CL add the new boolean field, `need_router_evaluate` to ControllerServiceWorkerInfo mojo interface. The renderer side use this field to decide whether it involves ServiceWorkerSubresourceLoader or not. Bug: 1511459 Change-Id: I88e09900931a149c78cc4f25015fa5a5b1ffd62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5252809 Reviewed-by: Yoshisato Yanagisawa <[email protected]> Reviewed-by: Takashi Toyoshima <[email protected]> Commit-Queue: Shunya Shishido <[email protected]> Reviewed-by: Minoru Chikamune <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256065}
Configuration menu - View commit details
-
Copy full SHA for 2b2d9df - Browse repository at this point
Copy the full SHA 2b2d9dfView commit details -
Export link-001.html as a tentative WPT.
This tests color of `<mtext href>` links. Although links were mentioned in a previous draft of MathML Core, they have been removed from the current version and adding them back is pending consensus. However, upstream WPT still contains tests for MathML links so it makes sense to have all of these tentative tests. This commit exports `link-001.html` as a tentative mismatch reftest with proper renaming (note that the `<link rel="mismatch">` refers to a non-existent `link-color-001-ref.xhtml` file). Similarly, all the existing tests assuming support for `href` are renamed as 'tentative' tests. Finally, we also remove a few annotations from bug 1798871. There is no behavior change. Differential Revision: https://phabricator.services.mozilla.com/D200441 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876684 gecko-commit: 5ec8a1a095532086defe3180d8ca1d16cd53df20 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 090e95a - Browse repository at this point
Copy the full SHA 090e95aView commit details -
Export some MathML mpadded reftests to WPT.
- mpadded-1/2/3.html, mpadded-1-2.html: These are testing visual rendering of two nested mpadded elements with basic attribute values that are accepted by MathML Core. - mpadded-4.html: This is testing mpadded attribute with pseudo units, which are not supported by MathML Core, so convert to internal WPT test. - mpadded-5/6: These are testing negative values of some mpadded attributes whose interpretation or support is unclear in MathML Core. So convert to internal WPT tests for now. Differential Revision: https://phabricator.services.mozilla.com/D200442 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876684 gecko-commit: a55c77e16ea8c476eee487f52739314d54a3c39a gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 8a8b233 - Browse repository at this point
Copy the full SHA 8a8b233View commit details -
Add wpt crashtest for this (fixed) bug.
Differential Revision: https://phabricator.services.mozilla.com/D200542 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1232875 gecko-commit: fd1e72bb806598ff45f5c53732b3a63286505aeb gecko-reviewers: layout-reviewers, emilio
Configuration menu - View commit details
-
Copy full SHA for 3d54b13 - Browse repository at this point
Copy the full SHA 3d54b13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85f9a17 - Browse repository at this point
Copy the full SHA 85f9a17View commit details -
Remove impossible test for non-string "Credential"
The test that "credential" will be a DOMString turned out to be a failure because any Javascript object can be converted to the string "[Object object]". The referenced part of the specification isn't there any more. Bug: None Change-Id: Ie6a08a24f76e7a895517feef587ff31ecfe2fdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5266622 Reviewed-by: Guido Urdaneta <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256182}
Configuration menu - View commit details
-
Copy full SHA for 1f864a2 - Browse repository at this point
Copy the full SHA 1f864a2View commit details -
Add test for console logging a Symbol
Signed-off-by: syvb <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d0a66df - Browse repository at this point
Copy the full SHA d0a66dfView commit details -
[A11y] Do not include hidden nodes when they are ignored
The only time we need hidden nodes is when they are part of a label or description. This CL keeps track of whether a given node has ever been part of a label or description. If the node is hidden, it removes it from the tree unless it's needed for a label/description. In combination with CL:4852390, which removes hidden line breaks, reduces the time spent in serialization and deserialization by massive amounts in tests that involve heavy usage of hidden subtrees. For the specific results, see: https://docs.google.com/spreadsheets/d/1ozLJMRT32yIxE0ja0rDhdZPb76hQtDd0klcRcR_uWYU/edit?pli=1#gid=0 This will make a significant difference in web apps with panels, chats, slides, etc. where a significant percentage of the content is hidden. Bug: 1448706, 1353788 Cq-Include-Trybots: luci.chromium.try:fuchsia-x64-accessibility-rel,linux-blink-web-tests-force-accessibility-rel Change-Id: I1b0de1d9b6f037c107efd3ca93c073382fd0ece1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574033 Commit-Queue: Aaron Leventhal <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256230}
Configuration menu - View commit details
-
Copy full SHA for 83ca3f9 - Browse repository at this point
Copy the full SHA 83ca3f9View commit details -
Support :user-valid/:user-invalid on checkboxes
Checkboxes support validity via the required attribute and the other browsers support :user-valid/:user-invalid on them. The existing :user-valid/:user-invalid machinery only works on text fields, so this patch adds some code to checkboxes to make them work as well. Fixed: 1521781 Change-Id: I91309f36348470db5b1c706b519e6303e5deeab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258739 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256264}
Configuration menu - View commit details
-
Copy full SHA for 81c06c7 - Browse repository at this point
Copy the full SHA 81c06c7View commit details -
Split LoAF sourceLocation to 3 attributes
As per spec, sourceURL / sourceFunctionName / sourceCharPosition Amended existing test. Bug: 1523675 Change-Id: Ic3bb8df05bb822fa8b56990e2696d67324b4763f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5250540 Reviewed-by: Ian Clelland <[email protected]> Reviewed-by: Rick Byers <[email protected]> Reviewed-by: Michal Mocny <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256409}
Configuration menu - View commit details
-
Copy full SHA for 3c54afa - Browse repository at this point
Copy the full SHA 3c54afaView commit details
Commits on Feb 6, 2024
-
html: Tests for field-sizing (web-platform-tests#44346)
This includes tests to confirm size/cols/rows are not presentational hints. Issue: whatwg/html#6807
Configuration menu - View commit details
-
Copy full SHA for df6595e - Browse repository at this point
Copy the full SHA df6595eView commit details -
Add a test for a WebKit / Blink bug where they incorrectly simplify p…
…ercentages inside calc() in background-position longhands. See https://bugzilla.mozilla.org/show_bug.cgi?id=1874606#c3 (and the test is self-explanatory, it's just a copy of background-position-negative-percentage-comparison.html but with the longhand expanded). Differential Revision: https://phabricator.services.mozilla.com/D198532 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874606 gecko-commit: c133f145c3444956eaacebff4066a0141a971af1 gecko-reviewers: layout-reviewers, jfkthame
Configuration menu - View commit details
-
Copy full SHA for 91bfb4f - Browse repository at this point
Copy the full SHA 91bfb4fView commit details -
Avoid re-registering container query frames unnecessarily.
This is kind of a wallpaper, but I think it's sound, read below. The reason this is asserting is that MathML in particular has some odd frame re-parenting going on (see nsCSSFrameConstructor::FlushAccumulatedBlock). That means that our assert in DepthOrderedFrameList is not really holding depending on when you add or remove the frame from the list. However this is not a problem in practice, at least for container queries, because anonymous frames that can wrap mathML cannot be containers themselves. I need to figure out what to do with that assert, but given it's useful for the other users of DepthOrderedFrameList, I think we should take this for now. Differential Revision: https://phabricator.services.mozilla.com/D200634 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878188 gecko-commit: 7146c4efa63b2195fb331439048c4e1def420323 gecko-reviewers: fredw
Configuration menu - View commit details
-
Copy full SHA for 9ada1fb - Browse repository at this point
Copy the full SHA 9ada1fbView commit details -
[wdspec] Update network test module with remaining arguments network.…
…continueRequest Depends on D199749 Differential Revision: https://phabricator.services.mozilla.com/D199750 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: 2e55faaccd8265b6e48fb904d0104dc9ebdc6a84 gecko-reviewers: webdriver-reviewers, Sasha
Configuration menu - View commit details
-
Copy full SHA for b904b66 - Browse repository at this point
Copy the full SHA b904b66View commit details -
[wdspec] Add validation test for all remaining arguments of network.c…
…ontinueRequest Depends on D199750 Differential Revision: https://phabricator.services.mozilla.com/D199751 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: e088bd5cef05706254aac5844de407a74a2b3bd3 gecko-reviewers: webdriver-reviewers, Sasha
Configuration menu - View commit details
-
Copy full SHA for eb2d7f8 - Browse repository at this point
Copy the full SHA eb2d7f8View commit details -
[wdspec] Update network test module with remaining arguments network.…
…continueResponse Depends on D199751 Differential Revision: https://phabricator.services.mozilla.com/D199752 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: 9636ddc3709af33bb67d228ea6022a8257c2d1b2 gecko-reviewers: webdriver-reviewers, Sasha
Configuration menu - View commit details
-
Copy full SHA for 91dd073 - Browse repository at this point
Copy the full SHA 91dd073View commit details -
[wdspec] Add validation test for all remaining arguments of network.c…
…ontinueResponse Depends on D199752 Differential Revision: https://phabricator.services.mozilla.com/D199753 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: cf600694c18f22e5cece13d493171124eff5d04d gecko-reviewers: webdriver-reviewers, Sasha
Configuration menu - View commit details
-
Copy full SHA for 4483829 - Browse repository at this point
Copy the full SHA 4483829View commit details -
[wdspec] Add test for network.continueRequest
Depends on D199753 Differential Revision: https://phabricator.services.mozilla.com/D199754 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: c2eb34cf5007303cf4643d671d7be9e287d0e9b9 gecko-reviewers: webdriver-reviewers, Sasha
Configuration menu - View commit details
-
Copy full SHA for 299276c - Browse repository at this point
Copy the full SHA 299276cView commit details -
[wdspec] Add test for network.continueResponse
Depends on D199754 Differential Revision: https://phabricator.services.mozilla.com/D199755 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: 3884f0a38e09c6f16ef962a3b1db5623c659b4ff gecko-reviewers: webdriver-reviewers, Sasha
Configuration menu - View commit details
-
Copy full SHA for 716fe1e - Browse repository at this point
Copy the full SHA 716fe1eView commit details -
[wdspec] Add create_header and create_cookie_header helpers for bidi …
…network tests Depends on D199755 Adds test helpers to easily create header and cookie header objects Differential Revision: https://phabricator.services.mozilla.com/D200034 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: a3f956419067fa1803aa9210eb8252a3fc3daefa gecko-reviewers: whimboo, webdriver-reviewers
Configuration menu - View commit details
-
Copy full SHA for 8c4c175 - Browse repository at this point
Copy the full SHA 8c4c175View commit details -
Mark Web Locks tests non-tentative
This removes `tentative` from Web Locks tests which all three engines are passing. A couple of exceptions from https://wpt.fyi/results/web-locks?label=experimental&label=master&aligned * clientids: The test follows the spec, I think this is a Chrome bug. (https://w3c.github.io/web-locks/#dom-lockmanager-request, the use of environment's id) * signal: A couple of WebKit failures because of lack of AbortSignal custom reason support. Differential Revision: https://phabricator.services.mozilla.com/D200477 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878367 gecko-commit: 4235c5a3b4ac51348c29bfd3bf8e371b67b982c6 gecko-reviewers: smaug
Configuration menu - View commit details
-
Copy full SHA for d347c71 - Browse repository at this point
Copy the full SHA d347c71View commit details -
Add wpt crashtest for this (fixed) bug.
Differential Revision: https://phabricator.services.mozilla.com/D200716 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1267079 gecko-commit: 391d1d3ba83e86e6535622a39119feb8f2b6a2f0 gecko-reviewers: emilio, TYLin
Configuration menu - View commit details
-
Copy full SHA for 52b173f - Browse repository at this point
Copy the full SHA 52b173fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3f0f30 - Browse repository at this point
Copy the full SHA e3f0f30View commit details -
Improve reflected attribute tests (html/dom/reflection.js)
* Fix reflection tests wrt valueOf Without a toString:null in test values that are objects with a valueOf method, the DOM attribute would actually be set to "[object Object]" without ever calling the valueOf method (effectively turning those tests into behaving exactly the same as the {"test": 6} ones). Most existing tests were passing because the implemented algorithms would actually compute a WRONG expected value. The only test that doesn't compute the expected value ("double") won't actually run because all reflected IDL attributes of type "double" have custom getters. Fixes web-platform-tests#44315 * Fix reflection tests wrt -0 for "double" attributes Setting -0 to the IDL attribute will set the DOM attribute to "0" (per ECMAScript's ToString, from the rules for the the best representation of a number as a floating point number), and the rules for parsing flowting-point number values won't ever turn that "0" into a -0 value. This test value is never actually being used though, as all the reflected attributes of type "double" have custom getters. * Add a few more reflection tests around whitespace for numeric types Specifically leading non-ASCII whitespace following leading ASCII whitespace (should be rejected), and trailing non-ASCII whitespace (should be ignored) * Add a few more numeric values to reflection tests Specifically "+" and "-" to exercise all possible code paths of failures. * Add exponential notation to reflection tests of double values * Implement "limited double" in reflection tests * Implement the reflect algorithm for doubles This should make it easier to extend tests with more values.
Configuration menu - View commit details
-
Copy full SHA for cdafbec - Browse repository at this point
Copy the full SHA cdafbecView commit details -
[css-scroll-snap-2] Prioritize focused snap targets
An agreed upon proposal[1] by the CSS working group specifies that where multiple scroll snap targets are visually equally aligned, scroll containers should give priority to focused elements. Blink did this for programmatic scrolls but not for user scrolls. This patch prioritizes focused elements for both types of scrolls by relying on a bit in SnapAreaData. [1]w3c/csswg-drafts#9622 Bug: 1523819 Change-Id: I81e2aaf0845e9763abb463a960614beb37b05a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5255777 Reviewed-by: Steve Kobes <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256790}
Configuration menu - View commit details
-
Copy full SHA for d56b139 - Browse repository at this point
Copy the full SHA d56b139View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33b559d - Browse repository at this point
Copy the full SHA 33b559dView commit details -
Move CORS logic from direct-from-seller-signals.py to fledge_http_ser…
…ver_util.py The CORS logic present in direct-from-seller-signals.py is identical to that needed for other web platform tests. Moving this logic into a common function available to the endpoints needed for those other web platform tests prevents duplication. This change also attempts to match the style of the Python test server in new and existing code. Change-Id: Ia3db1e263e3e4b1e6b09bfa3408dd905a83ea44b Bug: 40275797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5269747 Commit-Queue: Orr Bernstein <[email protected]> Reviewed-by: Matt Menke <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256845}
Configuration menu - View commit details
-
Copy full SHA for 516158d - Browse repository at this point
Copy the full SHA 516158dView commit details -
[shared storage] Expose selectURL()/run() on the SharedStorageWorklet…
… interface Explainer PR: WICG/shared-storage#130 Bug: 1218540 Change-Id: I7dffe4e026a6ebf4e6705b1df43e2baf01dadb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5209512 Commit-Queue: Yao Xiao <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Reviewed-by: Cammie Smith Barnes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256903}
Configuration menu - View commit details
-
Copy full SHA for aeff916 - Browse repository at this point
Copy the full SHA aeff916View commit details -
Don't reject same site prefetches with no-referrer
The referring URL as computed by the referrer policy for the prefetch request was incorrectly being used to determine whether a prefetch was cross site. This value is only meant to be used for the prefetch request. The omission of the URL made it look like a cross site prefetch, so the cookie eligibility check was applied. We now use the initiating origin to determine whether a prefetch is cross site. Bug: 1524338 Change-Id: Id154effae55c539fff7cd733327fc9029c53b03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263133 Commit-Queue: Kevin McNee <[email protected]> Reviewed-by: Liviu Tinta <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256905}
Configuration menu - View commit details
-
Copy full SHA for 1120ba9 - Browse repository at this point
Copy the full SHA 1120ba9View commit details -
This change adds support to observe out of viewport targets inside scrollable same origin iframes using intersection observers with scrollMargin, by crossing the iframe boundary when collecting intermediate scrollers. R=szager Bug: 1503290 Change-Id: Iaf5482a67e8eb37000d54fb9529df5c16f86e644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5240906 Reviewed-by: Stefan Zager <[email protected]> Commit-Queue: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256994}
Configuration menu - View commit details
-
Copy full SHA for c0b9c86 - Browse repository at this point
Copy the full SHA c0b9c86View commit details -
Render <button> and <datalist> in <select>
Now that the HTML parser allows <button> and <datalist> in <select>, this patch modifies the UA shadowroot of <select> to slot the <button> and <datalist> and render them. If a <button> is provided with no <datalist>, then the native popup is used. If a <datalist> is provided with no <button>, then the native button is used. Bug: 1511354 Change-Id: I36f88f73949aa2cba502231ed2d68c1738e47946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5230929 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257004}
Configuration menu - View commit details
-
Copy full SHA for 803ab2a - Browse repository at this point
Copy the full SHA 803ab2aView commit details -
Remove declarative shadow DOM polyfill
Declarative shadow DOM is standard [1] and implemented in all modern browsers. This removes a polyfill that isn't needed in WPT any longer. [1] https://html.spec.whatwg.org/multipage/scripting.html#attr-template-shadowrootmode Bug: N/A Change-Id: Ie9bfdf24f75901cf9a476844a76065e5a18a6815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263643 Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257013}
Configuration menu - View commit details
-
Copy full SHA for 5eb84ee - Browse repository at this point
Copy the full SHA 5eb84eeView commit details -
[wptrunner] Plumb expectations
wpttest.{Test -> (Subtest)Result}
(w……eb-platform-tests#44424) This allows vendors to override expectations at runtime via browser-specific result converters. Instead of constructing `(Subtest)Result`s directly, executors should use the newly introduced `Test.make_{subtest_,}result()`, which have the same signatures but default to passing through the testloader-read expectations. This is a pure refactor; no functional changes intended. Successor to: web-platform-tests#44134 (comment)
Configuration menu - View commit details
-
Copy full SHA for a68f313 - Browse repository at this point
Copy the full SHA a68f313View commit details
Commits on Feb 7, 2024
-
serial: Migrate Web Serial MojoJS based tests to internal folder
This CL migrate Web Serial MojsJS based tests to internal folder temporary. We will move it back once Web Serial Testing specification for test-only interface is defined. Bug: 1524403 Change-Id: I75323dfe2a649348e23c333e1a635cf8cc9ba806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259047 Reviewed-by: Matt Reynolds <[email protected]> Commit-Queue: Alvin Ji <[email protected]> Reviewed-by: Alvin Ji <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257126}
Configuration menu - View commit details
-
Copy full SHA for 39e3ec2 - Browse repository at this point
Copy the full SHA 39e3ec2View commit details -
[wdspec] Add invalid test for browsingContext.create with removed use…
…rContext Depends on D200019 Differential Revision: https://phabricator.services.mozilla.com/D200023 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874918 gecko-commit: 9958e50aa342f1417ae85b1ceed8a11d5864d521 gecko-reviewers: webdriver-reviewers, Sasha
Configuration menu - View commit details
-
Copy full SHA for 3e6c7c2 - Browse repository at this point
Copy the full SHA 3e6c7c2View commit details -
[wdspec] Add test for browser.removeUserContext to check browsing con…
…texts are closed Depends on D200023 Differential Revision: https://phabricator.services.mozilla.com/D200339 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874918 gecko-commit: 4be6b1980ac25cdf37cea10a1b246151b6646811 gecko-reviewers: webdriver-reviewers, whimboo
Configuration menu - View commit details
-
Copy full SHA for 9afbc09 - Browse repository at this point
Copy the full SHA 9afbc09View commit details -
Add tests for zstd content-encoding (web-platform-tests#44393)
* add zstd tests and separate into folders * add bad input tests and make window size test tentative * add https to bad input test
Configuration menu - View commit details
-
Copy full SHA for 2453380 - Browse repository at this point
Copy the full SHA 2453380View commit details -
[wdspec] Add type hint parameter for context_created and context_dest…
…royed user context tests Depends on D200024 Differential Revision: https://phabricator.services.mozilla.com/D200032 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874920 gecko-commit: 0237b0c99f398a9c4ac048bbdf029d8bc16e3771 gecko-reviewers: webdriver-reviewers, whimboo
Configuration menu - View commit details
-
Copy full SHA for 173d73b - Browse repository at this point
Copy the full SHA 173d73bView commit details -
[wdspec] Always assert user context in assert_browsing_context
Depends on D200032 This should ensure good coverage of the user_context field Differential Revision: https://phabricator.services.mozilla.com/D200181 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874920 gecko-commit: 8a66a3b89c40f8a8f3195f6a92c0c3d2af587b21 gecko-reviewers: webdriver-reviewers, whimboo
Configuration menu - View commit details
-
Copy full SHA for 6c85d26 - Browse repository at this point
Copy the full SHA 6c85d26View commit details -
[wdspec] Add various user_context tests for browsingContext.create
Depends on D200181 Differential Revision: https://phabricator.services.mozilla.com/D200182 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874920 gecko-commit: 1c00d395406fc5b994ce1a16d8625ba85d57a8bd gecko-reviewers: webdriver-reviewers, whimboo
Configuration menu - View commit details
-
Copy full SHA for ed10c12 - Browse repository at this point
Copy the full SHA ed10c12View commit details -
Make declarative shadow roots of custom elements available to element…
… internals. Differential Revision: https://phabricator.services.mozilla.com/D200177 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1877025 gecko-commit: 40bac1b10006b24580bad57de6cf5efb2415ad67 gecko-reviewers: peterv, dom-core
Configuration menu - View commit details
-
Copy full SHA for c967c39 - Browse repository at this point
Copy the full SHA c967c39View commit details -
Moved position-try-order into wpt/ from wpt_internal/
Now part of the spec draft Bug: 40279608 Change-Id: I35546256c8460bfa46d1b9b7607e008d069cbd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272498 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Auto-Submit: Rune Lillesveen <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257259}
Configuration menu - View commit details
-
Copy full SHA for aee2a77 - Browse repository at this point
Copy the full SHA aee2a77View commit details -
Fully implement bidi for a line's trailing spaces (UAX#9 L1)
Per UAX#9 L1, any spaces that after line breaking would fall logically at the end of a line must be reset to the paragraph's initial embedding level, regardless of the embedding level of those spaces in the paragraph. Until now, Blink only had partial support for this. The reason this was hard to implement in Blink is because the direction of text is computed in a per-paragraph level, splitting the text into items with a given direction and embedding level. Those items are then split into item results when line breaking, but item results must have the same direction as the item. As part of line breaking, some item results are produced which only have trailing spaces. The partial support, implemented in crrev.com/c/2505486, consisted of marking these results with the `has_only_trailing_spaces` flag, and using this flag to distinguish them when reordering the item results. This patch builds on top of that partial fix by adding a final processing step to line breaking, which splits item results so that trailing spaces (with a different embedding level as the paragraph) are split into its own item result, and by marking all trailing spaces item results as `has_only_trailing_spaces`. This also fixes bug 1514753, where having a item result with non-base direction which had logically trailing spaces was causing the text (rather than the spaces) to hang, because `LineInfo::ComputeTrailingSpaceWidth` assumed that UAX#9 L1 held. This patch also modifies some existing WPT tests to make them use a monospace Arabic webfont (since it's not guaranteed that all OS's have one), and by changing the widths slightly to work around bug 1409445. Bug: 316409, 1514753 Change-Id: I1eb751b457d413b5099dad8f95badba9a1b3e5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5199988 Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Andreu Botella <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257309}
Configuration menu - View commit details
-
Copy full SHA for c635cb4 - Browse repository at this point
Copy the full SHA c635cb4View commit details -
DOM: Implement the
forEach()
Observable operatorThis CL implements the semantics specified in https://wicg.github.io/observable/#dom-observable-foreach. See WICG/observable#105. For WPTs: Co-authored-by: [email protected] [email protected] Bug: 1485981 Change-Id: I61344bad7fa4bac65146e1305a376fc1f5e55dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5249869 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257328}
Configuration menu - View commit details
-
Copy full SHA for 910e4c8 - Browse repository at this point
Copy the full SHA 910e4c8View commit details -
Make
nsRange
delete itself fromSelection
s if it becomes a range ……in different root Users of `Selection` assume that `nsRange` instances are ranges in the corresponding document. However, `Selection` may keep storing ranges in the different root only when the range is updated. I think that no spec defines this behavior, but Chromium makes `RangeUpdateScope` delete ranges which are in different root after the range is updated [1]. Let's follow this behavior for compatibility and keeping the assumption of `Selection` users. Differential Revision: https://phabricator.services.mozilla.com/D200606 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878191 gecko-commit: cfc39990144c47c50d76e747f22987360634d6f8 gecko-reviewers: smaug, jjaschke, dom-core
Configuration menu - View commit details
-
Copy full SHA for fd2fc2a - Browse repository at this point
Copy the full SHA fd2fc2aView commit details -
Follow shortest serialization principle for transition shorthand.
Per web-platform-tests#43574, we should follow the shortest serialization principle for `transition` shorthand. Differential Revision: https://phabricator.services.mozilla.com/D200410 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878758 gecko-commit: edd89a13946a1e81af2699a6a15969957c86a41e gecko-reviewers: zrhoffman
Configuration menu - View commit details
-
Copy full SHA for 7cfbb8f - Browse repository at this point
Copy the full SHA 7cfbb8fView commit details -
Only record that breakPriority indicated use of overflow-wrap if we a…
…ctually needed to break the text. Differential Revision: https://phabricator.services.mozilla.com/D200853 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878865 gecko-commit: ffcccf20cd2f4a0f07e1ada61808cc0d37b75216 gecko-reviewers: layout-reviewers, emilio
Configuration menu - View commit details
-
Copy full SHA for c3ca3ed - Browse repository at this point
Copy the full SHA c3ca3edView commit details -
Do not call CreateAndShow with the default permission
Somehow we ended up throwing if it's explicitly denied. Now it throws error with the default permission too. Differential Revision: https://phabricator.services.mozilla.com/D200826 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874958 gecko-commit: ab5b008e36a4742d737a89c8cbfc1a69e2b76456 gecko-reviewers: asuth
Configuration menu - View commit details
-
Copy full SHA for 5362cef - Browse repository at this point
Copy the full SHA 5362cefView commit details -
[shared storage] Allow creating multiple worklets per Window context
Explainer PR: WICG/shared-storage#130 How: - Introduce sharedStorage.createWorklet() method. In this patch, we still restrict the script to same origin. Ultimately, we will support cross-origin script/worklet (for the createWorklet() API). - Also, move the document service Remote to a window supplement class: This is a forward-looking change (e.g. it'll enable constructing the worklet via `new SharedStorageWorklet()` / not needing to exist along with the `sharedStorage` object, although this isn't in the current proposal). Bug: 1218540 Change-Id: I5bf64bdf6648a76875748b194e5dbceeb1400624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5209102 Reviewed-by: Dominic Farolino <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Reviewed-by: Cammie Smith Barnes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257412}
Configuration menu - View commit details
-
Copy full SHA for a973f27 - Browse repository at this point
Copy the full SHA a973f27View commit details -
[EditContext] Ensure textupdate fires for backspace/delete in <canvas>
When the active EditContext's associated element is a <canvas>, we fail to fire the textudpate event when the user hits backspace/delete. The reason is that for these keystrokes, EnabledInEditableText is used to determine whether the command is enabled, and this includes a check that the selection is contained in the focus. For <canvas> this will never be the case because <canvas> cannot contain selection. Fix this by always treating the command as enabled if there is an active EditContext, since an EditContext should always have the opportunity to handle these commands. Update some existing text input and text deletion tests to run for <canvas> in addition to <div>. Bug: 1517103, 999184 Change-Id: Id8d4509ed6b22a4516d9bfa2c4a05b234eea78de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5251988 Reviewed-by: Anupam Snigdha <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Dan Clark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257455}
Configuration menu - View commit details
-
Copy full SHA for 12a51d9 - Browse repository at this point
Copy the full SHA 12a51d9View commit details -
Correctly handle printing of overflowing monolithic OOFs.
We need to make sure that we create enough pages to contain tall monolithic out-of-flow positioned descendants, including any overflow inside of them. Similar support for in-flow elements was added in CL:5029779, where we at the same time stopped synthesizing missing pages after layout, but instead started to trust layout. However, that was premature, since out-of-flow positioned descendants of course need special treatment. Bug: 41496759 Change-Id: If52a4b1ad50ec55dbdabc6456b47a299404f7d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272404 Reviewed-by: Alison Maher <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257469}
Configuration menu - View commit details
-
Copy full SHA for 734e3b9 - Browse repository at this point
Copy the full SHA 734e3b9View commit details -
allow old headless mode for chrome (web-platform-tests#44445)
* allow old headless mode for chrome While Wptrunner's '--headless' means the new headless mode, allow passing binary arg '--headless' to chrome directly to enable the old headless mode
Configuration menu - View commit details
-
Copy full SHA for 09de1c2 - Browse repository at this point
Copy the full SHA 09de1c2View commit details -
Zoom should affect intrinsic replaced element size.
Differential Revision: https://phabricator.services.mozilla.com/D199990 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876541 gecko-commit: a7519f7b264ccb39d5a6f9ff1f9371f3febedebf gecko-reviewers: TYLin
Configuration menu - View commit details
-
Copy full SHA for c8c3d6a - Browse repository at this point
Copy the full SHA c8c3d6aView commit details -
[wdspec] Extend timeout for network/continue_response/invalid.py and …
…network/continue_request/invalid.py Differential Revision: https://phabricator.services.mozilla.com/D200901 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879006 gecko-commit: 2c96ad2803366505f65dc66c1ffc3eb96009476c gecko-reviewers: webdriver-reviewers, whimboo
Configuration menu - View commit details
-
Copy full SHA for 0e47f4f - Browse repository at this point
Copy the full SHA 0e47f4fView commit details -
Part 2 - support SVG properties on first-letter and first-line
Differential Revision: https://phabricator.services.mozilla.com/D200596 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1302722 gecko-commit: 1118131d963c7a00bb60693f1c4c15b3b4b40d17 gecko-reviewers: jfkthame, emilio
Configuration menu - View commit details
-
Copy full SHA for 5407936 - Browse repository at this point
Copy the full SHA 5407936View commit details
Commits on Feb 8, 2024
-
Always call superclass in HTMLLabelElement::DefaultEventHandler
HTMLLabelElement::DefaultEventHandler does not currently call up to HTMLElement::DefaultEventHandler in many cases. This patch makes sure that HTMLLabelElement always calls up to HTMLElement, which makes <label>s in <button>s work. WebKit's HTMLLabelElement already does this in all branches of HTMLLabelElement::defaultEventHandler since 2017: WebKit/WebKit@fec9c1d WebKit/WebKit@b9bad31 Fixed: 1523168 Change-Id: Ib9d0a63befbb930b9595bcc89fb5955050c97b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260750 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257674}
Configuration menu - View commit details
-
Copy full SHA for 3c00d74 - Browse repository at this point
Copy the full SHA 3c00d74View commit details -
Use OK status to check RaceNetworkRequest response
Reflecting the comment on yoshisatoyanagisawa/ServiceWorker#10 (comment) Bug: 1371756 Change-Id: I6de1fed384e32fbdae40799ef48d4ce2eeb3eccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5276401 Reviewed-by: Minoru Chikamune <[email protected]> Reviewed-by: Yoshisato Yanagisawa <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Commit-Queue: Shunya Shishido <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257762}
Configuration menu - View commit details
-
Copy full SHA for 4c4bec5 - Browse repository at this point
Copy the full SHA 4c4bec5View commit details -
Move monolithic-overflow-* from css/printing to css/css-page. (web-pl…
…atform-tests#44422) Ideally, css/printing/ should be emptied. Here's a step in that direction. See web-platform-tests#42937 I also just removed the failure expectations from ChromeTestExpectations, since I couldn't find the reason why they were added in the first place, and besides, all bots seem to be happy. Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546 Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257066} Co-authored-by: Morten Stenshorne <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0f06b11 - Browse repository at this point
Copy the full SHA 0f06b11View commit details -
Fix offset* APIs on tables with captions.
The offset* APIs use the primary frame (the table wrapper frame) to choose an offset parent, so if we stop at the table frame we skip the offset between the wrapper and the table boxes. Differential Revision: https://phabricator.services.mozilla.com/D200948 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876640 gecko-commit: ba1b52557eb44aa363b43e142d30c906012eb3fd gecko-reviewers: TYLin
Configuration menu - View commit details
-
Copy full SHA for cd9d5a2 - Browse repository at this point
Copy the full SHA cd9d5a2View commit details -
use ssl.SSLContext.wrap_socket rather than the deprecated ssl.wrap_so…
…cket Differential Revision: https://phabricator.services.mozilla.com/D198500 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874602 gecko-commit: dff36b78052bf17eadfe4791e8358cfab653464f gecko-reviewers: jgraham, jmaher
Configuration menu - View commit details
-
Copy full SHA for a15d391 - Browse repository at this point
Copy the full SHA a15d391View commit details -
Add coverage for
webkit
prefixed historical interface (web-platform……-tests#44462) Hi Team, It was supported by Safari / WebKit until recently and it was removed weeks ago, I think it would be good to add coverage for it. Thanks!
Configuration menu - View commit details
-
Copy full SHA for 54a180f - Browse repository at this point
Copy the full SHA 54a180fView commit details -
[css-anchor-position] Parsing and computing position-try-options
Part of the new auto-fallback proposal. Bug: 40279608 Change-Id: If43e8af13a805cbd1b60cd8f44272ac431e4606c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272497 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257845}
Configuration menu - View commit details
-
Copy full SHA for 929d133 - Browse repository at this point
Copy the full SHA 929d133View commit details -
Establish display item fragment scope for atomic inlines.
We already did this when painting text items and inline box items (non-atomic inlines), but we also need to do it when painting atomic inlines. Although it's rather unusual for an atomic inline LayoutObject to be associated with multiple fragment items, it may happen if an atomic inline is associated with a text-overflow ellipsis (that's a fragment item of type kGeneratedText). A text-overflow ellipsis fragment item is associated with the last LayoutObject that fits before the ellipsis, and if this happens to be an atomic inline (e.g. an image), it will be that one. To explain what went wrong in the test included: There's a SPAN with two lines inside. Two fragment items are created for the SPAN. The item on the first line gets fragment ID 0, and the one one the second line gets ID 1. On the second line there's an image followed by something that gets clipped by overflow, and there will be a text-overflow ellipsis. The image is the last (and only, actually) object that fits, so the ellipsis gets associated with that object. Two fragment items are created for the image object, first the image itself, and then the ellipsis. They get a fragment ID of 0 and 1, respectively. When painting the SPAN on the second line, we establish a fragment item scope for it, and the ID is 1. When we paint the actual image, we didn't establish a scope, so that ID 1 was used for the image as well (even though its fragment ID is 0). When painting the ellipsis afterwards, we establish a scope, with ID 1. Because of this we got the same display item client (from the layout object) painted twice with the same fragment ID. Bug: 41493875 Change-Id: I5fc87fc086ecd3c4367dca7c3ad94c22c031f7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272607 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257896}
Configuration menu - View commit details
-
Copy full SHA for a79f9cb - Browse repository at this point
Copy the full SHA a79f9cbView commit details -
Implement view-transition-class selector matching
Selector checker now matches classes from selector to classes from pseudo-element. The classes aren't saved on the pseudo-element, but rather in the ViewTransitionStyleTracker, in the element map. Bug: 1519997 Change-Id: Iee74bb5d8e6f1ced0edfbcdc1ac9eec32497e97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5253451 Reviewed-by: Vladimir Levin <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Camille Lamy <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257975}
Configuration menu - View commit details
-
Copy full SHA for 50cdae7 - Browse repository at this point
Copy the full SHA 50cdae7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11f539a - Browse repository at this point
Copy the full SHA 11f539aView commit details -
sensors: Make virtual sensors always remember and report the latest r…
…eading This concerns a discussion that started in https://crrev.com/c/5249795: the idea is to make a virtual sensor leak fewer implementation details, such as the fact that the current reading is lost when the sensor is deactivated. This should not be observable from e.g. a web test, as there is nothing mandating that this happen in the first place. From an API user's perspective, once a reading is added to a virtual sensor (including if this happens before a Sensor instance is created in Chromium) it remains present until it is replaced by another one, even if the sensor is stopped and reactivated. This is complemented by the behavior added in https://crrev.com/c/5245506, in which any pending reading (or, with this CL, the latest reading) is stashed until it can be published. In other words, a VirtualPlatformSensor now respects the following two invariants: 1. Once a reading is set, it will remain set until it is replaced with another reading. 2. Said reading will be added to the shared buffer and clients will be notified whenever the sensor is activated. While here, revert the part of https://crrev.com/c/5245506 that renamed PlatformSensor::IsActiveForTesting() to is_active(), as this is no longer needed. Bug: 1520919, 1506995 Change-Id: I205432cbf196376f67a6bc1c84d69302ffe739ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272509 Commit-Queue: Reilly Grant <[email protected]> Auto-Submit: Raphael Kubo Da Costa <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258046}
Configuration menu - View commit details
-
Copy full SHA for effd91d - Browse repository at this point
Copy the full SHA effd91dView commit details -
VT: Handle document shutdown gracefully.
This patch does two things: - After dom callback is finished, ensures that we have a view before continuing. We skip the transition otherwise. - When document is shutting down, skip any transition that is outstanding. This is due to the fact that the execution context (dom window) can notify of its destruction after document is destroyed. However, the transition is owned by the document (via supplement), so it can be destroyed before this notification and cause CHECKs due to invalid state in the style tracker dtor. [email protected] Fixed: 324109585 Change-Id: I64eaa886f89c89762cd3d5d8b5ad3b0fa4a1a4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273560 Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258056}
Configuration menu - View commit details
-
Copy full SHA for bd77098 - Browse repository at this point
Copy the full SHA bd77098View commit details -
[Grid] Fix resolution of alignment properties for subgridded items
There was an issue with the `align-*` and `justify-*` properties and subgridded items where, if its parent subgrid was orthogonal to the root grid that considered such item for sizing, then the alignment properties were incorrectly resolved relative to the root grid's writing mode. Fixing this behavior making sure that we always resolve the alignment properties of a grid item relative to its parent grid's writing mode. Adding test coverage to the WPT suite for this issue. Bug: 1521978 Change-Id: I7d929ff1589632964e38100b5ba44a484df954b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260028 Commit-Queue: Ethan Jimenez <[email protected]> Reviewed-by: Alison Maher <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258172}
Configuration menu - View commit details
-
Copy full SHA for cc83935 - Browse repository at this point
Copy the full SHA cc83935View commit details
Commits on Feb 9, 2024
-
Implement :open and :closed pseudo classes
These are in the CSS spec here: https://drafts.csswg.org/selectors-4/#open-state I am going to try to get this specced in the HTML spec as well. https://chromestatus.com/feature/5085419215781888 https://groups.google.com/a/chromium.org/g/blink-dev/c/jESpcXVA8ns Bug: 324293874 Change-Id: I6e056f9eb899507693fd686c2cf65f8334c75153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5278021 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258221}
Configuration menu - View commit details
-
Copy full SHA for 495dfa9 - Browse repository at this point
Copy the full SHA 495dfa9View commit details -
Add tests for CSS calc-size() function.
Change-Id: I7ced1651bc3b4fd5a863a3c4388f035de632cd0b Bug: 313072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5249791 Commit-Queue: David Baron <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258292}
Configuration menu - View commit details
-
Copy full SHA for f628754 - Browse repository at this point
Copy the full SHA f628754View commit details -
Add tests for animation of CSS calc-size().
Bug: 313072 Change-Id: Iffb1d69673a24a5e13e6a88606e5f9f4b0215de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5254963 Reviewed-by: Daniil Sakhapov <[email protected]> Commit-Queue: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258293}
Configuration menu - View commit details
-
Copy full SHA for da25e93 - Browse repository at this point
Copy the full SHA da25e93View commit details -
[css-anchor-position] Add interpolation tests for all properties
Bug: 40059176 Change-Id: I9d6a398c57086b9437c43f841f050751cc06675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273510 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Auto-Submit: Rune Lillesveen <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258367}
Configuration menu - View commit details
-
Copy full SHA for b9c905d - Browse repository at this point
Copy the full SHA b9c905dView commit details -
[wdspec] Add test for early fetchError events
Depends on D200873 Differential Revision: https://phabricator.services.mozilla.com/D200888 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1877438 gecko-commit: bd25bd316fa4296decfd3e4de387d9aab015727e gecko-reviewers: webdriver-reviewers, whimboo
Configuration menu - View commit details
-
Copy full SHA for 1837411 - Browse repository at this point
Copy the full SHA 1837411View commit details -
Part 4: Implement generic role mapping
This revision 'implements' the 'generic' ARIA role mapping by mapping ARIA 'generic' to Gecko 'section.' This isn't a full implementation of 'generic' - it sidesteps it to avoid dealing with larger 'generic' issues (namely: that there are multiple roles that are 'generic' in Gecko currently). We'll sort that out in a later commit. This revision adds a new web platform test to verify that the generic role actually overrides an element's implicit role. Differential Revision: https://phabricator.services.mozilla.com/D200133 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1732306 gecko-commit: 55bbf06eb769d45491e170404daa7c55e95c3a0f gecko-reviewers: Jamie
Configuration menu - View commit details
-
Copy full SHA for 6878a09 - Browse repository at this point
Copy the full SHA 6878a09View commit details -
Make Element.{client,scroll} APIs zoom aware.
Also extend scroll-zoom to cover scroll{Top,Left,To,By}, since that was completely untested. Differential Revision: https://phabricator.services.mozilla.com/D200029 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874488 gecko-commit: fbf03aba7e9d0a13cade58cbe7a1fe06bf53d94c gecko-reviewers: saschanaz, TYLin
Configuration menu - View commit details
-
Copy full SHA for 15110b0 - Browse repository at this point
Copy the full SHA 15110b0View commit details -
Slightly adjust threshold in oscillator and compressor test in WPT fo…
…r new FFT code. The compressor test makes use of a sawtooth wave and was already failing -- this is simply adjusting the expected error. Differential Revision: https://phabricator.services.mozilla.com/D200829 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1877221 gecko-commit: 087f8190230da1f9cf1f82ca3b6474e44c552039 gecko-reviewers: pehrsons
Configuration menu - View commit details
-
Copy full SHA for e164c49 - Browse repository at this point
Copy the full SHA e164c49View commit details -
Fix focus gets incorrectly cleared by PresShell::FixUpFocus if the fo…
…cus is on area element Differential Revision: https://phabricator.services.mozilla.com/D200950 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878753 gecko-commit: 689c94c4147143275eaf2f8df5bd4fd179a717c9 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for a757293 - Browse repository at this point
Copy the full SHA a757293View commit details -
Configuration menu - View commit details
-
Copy full SHA for 913ef86 - Browse repository at this point
Copy the full SHA 913ef86View commit details -
[css-nesting] Don't emit invisible rules inside @page
The parsing code for @page leans on the code from CSS Nesting, which recently gained special behavior for trailing declarations (crbug.com/1517290). This special behavior affects how an inner rule relates to its outer style rule (/selector), which is not relevant for @page. Bug: 1517290 Change-Id: I755f8b2675f8e5c988c8ea5afdf03c84b779da83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272554 Commit-Queue: Morten Stenshorne <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258458}
Configuration menu - View commit details
-
Copy full SHA for 5480e40 - Browse repository at this point
Copy the full SHA 5480e40View commit details -
Fixed: 40650780 Change-Id: I8316cca518b760c0cc4edae9203451940d549977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5277388 Auto-Submit: Fredrik Söderquist <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258460}
Configuration menu - View commit details
-
Copy full SHA for 43a23d0 - Browse repository at this point
Copy the full SHA 43a23d0View commit details -
Remove unnecessary header for fetch requests
After the change in WICG/attribution-reporting-api#757, the fetch request is now a simple CORS request. Change-Id: If69ae7d225e527da17424eeca5d668bdcb7224a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5278573 Reviewed-by: Andrew Paseltiner <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258570}
Configuration menu - View commit details
-
Copy full SHA for 34995a6 - Browse repository at this point
Copy the full SHA 34995a6View commit details -
A non-invertible gradient/patternTransform make the paintserver invalid
The gradient/patternTransform properties follow the rules of the CSS transforms spec: "If a transform function causes the current transformation matrix of an object to be non-invertible, the object and its content do not get displayed." [1] Check if the relevant transform is non-invertible and flag the paintserver as invalid if it is. [1] https://drafts.csswg.org/css-transforms/#transform-function-lists Fixed: 40742883 Change-Id: I53c65ff1d21f04e740aa0941ffc09aa6a465149d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272857 Auto-Submit: Fredrik Söderquist <[email protected]> Reviewed-by: Stephen Chenney <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258613}
Configuration menu - View commit details
-
Copy full SHA for 7567b52 - Browse repository at this point
Copy the full SHA 7567b52View commit details -
Don't reset the subpath start on 'close' commands
Only 'moveto' commands should (re)set the current subpath start position. Resetting on 'close' will clobber state for 'implicit' subpaths. Bug: 40821435 Change-Id: Iea4863a154808eaee999dce5df30ea5cdf5d5a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279439 Auto-Submit: Fredrik Söderquist <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Reviewed-by: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258628}
Configuration menu - View commit details
-
Copy full SHA for 703bd88 - Browse repository at this point
Copy the full SHA 703bd88View commit details -
Close the dialog element when the open attribute is removed
This patch adds HTMLDialogElement::ParseAttribute which runs HTMLDialogElement::close when the open attribute is removed to prevent a bad state where the dialog is modal but hidden and inerting the rest of the document. Spec discussion is happening here: whatwg/html#5802 Change-Id: Ib90736ced952d7aeadc791c6863c3ac2a55deb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5269905 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258629}
Configuration menu - View commit details
-
Copy full SHA for c0538d5 - Browse repository at this point
Copy the full SHA c0538d5View commit details -
[HitTestTransparency] Experimental status
The feature uses cc::HitTestOpacity::kTransparent for pointer-events: none. The flag is first marked on paint chunks, then PendingLayer and cc::Layer, by merging cc::HitTestOpacity from merged painted results. The merge algorithm (which is already ready for HitTestOpaqueness) can handle cases such as pointer-events:none with pointer-events:auto descendants (which will be merged into cc::HitTestOpaqueness::kMixed). cc::Layer::HitTestable() is now based on this flag for blink. For test coverage, this CL also includes changes to make existing tests pass or fix existing bugs with the feature: - LayerTreeHostImpl::BuildHitTestData() now handles a SurfaceLayer with pointer-events:none even if it doesn't draw contents, to make CrossSiteSubframe/DragAndDropBrowserTest.CrossTabDrag/* pass. - Correct hit test transparency for scrolling contents. - Correct hit test transparency for frames under pointer-events:none container (b/323688987). - Correct hit test transparency for scrollbar layers in boxes with pointer-events:none (b/324092420). - New tests. ClusterTelemetry job shows that it can reduce main thread scrolling (hit test or repaint) by 36% (kFailedHitTest by 40%, kNonFastScrollableRegion by 67%) compared to HitTestOpaqueness only. Bug: 40062957, 323688987, 324092420 Change-Id: I224c8e5f047ec27bf4c8957ae59643457cc9252e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263065 Commit-Queue: Xianzhu Wang <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258651}
Configuration menu - View commit details
-
Copy full SHA for 742faa6 - Browse repository at this point
Copy the full SHA 742faa6View commit details -
Request::Contructor init body now takes precendence over input body.
Differential Revision: https://phabricator.services.mozilla.com/D200498 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1860293 gecko-commit: effe0ba31234da3a67826fd07071eb67e1ca1d4d gecko-reviewers: valentin
Configuration menu - View commit details
-
Copy full SHA for a0952fc - Browse repository at this point
Copy the full SHA a0952fcView commit details -
FLEDGE: field trial testing config for 20->40 in component ads limit
Fix the bug this revealed, and update test expectations to notice the corresponding feature detection browser signals showing up. Also add a new WPT test for new limit, since I was in the neighborhood anyway. Bug: 324445653 Change-Id: Ib1f3d23f0ea2657c8e27cab67caddff1208825e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5280539 Reviewed-by: Russ Hamilton <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258749}
Configuration menu - View commit details
-
Copy full SHA for f11c5f5 - Browse repository at this point
Copy the full SHA f11c5f5View commit details
Commits on Feb 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dac72e8 - Browse repository at this point
Copy the full SHA dac72e8View commit details -
Convert existing orientation-event web tests to test_driver
The purpose of this change is to stop using the JS mocks-based implementation and start using WebDriver and virtual sensors for interoperability. WebDriver commands for Generic Sensor are defined in https://www.w3.org/TR/generic-sensor/#automation, and the Device Orientation-specific parts are defined in https://www.w3.org/TR/orientation-event/#automation. The TestHelper class was created to simplify tests. It takes care of creating and removing the backing virtual sensors for each event type, and handling permissions. It also contains some previously free functions that now depend on virtual sensors (such as setData()). More generic functions which do not need information saved in TestHelper remain untouched in the same orientation-event-helpers.js file. Care has been taken to avoid changing the values and the order of the calls in the tests as much as possible. Notes about some cases where it was not possible: 1. Currently it is not possible to set individual values to null because the parsing algorithms used by https://w3c.github.io/sensors/#update-virtual-sensor-reading-command always expect numbers. This affected null-values.https.html test. 2. "deviceorientation" and "deviceorientationabsolute" events whose readings don't differ from the previous one by a certain amount are ignored per spec (https://www.w3.org/TR/orientation-event/#significant-change-in-orientation). Because of this requirement second test values needed to be changed in add-listener-from-callback.https.html test for Device Orientation. 3. motion/add-listener-from-callback.https.html: The second listener is added before the first one is removed to avoid needlessly stopping the sensor. Bug: 1520919 Change-Id: I7890f08357481fd62a71338b20950b534abbbe8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5249795 Commit-Queue: Raphael Kubo Da Costa <[email protected]> Auto-Submit: Juha J Vainio <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Reviewed-by: Raphael Kubo Da Costa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258822}
Configuration menu - View commit details
-
Copy full SHA for ded3ea7 - Browse repository at this point
Copy the full SHA ded3ea7View commit details -
[wptrunner] Use the correct ProfileCreator class in FirefoxAndroidWdS…
…pecBrowser. Differential Revision: https://phabricator.services.mozilla.com/D201212 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879483 gecko-commit: 20876ae07c4b760464125773aa45200a98f34159 gecko-reviewers: jgraham
Configuration menu - View commit details
-
Copy full SHA for 86c2abe - Browse repository at this point
Copy the full SHA 86c2abeView commit details -
Make
PresShell::EventHandler::DispatchPrecedingPointerEvent
update ……event target after dispatching a pointer event The reason of the bug is, no `mouseup` event is fired after the `pointerup` event listener removed the target. Therefore, `nsIFrame::HandleRelease()` does not run and nobody cleans up the drag state of the `nsFrameSelection`. This is caused by that `PresShell::EventHandler::DispatchPrecedingPointerEvent()` updates only event target frame of the following mouse event target if the pointer event target was removed from the tree, however, the frame may not be ready. In this case, `PresShell::GetCurrentContent()` will clear both current event target content and frame because its composed document (`nullptr`) never matches with the document for the `PresShell`. Therefore, it needs to update the target too. This patch makes all developers won't create similar bugs, this encapsulate `EventTargetData::mContent` and `EventTargetData::mFrame` to make their setters clean up or automatically check the relation. Differential Revision: https://phabricator.services.mozilla.com/D201053 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1877815 gecko-commit: 88c50740c90849f41b36a3ebdea5c1182d010b62 gecko-reviewers: smaug
Configuration menu - View commit details
-
Copy full SHA for afdbabf - Browse repository at this point
Copy the full SHA afdbabfView commit details -
Change the behavior of clonable to be more opt-in
See the discussion here: whatwg/html#10107 (comment) The existing *shipped* behavior (i.e. before the `clonable` concept was introduced) was that any declarative shadow root *within a `<template>`* would be automatically cloned, but no others. The semi-new behavior is the `clonable` bit concept, in which all declarative shadow roots have their `clonable` bit set to true, so they automatically get cloned by `cloneNode()`. That's regardless of whether they are inside or outside a template. The new consensus is that the "semi-new" clonable behavior is likely web-incompatible, because clones will just start getting shadow roots included. Plus it wasn't very developer-desirable. The new consensus is therefore to add a `shadowrootclonable` attribute for declarative shadow dom that allows a shadow root to opt-in to this behavior, but the default for all shadow roots will be `clonable=false`. This CL implements the new consensus behind the ShadowRootClonable flag. If the flag is false, the "shipped" behavior will be emulated via setting `clonable` in an equivalent way. See these three spec PRs: whatwg/dom#1246 whatwg/html#10069 whatwg/html#10117 Bug: 1510466 Change-Id: Ice7c7579094eb08b882c4bb44f93045f23b8f222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260748 Reviewed-by: David Baron <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258910}
Configuration menu - View commit details
-
Copy full SHA for 33d11f1 - Browse repository at this point
Copy the full SHA 33d11f1View commit details
Commits on Feb 12, 2024
-
Revert "FLEDGE: field trial testing config for 20->40 in component ad…
…s limit" This reverts commit c825fae53cdfa08b33e560c15bb7020e0646a451. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5753898272817152 Sample build with failed test: https://ci.chromium.org/b/8756530589944850161 Affected test(s): [ninja://content/test:content_browsertests/InterestGroupBrowserTest.ComponentAuctionValidateWorkletParametersOldRunAdAuctionNames](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FInterestGroupBrowserTest.ComponentAuctionValidateWorkletParametersOldRunAdAuctionNames?q=VHash%3A480dfd54bffe054f) [ninja://content/test:content_browsertests/InterestGroupComponentWorkletValidationBrowserTest.ComponentAuctionValidateWorkletParameters/All.top_level_subresource_bundle_direct_from_seller_signals_component_subresource_bundle_direct_from_seller_signals](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FInterestGroupComponentWorkletValidationBrowserTest.ComponentAuctionValidateWorkletParameters%2FAll.top_level_subresource_bundle_direct_from_seller_signals_component_subresource_bundle_direct_from_seller_signals?q=VHash%3A480dfd54bffe054f) [ninja://content/test:content_browsertests/InterestGroupWorkletValidationBrowserTest.ValidateWorkletParameters/All.subresource_bundle_direct_from_seller_signals](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FInterestGroupWorkletValidationBrowserTest.ValidateWorkletParameters%2FAll.subresource_bundle_direct_from_seller_signals?q=VHash%3A480dfd54bffe054f) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5753898272817152&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5280539&type=BUG Original change's description: > FLEDGE: field trial testing config for 20->40 in component ads limit > > Fix the bug this revealed, and update test expectations to notice the corresponding feature detection browser signals showing up. Also add a new WPT test for new limit, since I was in the neighborhood anyway. > > Bug: 324445653 > > Change-Id: Ib1f3d23f0ea2657c8e27cab67caddff1208825e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5280539 > Reviewed-by: Russ Hamilton <[email protected]> > Commit-Queue: Maks Orlovich <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1258749} > Bug: 324445653 Change-Id: I60ed84e1607b879446e09b53e824368a3a4cd209 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282851 Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Tim Sergeant <[email protected]> Commit-Queue: Tim Sergeant <[email protected]> Cr-Commit-Position: refs/heads/main@{#1258985}
Configuration menu - View commit details
-
Copy full SHA for 0021ba6 - Browse repository at this point
Copy the full SHA 0021ba6View commit details -
[marionette] Implicitly accept "beforeunload" prompts in Marionette.
Differential Revision: https://phabricator.services.mozilla.com/D198681 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1693857 gecko-commit: d01d1d933b227b26fd4911912e57a1e069034386 gecko-reviewers: webdriver-reviewers, jdescottes
Configuration menu - View commit details
-
Copy full SHA for 3a3083b - Browse repository at this point
Copy the full SHA 3a3083bView commit details -
webrtc wpt: update RTCRtpParameters-codec.html to use receive-side se…
…tCodecPreferences BUG=webrtc:15396 Change-Id: Ia188bd98ee1a274d1435be73198c0ba9b11b42da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279737 Reviewed-by: Florent Castelli <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259088}
Configuration menu - View commit details
-
Copy full SHA for eeb00b0 - Browse repository at this point
Copy the full SHA eeb00b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dd70a3 - Browse repository at this point
Copy the full SHA 2dd70a3View commit details -
[anchor] Remove anchor(auto), anchor(auto-same)
These no longer exist in the spec, and the new approach requires a totally different solution. Bug: 40279608 Change-Id: Ic852f4c1798123fe484f1e25bd42a12edaa41581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5274757 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259107}
Configuration menu - View commit details
-
Copy full SHA for ddef01b - Browse repository at this point
Copy the full SHA ddef01bView commit details -
Add support for math expressions for offset-rotate interpolation
Bug: 41494232 Change-Id: I53ec9c2f776bb14cb34f780096db74c952c86e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273518 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259117}
Configuration menu - View commit details
-
Copy full SHA for 60df2d2 - Browse repository at this point
Copy the full SHA 60df2d2View commit details -
Add support for math expressions in custom properties angle interpola…
…tion Bug: 41494232 Change-Id: Ie62dca9adfce81b8b708a59bbd33ff1f1b8ea27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5285454 Commit-Queue: Daniil Sakhapov <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259139}
Configuration menu - View commit details
-
Copy full SHA for 1c79b1b - Browse repository at this point
Copy the full SHA 1c79b1bView commit details -
Add basic @page (CSSPageRule) CSSOM test.
Looks like there was no test coverage for this. Bug: 324827379 Change-Id: Ief6d58a5a07006830a85a7ecec46a8de3df21a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282210 Auto-Submit: Morten Stenshorne <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259146}
Configuration menu - View commit details
-
Copy full SHA for 385dc41 - Browse repository at this point
Copy the full SHA 385dc41View commit details -
[multicol] Allow stretch sizes to resolve for column balancing.
Previously we'd only try and resolve the main length when it wasn't auto. We should allow it to resolve if its trying to stretch. Fixed: 324314465 Change-Id: I148a3e4350ed2363f0aa81af398b9ef5f57f0987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282425 Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259211}
Configuration menu - View commit details
-
Copy full SHA for 5a5b804 - Browse repository at this point
Copy the full SHA 5a5b804View commit details -
Reland "FLEDGE: field trial testing config for 20->40 in component ad…
…s limit" This reverts commit 2650556d1e0977967c84733a5c252b09b0f0157d. Changes for reland: Include Fuchsia in field trial config, and force on the flags in browser tests by hand as well Original change's description: > Revert "FLEDGE: field trial testing config for 20->40 in component ads limit" > > This reverts commit c825fae53cdfa08b33e560c15bb7020e0646a451. > > Reason for revert: > LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5753898272817152 > > Original change's description: > > FLEDGE: field trial testing config for 20->40 in component ads limit > > > > Fix the bug this revealed, and update test expectations to notice the corresponding feature detection browser signals showing up. Also add a new WPT test for new limit, since I was in the neighborhood anyway. > > > > Bug: 324445653 > > > > Change-Id: Ib1f3d23f0ea2657c8e27cab67caddff1208825e1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5280539 > > Reviewed-by: Russ Hamilton <[email protected]> > > Commit-Queue: Maks Orlovich <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1258749} > > > > Bug: 324445653 > Change-Id: I60ed84e1607b879446e09b53e824368a3a4cd209 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282851 > Bot-Commit: Rubber Stamper <[email protected]> > Owners-Override: Tim Sergeant <[email protected]> > Commit-Queue: Tim Sergeant <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1258985} Bug: 324445653, 324647198 Change-Id: I29ebdb03208aeccbb04320543f82679a56087250 Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast-receiver-rel,android-official,linux-official Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5285075 Reviewed-by: Russ Hamilton <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259286}
Configuration menu - View commit details
-
Copy full SHA for 9bba46c - Browse repository at this point
Copy the full SHA 9bba46cView commit details -
[Async Clipboard] Use
supports
instead ofIsValidType
.Remove `ClipboardWriter::IsValidType` that is redundant. Bug: 1483026 Change-Id: I1f93d2e75b0126b8a212103776fd083da4ff9ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5278640 Commit-Queue: Anupam Snigdha <[email protected]> Reviewed-by: Evan Stade <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259306}
Configuration menu - View commit details
-
Copy full SHA for 5ed2220 - Browse repository at this point
Copy the full SHA 5ed2220View commit details -
Document render-blocking: use classic scripts to generate parser delay
This would be more interoperable as janking the main thread would not necessarily force rendering. Bug: 324452579 Change-Id: I2e82535a45ca12063c680278781395d6068b4e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272558 Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259300}
Configuration menu - View commit details
-
Copy full SHA for bec578b - Browse repository at this point
Copy the full SHA bec578bView commit details -
Add CSS display-mode experimental support for picture-in-picture
This CL adds experimental support to the CSS display-mode media feature for picture-in-picture. Spec PR: w3c/csswg-drafts#9920 Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/OE1rXYv126c Demo: https://document-picture-in-picture-api.glitch.me/display-mode.html Bug: 41493667 Change-Id: I16d0b7c62ed09220e4bbacdfa86191331f872d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272485 Reviewed-by: Ted Choc <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259357}
Configuration menu - View commit details
-
Copy full SHA for dea3f53 - Browse repository at this point
Copy the full SHA dea3f53View commit details -
Event Timing - Handle modal dialog interference
* Previous undesired outcome: event timing could measure the arbitrarily long user input waiting time on synchronous javascript modal dialogs and report it as part of the presentation delay. * Root cause: synchronous modal dialogs paused the event-damaged frame to be presented until after user close the dialog. * This CL address it by: treating modal dialogs showing as another way of page responding and report the dialog showing timestamp as an alternative end time for duration measurement to any events that was interfered by the modal dialog in event timing. Bug: 1435448 Change-Id: I8f48c0292e45b01ea51ac5134096a08f584fdcfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258894 Commit-Queue: Aoyuan Zuo <[email protected]> Reviewed-by: Michal Mocny <[email protected]> Reviewed-by: Dmitry Gozman <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259367}
Configuration menu - View commit details
-
Copy full SHA for f84ab88 - Browse repository at this point
Copy the full SHA f84ab88View commit details -
Add 'writingsuggestions' attribute
This CL implements the new 'writingsuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) web-platform-tests#43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5247315 Reviewed-by: Dan Clark <[email protected]> Commit-Queue: Stephanie Zhang <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259389}
Configuration menu - View commit details
-
Copy full SHA for dbbfe1b - Browse repository at this point
Copy the full SHA dbbfe1bView commit details -
Make
Shift
+ right click should work as a right click without `Shif……t` if contextmenu should forcibly be open We have a pref, `dom.event.contextmenu.shift_suppresses_event`, which is default to make `Shift` + right click forcibly open the context menu without dispatching `contextmenu` event to the web. When user wants to use this feature, they may (or must) assume that it works as a right click (without `Shift`) except whether it overrides `contextmenu` event listener of the web app. Therefore, `Selection` should be collapsed at the click point instead of expanding to the click point. Unfortunately, we need to consider it at `mousedown`, not `mouseup` nor `contextmenu`. Therefore, `Shift` state may mismatch with the actual state at `mouseup` and `mousedown`/`poinerdown` listeners of web apps may assume it will expand selection, but I think that we cannot solve these issues. Differential Revision: https://phabricator.services.mozilla.com/D201054 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878273 gecko-commit: 043841d38933af6bd8f9cf9e3953f5dfbf96af53 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 24531eb - Browse repository at this point
Copy the full SHA 24531ebView commit details -
Make sure we hold a reference to the pc in these tests.
Differential Revision: https://phabricator.services.mozilla.com/D201243 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1838413 gecko-commit: 7c4a0321d30adfc6bad65e11ceecb1d8fd96b1d3 gecko-reviewers: pehrsons
Configuration menu - View commit details
-
Copy full SHA for 36f966f - Browse repository at this point
Copy the full SHA 36f966fView commit details -
Wait for RTP before checking for RTP stats.
Differential Revision: https://phabricator.services.mozilla.com/D201301 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879422 gecko-commit: 0a91191d564e9987479c4a719771ab5611c8ba87 gecko-reviewers: ng
Configuration menu - View commit details
-
Copy full SHA for 3fcdae2 - Browse repository at this point
Copy the full SHA 3fcdae2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b71b8c1 - Browse repository at this point
Copy the full SHA b71b8c1View commit details
Commits on Feb 13, 2024
-
[shared storage] Introduce WorkletOptions param
Introduce WorkletOptions param for both addModule() and createWorklet(). For the resource request, use the provided credentials and use the SiteForCookies derived from the RFHI. This aligns with the worklet standard [1], and aligns with the implementation for other workers (e.g. for dedicated workers [2]). Note that the new param for addModule() isn't gated by kSharedStorageAPIM123. This is intentional: we have been deviating from the worklet standard, so we consider this change as a bugfix. [1] https://html.spec.whatwg.org/multipage/worklets.html#dom-worklet-addmodule [2] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/worker_host/dedicated_worker_host.cc?q=WorkerScriptFetcher::CreateAndStart Bug: 1218540 Change-Id: I82bb7f7509e904f1d9e2ff26c9c8eb1b90ad5828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273828 Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Reviewed-by: Cammie Smith Barnes <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259477}
Configuration menu - View commit details
-
Copy full SHA for f02fb3c - Browse repository at this point
Copy the full SHA f02fb3cView commit details -
VT: Add class list as a specificity consideration for view transitions.
[email protected], [email protected] Change-Id: I7fdf8c5b215830c43de2f31e8717c1290d452f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287237 Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259482}
Configuration menu - View commit details
-
Copy full SHA for 623aa54 - Browse repository at this point
Copy the full SHA 623aa54View commit details -
Fenced frames: Disable _unfencedTop navigations after network revocation
Navigations into and out of fenced frames need to be treated specially for network revocation, because they don't have the revoked partition nonce attached. A previous CL disabled embedder-initiated fenced frame root navigations, this CL disables _unfencedTop navigations, and the next CL will disable popup navigations. Bug: 1515599 Change-Id: I7d0397866ec5989fa2c9eb6a9c5bdb72ba1aa0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5254680 Commit-Queue: Garrett Tanzer <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259517}
Configuration menu - View commit details
-
Copy full SHA for d711085 - Browse repository at this point
Copy the full SHA d711085View commit details -
Fix typo in MediaRecorder-mimetype.html
R=tguilbert Bug: b/40257965 Change-Id: I3534a473cf8e70198415a9bfba6fb0ab18648aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5288814 Auto-Submit: Dale Curtis <[email protected]> Commit-Queue: Dale Curtis <[email protected]> Commit-Queue: Thomas Guilbert <[email protected]> Reviewed-by: Thomas Guilbert <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259529}
Configuration menu - View commit details
-
Copy full SHA for 1c27601 - Browse repository at this point
Copy the full SHA 1c27601View commit details -
Add iframes lazy load scroll margin wpt tests
Spec: https://html.spec.whatwg.org/#lazy-load-root-margin Bug: 40943726 Change-Id: I9c9a359c8b6d3084604ff00a9a51dab2192ef1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287882 Commit-Queue: Yotam Hacohen <[email protected]> Reviewed-by: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259536}
Configuration menu - View commit details
-
Copy full SHA for 855f066 - Browse repository at this point
Copy the full SHA 855f066View commit details -
Configuration menu - View commit details
-
Copy full SHA for 684fdf7 - Browse repository at this point
Copy the full SHA 684fdf7View commit details -
Clean up CompareTreePosition and related code.
Make TreeOrderedArray support what the form controls stuff needs, and use it instead of custom nsContentUtils stuff. Differential Revision: https://phabricator.services.mozilla.com/D201261 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879579 gecko-commit: 37ec3180a6cbce3bb2544f9a16b4ded4657c6eb6 gecko-reviewers: smaug
Configuration menu - View commit details
-
Copy full SHA for cfd5b3c - Browse repository at this point
Copy the full SHA cfd5b3cView commit details -
Part 2 - Add
:has
to revalidation selector.Differential Revision: https://phabricator.services.mozilla.com/D200223 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876962 gecko-commit: 9032a37ea0092f910770b87693cb02173dcd24db gecko-reviewers: firefox-style-system-reviewers, emilio
Configuration menu - View commit details
-
Copy full SHA for a7f0a17 - Browse repository at this point
Copy the full SHA a7f0a17View commit details -
Add @page (CSSPageRule) CSSOM test for adding / removing properties.
Bug: 324827379 Change-Id: Ia45600a4290ad8bba14ffd1a52074c695d684c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5288554 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Auto-Submit: Morten Stenshorne <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259701}
Configuration menu - View commit details
-
Copy full SHA for f127a46 - Browse repository at this point
Copy the full SHA f127a46View commit details -
Do feature detection in @starting-style tests
Some sub-tests were unexpectedly passing in browsers not supporting the feature at all. Change-Id: Ife024fd170f7fe1aedb7f30005daeabc10d22ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5286334 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259699}
Configuration menu - View commit details
-
Copy full SHA for a900d16 - Browse repository at this point
Copy the full SHA a900d16View commit details -
Add support for math expressions for border-image-width interpolation
Bug: 41494232 Change-Id: I720a25b58c21149aab5514a87295da2b44feb241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5285675 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259715}
Configuration menu - View commit details
-
Copy full SHA for 279a195 - Browse repository at this point
Copy the full SHA 279a195View commit details -
Add support for math expressions for font-stretch interpolation
Also this CL adds ComputePercentage as font-stretch can be represented as a percentage number. Bug: 41494232 Change-Id: Idd940e99844104fdc632c57c2e86749dde9d13bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5285679 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259743}
Configuration menu - View commit details
-
Copy full SHA for 6b359c7 - Browse repository at this point
Copy the full SHA 6b359c7View commit details -
Add support for math expressions for font-size-adjust interpolation
Bug: 41494232 Change-Id: I1f0daa17a9f47db7bf1aec34e2f990c928a12801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5286214 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259795}
Configuration menu - View commit details
-
Copy full SHA for 8fa356c - Browse repository at this point
Copy the full SHA 8fa356cView commit details -
[wdspec] Fix escaping in test_shadow_root_slot[default hidden].
Differential Revision: https://phabricator.services.mozilla.com/D201582 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1865381 gecko-commit: 93a90f93c76530afb4c94c199f6632daecaf5e68 gecko-reviewers: webdriver-reviewers, jdescottes
Configuration menu - View commit details
-
Copy full SHA for da43d32 - Browse repository at this point
Copy the full SHA da43d32View commit details -
Add fuzzy metadata to wpt/svg/painting/reftests/marker-path-001.svg
This test passes in the WPT runner and has some very minor differences in just over a handful of pixels. Fixed: 40676856 Change-Id: Ibdeceb81b5244bf38127d93ce662fef6403e32fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5285439 Reviewed-by: Stephen Chenney <[email protected]> Auto-Submit: Fredrik Söderquist <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259815}
Configuration menu - View commit details
-
Copy full SHA for 2380ac0 - Browse repository at this point
Copy the full SHA 2380ac0View commit details -
Field trial testing config for sampling debug reports.
Enable FledgeSampleDebugReports in field trial config. Add a WPT to test browserSignals.forDebuggingOnlyInCooldownOrLockout is set to true in generatedBid() and scoreAd() after an earlier auction made them under lockout or cooldown. Bug: b/310944302 Change-Id: Ibb8129d1c61acfbda6fb2967404de89612c20c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5285079 Reviewed-by: Russ Hamilton <[email protected]> Commit-Queue: Qingxin Wu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259861}
Configuration menu - View commit details
-
Copy full SHA for 4ee1931 - Browse repository at this point
Copy the full SHA 4ee1931View commit details -
[SAA] Implementing SharedWorker support (Part 3: Implement same-site …
…cookie filtering) TL;DR: This is a large CL, see an outline of key points under the intro. Introduction: The Storage Access API provides access to unpartitioned cookies in third-party contexts. This CL is part of a series to extend that access to SharedWorkers. Before we actually provide access to SharedWorkers, we need a way for the renderer to limit the scope of SameSite cookies provided to the worker. Normally, a worker with a first-party storage key could access all cookies, but if access is via the SAA handle we want to limit that access to just SameSite: None cookies. This CL is part of a series to allow that limiting ability. It implements the filter that prevents the inclusion of SameSite=Strict/Lax cookies in a first-party shared worker when 'sameSiteCookies': 'none' is set. Note: The ability to request 'all' in a third-party context is not added here nor will it be added. Outline: (1) require_cross_site_request_for_cookies is calculated by checking if the storage key is third-party or the sameSiteCookies option is none. (2) This is calculated in three spots: (2a) content/browser/devtools/shared_worker_devtools_agent_host.cc (2b) content/browser/worker_host/shared_worker_host.cc (2c) content/browser/worker_host/shared_worker_service_impl.cc (3) Most of the CL is propagating this boolean value down to the four key spots it's used: (3a) services/network/cors/cors_url_loader_factory.cc verifies that if the value is set, SiteForCookies is empty on the request. (3b) content/browser/worker_host/shared_worker_service_impl.cc sets the SiteForCookies used to load the script to empty. (3c) content/renderer/worker/embedded_shared_worker_stub.cc ensures that that on redirect we maintain the correct site for cookies. (3d) third_party/blink/renderer/core/fetch/fetch_manager.cc sets the SiteForCookies used to load worker fetches to empty. (4) The WPTs verify only the proper cookies can be get/set in each context, including worker load, worker fetch, and on redirect. Design Doc: https://docs.google.com/document/d/19qCGb4qwOcGiNrQM3ptWvRmB4JtpaTFgFVlWLXNOQ6c/edit Explainer: https://privacycg.github.io/saa-non-cookie-storage/shared-workers.html Part 1: Expose same-site cookie IPC Part 2: Expose same-site cookie IDL Part 3: Implement same-site cookie filtering Part 4: Add SharedWorker support to SAA handle Bug: 1484966 Change-Id: I9a6acfb94c099020683c860cb625be2519c2f384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5269461 Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Auto-Submit: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259922}
Configuration menu - View commit details
-
Copy full SHA for f6b79c6 - Browse repository at this point
Copy the full SHA f6b79c6View commit details -
webrtc wpt: fix and re-enable getStats WPT (web-platform-tests#44553)
which were broken by Firefox waiting for a track unmute event on a track that was/is not muted. BUG=324977981,chromium:1395574 Change-Id: I75cc12a98c366ea4bc4b50258f9a415d512cebd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287275 Reviewed-by: Henrik Boström <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259731} Co-authored-by: Philipp Hancke <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 902c80c - Browse repository at this point
Copy the full SHA 902c80cView commit details -
webrtc wpt: update more tests to use receiver capabilities for setCod…
…ecPreferences (web-platform-tests#44554) BUG=webrtc:15396 Change-Id: Icb67eacc4554c5cf356b12ff7e7306ac795c4f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287360 Reviewed-by: Henrik Boström <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259818} Co-authored-by: Philipp Hancke <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f664d06 - Browse repository at this point
Copy the full SHA f664d06View commit details -
Fix <select> manual assignment crash
The new code for <select>'s shadowroot does some slot assignment stuff before switching the mode to manual, which left SlotAssignment in a bad state where it cached nodes for named assignment but then expected there to be none for manual assignment. This patch fixes this by setting the slot assignment mode before appending any <slot>s to the <select>'s shadowroot. I am working on a followup to disallow changing assignment modes while there are children so other people don't run into this. Fixed: 324325525 Change-Id: Id7c335380f0924076a7f47818b4a2e3fa0b903d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282077 Commit-Queue: Di Zhang <[email protected]> Auto-Submit: Joey Arhar <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1259973}
Configuration menu - View commit details
-
Copy full SHA for 4aa22e7 - Browse repository at this point
Copy the full SHA 4aa22e7View commit details -
Relax slightly the SNR test for the OscillatorNode to account for all…
… build configuration. Differential Revision: https://phabricator.services.mozilla.com/D201597 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879715 gecko-commit: 0d474eb34652f4c47a16b6d83012c0f2e026dc00 gecko-reviewers: media-playback-reviewers, alwu
Configuration menu - View commit details
-
Copy full SHA for 0f31a8c - Browse repository at this point
Copy the full SHA 0f31a8cView commit details -
[Editing] Merge the styles of fragment nodes during paste.
During copy, a fragment could have inline elements with custom styles that need to preserved when it's pasted inside a block level element. Bug: 41493098 Change-Id: I134b37e068c4bdf4ab68aa7f7ca93baf61d44ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282696 Commit-Queue: Anupam Snigdha <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260046}
Configuration menu - View commit details
-
Copy full SHA for 6c7e1e5 - Browse repository at this point
Copy the full SHA 6c7e1e5View commit details -
Fix min-content related crash in `LineBreaker::SplitTrailingBidiPrese…
…rvedSpace` In crrev.com/c/5199988, the `SplitTrailingBidiPreservedSpace` method was added to the `LineBreaker` class, which is called right at the end of line breaking. This method fixes a bidi bug where trailing spaces were not being reset to the paragraph's bidi direction, and it does so by splitting some item results (and their shape results) into two after their construction. This method assumes that non-empty item results always have a non-null shape result. This is usually the case, but when computing the minimum and maximum sizes of an inline node (e.g. for `{min,max}-content`), a fast path is used (`LineBreak::HandleTextForFastMinContent`) which creates inline item results with a null shape result. This caused a crash when trying to create a `ShapeResultView` without a source shape result. This patch fixes this by adding an early return from `LineBreaker::SplitTrailingBidiPreservedSpace` if the line breaker mode is `kMinContent`. This is incorrect, but it can only affect the hanging behavior of trailing other space separators, which is already incorrect with `{min,max}-content` even in non-bidi text. We are already working on fixing this behavior, and we don't expect any breakage resulting from this early return. Bug: 324684931 Change-Id: I6a5a7aae06a0aafdb34b5836030921041d50dfb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5291239 Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Andreu Botella <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260059}
Configuration menu - View commit details
-
Copy full SHA for dfd8ddb - Browse repository at this point
Copy the full SHA dfd8ddbView commit details -
Add 'libegl1-mesa-dev' needed by Servo to the Docker image (web-platf…
…orm-tests#44493) Servo now requires 'libegl1-mesa-dev' as a runtime dependency. This should fix the crashes in wdspec: https://github.com/web-platform-tests/wpt/runs/20476263011 Signed-off-by: Mukilan Thiyagarajan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fccb038 - Browse repository at this point
Copy the full SHA fccb038View commit details -
Add WPT test validating that drawImage writes to the layer
Added a WPT to check that using `drawImage` inside a layer writes the image to the layer and not it's parent directly. The test uses `drawImage` with another canvas as source, inside a layer that applies a filter and uses the global composite operation `xor`. In its reference, the same drawing commands are used in the main canvas inside the layer, to verify that the filter effect is applied on the image, and that the compositing of the `drawImage` operation is done with the layer's content and not the parent's. Bug: 1396372 Change-Id: I377b4eb0b77865c639b296df70110c2fa8f7f07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5253602 Reviewed-by: Fernando Serboncini <[email protected]> Reviewed-by: Jean-Philippe Gravel <[email protected]> Commit-Queue: Andres Ricardo Perez <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260079}
Configuration menu - View commit details
-
Copy full SHA for fe09a18 - Browse repository at this point
Copy the full SHA fe09a18View commit details -
Migrate WebHID MojoJS based tests to internal folder
This CL migrate WebHID MojsJS based tests and resource to internal folder temporary. We will move it back once WebHID Testing specification for test-only interface is defined. Bug: 324264462 Change-Id: I350704c624ab3a7e8610840a93aad58027d613d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5277558 Reviewed-by: Alvin Ji <[email protected]> Commit-Queue: Alvin Ji <[email protected]> Reviewed-by: Matt Reynolds <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260105}
Configuration menu - View commit details
-
Copy full SHA for 2329ca0 - Browse repository at this point
Copy the full SHA 2329ca0View commit details
Commits on Feb 14, 2024
-
[Protected Audiences] Remove some instances of "Url" from WPT tests.
Most APIs have been switched from "Url" to "URL", so tests should reflect that. Using the right string also reduces deprecation warnings when running tests. This CL also migrates "dailyUpdateUrl" to "updateURL" in some tests. This CL leaves alone a couple cases where "Url" values are needed to run object equality comparisons, and most of the usage in trusted-scoring-signals.py, which still receives query params "renderUrls" and "adComponentRenderUrls", and no additional "URL" argument, though this cl does update it to return a JSON response with a "renderURLs" section instead of "renderUrls" (the component ad section had already been updated). Bug: 40264073 Change-Id: Iaf231a2320847b216e8c284ce596989c99b38b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282480 Commit-Queue: mmenke <[email protected]> Reviewed-by: Caleb Raitto <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260081}
Configuration menu - View commit details
-
Copy full SHA for ee5cbee - Browse repository at this point
Copy the full SHA ee5cbeeView commit details -
[CompositeClipPathAnimation] Resolve flakey tests.
Mac failures of the fixed-position test have stopped and the test can now be re-enabled. Two-clip-path-animation-diff-length1 was flakey as sometimes animations[1] would not have populated by the time the scripts were run. This change adds a RAF that resolves the issue, and it no longer repros with a 1000 executions (previously the repro rate was approximately 1:100) Bug: 1474966, 1411760 Change-Id: I6bf988254d9bf8cc042dc54cff63598513627e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5200651 Reviewed-by: Olga Gerchikov <[email protected]> Commit-Queue: Claire Chambers <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260124}
Configuration menu - View commit details
-
Copy full SHA for 93fb47c - Browse repository at this point
Copy the full SHA 93fb47cView commit details -
Use scroll margin for iframes' lazy loader.
When creating an intersection observer for an iframe lazy loader we use the margin values we get from GetLazyLoadingFrameMarginPx as the value for the scroll margin and not for the root margin, to allow lazy loading for iframes. (Also including fix to the test expectations and a minor fix for one of the tests) Spec: https://html.spec.whatwg.org/#lazy-load-root-margin Bug: 40943726 Change-Id: Ifc15d79ced91e5e00d6c736907ea1feaa56a5532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293006 Auto-Submit: Yotam Hacohen <[email protected]> Commit-Queue: Yotam Hacohen <[email protected]> Reviewed-by: Traian Captan <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Commit-Queue: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260177}
Configuration menu - View commit details
-
Copy full SHA for 02823cf - Browse repository at this point
Copy the full SHA 02823cfView commit details -
Add test case for crbug.com/41490395
The bug is fixed by HitTestOpaqueness. Bug: 41490395 Change-Id: I2466e1c50dec92b28be2af20b8747f9030de3c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293069 Commit-Queue: Xianzhu Wang <[email protected]> Reviewed-by: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260207}
Configuration menu - View commit details
-
Copy full SHA for 938e843 - Browse repository at this point
Copy the full SHA 938e843View commit details -
[wpt] Update test client to support "filter" argument for "storage.ge…
…tCookies" command. Differential Revision: https://phabricator.services.mozilla.com/D199069 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1854580 gecko-commit: c992fe0e830b7cb67c4e716769187af0cc286c6b gecko-reviewers: webdriver-reviewers, jdescottes
Configuration menu - View commit details
-
Copy full SHA for bdd08b8 - Browse repository at this point
Copy the full SHA bdd08b8View commit details -
[wdspec] Add tests for "storage.getCookies" command.
Differential Revision: https://phabricator.services.mozilla.com/D199070 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1854580 gecko-commit: 4fb6d37cd40214f3f1345f891a11ce33184bc9da gecko-reviewers: webdriver-reviewers, sadym, whimboo
Configuration menu - View commit details
-
Copy full SHA for d5bb13e - Browse repository at this point
Copy the full SHA d5bb13eView commit details -
Revise nonterminating test from RTCPeerConnection-SLD-offer
This was blocking other tests, and it was possible to rework it so that the failure it exposed did not cause a hang. Bug: chromium:1043503 Change-Id: Ic4d41a486e547de3f28a964e5f3dda412d375821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243893 Reviewed-by: Henrik Boström <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260339}
Configuration menu - View commit details
-
Copy full SHA for fd86255 - Browse repository at this point
Copy the full SHA fd86255View commit details -
New implementation for finding ::first-letter text
The old implementation was not able to fully traverse an inline box tree to find the first text node. One of the cases it gave up and returned nullptr caused the crash issue 41492455. Drilling down the block-level descendants is now separated from traversing the inline boxes for the first line, which should be simpler to understand. The inline box traversal is now able to move back up through inline box ancestry where the previous implementation just gave up. The implementation now supports punctuation and the actual first letter character being spread across multiple text nodes. The implementation keeps track of consecutive punctuation that is not separated by spaces where the old implementation would just ignore punctuation in one text node and allow a first letter character from another to be rendered as the ::first-letter even if there was a space in between. Block level grid, flex, and table are no longer allowing a rendered ::first-letter in a succeeding sibling block. Bug: 41492455, 41095963, 40646708, 40655766 Change-Id: I0de207d5ae6e0bfc2c4d7cf4b72ebfbfdd919fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263419 Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260345}
Configuration menu - View commit details
-
Copy full SHA for 34dd07e - Browse repository at this point
Copy the full SHA 34dd07eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5cac38 - Browse repository at this point
Copy the full SHA f5cac38View commit details -
orientation-event: Test DeviceOrientationEvent's absolute value on er…
…ror (web-platform-tests#44557) Test for w3c/deviceorientation#139. When a reading cannot be provided, `absolute` needs to be set accordingly depending on the event type we are listening to.
Configuration menu - View commit details
-
Copy full SHA for fb4cd8f - Browse repository at this point
Copy the full SHA fb4cd8fView commit details -
Add notifyEvent API for fenced frames.
This API allows DOM events that occur within a fenced frame to be observed by the frame's embedder in a privacy-respecting manner. When an eligible event type (currently, just click) occurs within the embedded document, window.fence.notifyEvent(e) can be called with the event object, which will create a censored version of the event to be handled by the embedder via addEventListener(). This API is being implemented as part of the "fenced frames with local unpartitioned data access" proposal, see explainer here: https://github.com/WICG/fenced-frame/blob/master/explainer/fenced_frames_with_local_unpartitioned_data_access.md Design doc for this CL is here: https://docs.google.com/document/d/1EiysMPnARSx2pzI1hSeFlI7k2ETxs5ycZoV2Cy08PEk/edit?usp=sharing Bug: 1515579 Change-Id: I7f155e5640e7b798ca33a48c6afdda9c039d45c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5166147 Reviewed-by: Alex Moshchuk <[email protected]> Commit-Queue: Andrew Verge <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260541}
Configuration menu - View commit details
-
Copy full SHA for 4621ea8 - Browse repository at this point
Copy the full SHA 4621ea8View commit details -
[SAA] Implementing SharedWorker support (Part 4: Add SharedWorker sup…
…port to SAA handle) The Storage Access API provides access to unpartitioned cookies in third-party contexts. This CL is part of a series to extend that access to SharedWorkers. This CL implements the final component, SharedWorker access via the SAA handle itself. Prior CLs set up the proper cookie filtering we test here to ensure no third-party context can access SameSite=Lax/Strict cookies (even if they can access unpartitioned SameSite=None cookies). Design Doc: https://docs.google.com/document/d/19qCGb4qwOcGiNrQM3ptWvRmB4JtpaTFgFVlWLXNOQ6c/edit Explainer: https://privacycg.github.io/saa-non-cookie-storage/shared-workers.html Part 1: Expose same-site cookie IPC Part 2: Expose same-site cookie IDL Part 3: Implement same-site cookie filtering Part 4: Add SharedWorker support to SAA handle Bug: 1484966 Change-Id: Ic23366a84176b6eb1c3ec5724fad07f2bffa9216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5277592 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Auto-Submit: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260592}
Configuration menu - View commit details
-
Copy full SHA for 92cff38 - Browse repository at this point
Copy the full SHA 92cff38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2736c7f - Browse repository at this point
Copy the full SHA 2736c7fView commit details -
[css-scroll-snap-2] Prioritize inner snap targets
Prefer nested snap targets, per step 5[1]. The change to scroll_snap_data_unittest.cc is to make the scroll's ending position a little closer to outside small_2. Otherwise, either snapping to the bottom of small_2 or out of it is a viable option. [1] w3c/csswg-drafts#9622 (comment) Bug: 323840828 Change-Id: Ic2c41e7a4b47a74e85581c8f3b5eb88a42719219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5269646 Reviewed-by: Steve Kobes <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260782}
Configuration menu - View commit details
-
Copy full SHA for 4719225 - Browse repository at this point
Copy the full SHA 4719225View commit details
Commits on Feb 15, 2024
-
Fenced frames: Disable popup navigations after network revocation (we…
…b-platform-tests#44552) Navigations into and out of fenced frames need to be treated specially for network revocation, because they don't have the revoked partition nonce attached. Previous CLs disabled embedder-initiated fenced frame root navigations and _unfencedTop navigations; this CL disables popup navigations. Bug: 1515599 Change-Id: Ia05e3fecb40240de1d32a3e736e42eba5f03f411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259509 Reviewed-by: Dominic Farolino <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Commit-Queue: Garrett Tanzer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260187} Co-authored-by: Garrett Tanzer <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bbf3512 - Browse repository at this point
Copy the full SHA bbf3512View commit details -
Revert "Add notifyEvent API for fenced frames."
This reverts commit 62f8e1eb2e54597cacc165645e888c6b89229826. Reason for revert: virtual/fenced-frame-mparch/external/wpt/fenced-frame/notify-event-invalid.https.html is flaky across multiple platforms, and this CL is shown within the suspected range. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/141362/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/88121/overview Original change's description: > Add notifyEvent API for fenced frames. > > This API allows DOM events that occur within a fenced frame > to be observed by the frame's embedder in a privacy-respecting manner. > When an eligible event type (currently, just click) occurs within > the embedded document, window.fence.notifyEvent(e) can be called > with the event object, which will create a censored version of > the event to be handled by the embedder via addEventListener(). > > This API is being implemented as part of the "fenced frames with > local unpartitioned data access" proposal, see explainer here: > https://github.com/WICG/fenced-frame/blob/master/explainer/fenced_frames_with_local_unpartitioned_data_access.md > > Design doc for this CL is here: > https://docs.google.com/document/d/1EiysMPnARSx2pzI1hSeFlI7k2ETxs5ycZoV2Cy08PEk/edit?usp=sharing > > Bug: 1515579 > Change-Id: I7f155e5640e7b798ca33a48c6afdda9c039d45c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5166147 > Reviewed-by: Alex Moshchuk <[email protected]> > Commit-Queue: Andrew Verge <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1260541} Bug: 1515579 Change-Id: I9c26e15b7edbf261d93c1017a91d797f3922d5dc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5298514 Owners-Override: Robert Lin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Huanpo Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260787}
Configuration menu - View commit details
-
Copy full SHA for 4bd0a19 - Browse repository at this point
Copy the full SHA 4bd0a19View commit details -
Add shadowRootDelegatesFocus and shadowRootClonable reflection
The `shadowRootDelegatesFocus` IDL is standardized [1], and was just never added to Chromium. This CL lands this addition behind a kill switch, but should be very safe to add. The `shadowRootClonable` IDL is being added as part of [2], which has support and should land soon. [1] https://html.spec.whatwg.org/multipage/scripting.html#htmltemplateelement [2] whatwg/html#10117 Bug: 1510466 Change-Id: I708ec8d562fa4d0fc59c73a071dbb191e1bd276e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5261148 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: David Baron <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260805}
Configuration menu - View commit details
-
Copy full SHA for 07a8d15 - Browse repository at this point
Copy the full SHA 07a8d15View commit details -
More declarative shadow tree test coverage
We only care about mode mismatching. And we should also test with multiple <template> elements that have the same mode, to avoid triggering the mode mismatch exception.
Configuration menu - View commit details
-
Copy full SHA for 6318d09 - Browse repository at this point
Copy the full SHA 6318d09View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8c0ef3 - Browse repository at this point
Copy the full SHA b8c0ef3View commit details -
Update pointerevents/META.yml suggested reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201814 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1880250 gecko-commit: c52465b86d23035daaeb02d3dff28e6bf8009a3d gecko-reviewers: edgar
Configuration menu - View commit details
-
Copy full SHA for 7ecbda7 - Browse repository at this point
Copy the full SHA 7ecbda7View commit details -
Allow RTCDTMFToneChangeEvents to fire up to 1ms early.
Firefox's timer implementation allows events to fire 250μs early. Instead of using a non-fuzzy timer in Firefox (may cause extra wakeups) or an artificial extra delay on every dtmf event, relax the test case a bit. Differential Revision: https://phabricator.services.mozilla.com/D201821 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1785418 gecko-commit: 8175af8c6fb443418b4fb401b5a2ab282ed73846 gecko-reviewers: bwc
Configuration menu - View commit details
-
Copy full SHA for 616d362 - Browse repository at this point
Copy the full SHA 616d362View commit details -
Add rounding test to orientation-event WPT
https://crrev.com/c/5249795 converted orientation-event web tests to use WebDriver and virtual sensors. Virtual sensors follow security and privacy requirements defined in https://www.w3.org/TR/orientation-event/#security-and-privacy. One of these requirements include limiting the precision of values. Specification defines that all measurements are required to be coarsened to 0.1 degrees, 0.1 m/s^2 or 0.1 deg/s. This change tests that requirement to limit precision is met. Bug: 1520919 Change-Id: I58b266dc602187e2e4c4d9a3a67f12ac91136e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5295494 Commit-Queue: Raphael Kubo Da Costa <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Auto-Submit: Juha J Vainio <[email protected]> Reviewed-by: Raphael Kubo Da Costa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1260950}
Configuration menu - View commit details
-
Copy full SHA for 5a60e4c - Browse repository at this point
Copy the full SHA 5a60e4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2380482 - Browse repository at this point
Copy the full SHA 2380482View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57308ed - Browse repository at this point
Copy the full SHA 57308edView commit details -
Test to popover and postioned elements
Differential Revision: https://phabricator.services.mozilla.com/D201729 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1828898 gecko-commit: e3cd1999f1dac41420e53e819c582626fca67178 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for c5e5bdb - Browse repository at this point
Copy the full SHA c5e5bdbView commit details -
[wdspec] Add tests for "storage.setCookie" command.
Differential Revision: https://phabricator.services.mozilla.com/D200188 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1854582 gecko-commit: 92a4dc88b6609c0b905e50df87dc99a5ccd3b39c gecko-reviewers: webdriver-reviewers, sadym, whimboo
Configuration menu - View commit details
-
Copy full SHA for 8d8eb48 - Browse repository at this point
Copy the full SHA 8d8eb48View commit details -
[wdspec] Add tests for "storage.getCookies" command using "storage.se…
…tCookie" command. Differential Revision: https://phabricator.services.mozilla.com/D200189 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1854582 gecko-commit: 61978565045bcc040ed9c85508896995efe43536 gecko-reviewers: webdriver-reviewers, jdescottes
Configuration menu - View commit details
-
Copy full SHA for b393c4e - Browse repository at this point
Copy the full SHA b393c4eView commit details -
Add gecko specific tests for
storage.getCookies
and `storage.setCoo……kie` commands. Differential Revision: https://phabricator.services.mozilla.com/D201238 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1854582 gecko-commit: 2b4e9ee6225f1183da45d24404e72f48e3803f08 gecko-reviewers: webdriver-reviewers, whimboo
Configuration menu - View commit details
-
Copy full SHA for 47aa7a6 - Browse repository at this point
Copy the full SHA 47aa7a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f773618 - Browse repository at this point
Copy the full SHA f773618View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cac086 - Browse repository at this point
Copy the full SHA 7cac086View commit details -
Invalidate SVG paint server clients on style transform changes
Fixed: 325102877 Change-Id: I4e32f8bd793ff030622ab5283f7498ef269ec880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5300317 Reviewed-by: Stephen Chenney <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Auto-Submit: Fredrik Söderquist <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261129}
Configuration menu - View commit details
-
Copy full SHA for 1971e60 - Browse repository at this point
Copy the full SHA 1971e60View commit details -
[SAA] Include unpartitioned cookies in DedicatedWorker load if Storag…
…eAccess was granted We should include SameSite=None cookies that will be available when the worker fetches when the worker loads. This aligns with the work done in: https://chromium-review.googlesource.com/c/chromium/src/+/4968438 to fill in a missing case where cookies should be included. This still requires the third-party frame creating the DedicatedWorker already had StorageAccess granted. Security Considerations: We have to pass the hasStorageAccess bool from the renderer as only it knows if cookie access (and not just some other storage access) was granted, but we verify this in the browser process by checking if there is a record of a storage access grant. There's a single permission here, STORAGE_ACCESS, and if it was granted then the renderer has access to any forms of unpartitioned storage without spawning dedicated workers. For that reason, it's okay to trust the renderer when it says it needs unpartitioned cookies specifically, as long as we check if the underlying permission was actually granted. Bug: 325029895, b:299515369, 1495169 Change-Id: I57575392b72955088435f095b0087acef0143777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293896 Auto-Submit: Ari Chivukula <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Reviewed-by: Camille Lamy <[email protected]> Reviewed-by: Chris Fredrickson <[email protected]> Reviewed-by: danakj <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261136}
Configuration menu - View commit details
-
Copy full SHA for 231486e - Browse repository at this point
Copy the full SHA 231486eView commit details -
Add WebRTC test for offer with duplicate a=msid line
This is illegal according to RFC 8830 section 2. Bug: webrtc:15845 Change-Id: I84c70d369178c9ee65aed94407c1524a19988318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296402 Reviewed-by: Florent Castelli <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261159}
Configuration menu - View commit details
-
Copy full SHA for de8ec2f - Browse repository at this point
Copy the full SHA de8ec2fView commit details -
Add more tests for dangling markup mitigation
Adding more test per request[1]. [1] whatwg/html#10022 (review) Change-Id: I7d4d3494fa3aa0ac41c48727c2f866ccf3f016d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5278680 Reviewed-by: Jonathan Hao <[email protected]> Reviewed-by: Yifan Luo <[email protected]> Auto-Submit: Jun Kokatsu <[email protected]> Commit-Queue: Jun Kokatsu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261160}
Configuration menu - View commit details
-
Copy full SHA for b9dc4df - Browse repository at this point
Copy the full SHA b9dc4dfView commit details -
[Protected Audiences] Add some generateBid browserSignals tests.
These include a basic all-fields test, and joinCount tests. Still need tests for bidCount and prevWinsMs. Bug: 40261114 Change-Id: I5ceebca3e26bba6083c5d4e9631ff94e69e634e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5285076 Reviewed-by: Maks Orlovich <[email protected]> Commit-Queue: mmenke <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261242}
Configuration menu - View commit details
-
Copy full SHA for 9f74d5a - Browse repository at this point
Copy the full SHA 9f74d5aView commit details -
[Event Timing] Expose interactionId to Keypress & keydown/up under co…
…mposition This CL changes the logic of generating interaction Id for keyboard events in performance event timing. Non-composition: * Previous behaviour: Interaction id is generated on keyups, and will match the related keydown backwards. * New behaviour: Interaction id is now generated on the keydown entry, and match forward with related keypress and keyup. Composition(IME, virtual keyboard, etc.): * Previous behaviour: Interaction id is assigned to each input event only. * New behaviour: Interaction id is generated on the first input or keydown event (whichever comes first) before the compositionupdate, and any further keydown or input event before the compositionupdate and any number of keyups after compositionupdate will be matched with same interaction id. This may affect the total duration of INP since more events are now being meatured, eg. keypress. Low-Coverage-Reason: OTHER This CL is also covered by wpt manual test. Bug: 1456384 Change-Id: Ie736f3f189e9a349badbe03c4a65627ac491eff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4632521 Reviewed-by: Robert Flack <[email protected]> Commit-Queue: Aoyuan Zuo <[email protected]> Reviewed-by: Michal Mocny <[email protected]> Reviewed-by: Aoyuan Zuo <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261339}
Configuration menu - View commit details
-
Copy full SHA for efc2d1f - Browse repository at this point
Copy the full SHA efc2d1fView commit details
Commits on Feb 16, 2024
-
Make dir=auto elements without strong characters ltr (rather than inh…
…eriting). This reverts (conditioned on a new DirAutoNoInheritance flag) a previous change from https://crrev.com/c4557b863d101826932f33757e9398e7fca056c9 and makes it so that dir=auto elements never inherit directionality from their parent. Instead, when no strong characters are present, they have LTR directionality, as we did before. Reverting to our old behavior (and reverting the relevant test to its old state) seems like the best option given the discussion in whatwg/html#10097 . Once this ships to stable we can remove the mechanisms used to support that inheritance. The changes in html/dom/elements/global-attributes/dir_auto-N-EN.html and its reference are a direct revert of the prior test change in the CL above. The changes in bdi-auto-dir-default.html and bdi-dir-default-to-auto.html are reverting a newer test change from https://crrev.com/4278cdb00ac4e727c1123e5eb4aba86509e87c0b . The new dir-shadow-42 test is a version of dir-shadow-41 with the directions swapped, to make sure things are tested more thoroughly. Fixed: 41494751 Bug: 576815 Change-Id: I68b36a1fc19a0553f582fdf2fd02a94d6e633686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5302287 Commit-Queue: David Baron <[email protected]> Commit-Queue: Di Zhang <[email protected]> Auto-Submit: David Baron <[email protected]> Reviewed-by: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261442}
Configuration menu - View commit details
-
Copy full SHA for 9630591 - Browse repository at this point
Copy the full SHA 9630591View commit details -
document pip: Allow window.focus() to focus the opener tab from pip
This CL modifies the Window's focus() API to allow picture-in-picture windows to focus their opener windows, similarly to how opener windows can currently focus their popup windows. This consumes a user gesture. chromestatus link: https://chromestatus.com/feature/6313015987404800 Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/eu2Vyh176wM Change-Id: If881f5d5e991591d8d677fccca50eefc65448fa9 Bug: b/310971668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189973 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Frank Liberato <[email protected]> Commit-Queue: Tommy Steimel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261450}
Configuration menu - View commit details
-
Copy full SHA for c79550b - Browse repository at this point
Copy the full SHA c79550bView commit details -
Add 'writingsuggestions' tests for disabled elements and "unsupported"
input types This CL adds tests for disabled elements and input types to which writing suggestions are not applicable (eg <input type="color"/>). The 'writingsuggestions' attribute setting/getting/reflection behavior for these types of elements is identical to that of elements on which writing suggestions should be generated. The User Agent is responsible for ensuring that writing suggestions aren't applied to these types of elements. github.com/web-platform-tests/pull/43780#issuecomment-1936426092 Bug: 1513953 Change-Id: I31aa03b131ab440d5d6e749c227837997f13464c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5299628 Commit-Queue: Stephanie Zhang <[email protected]> Reviewed-by: Sanket Joshi <[email protected]> Reviewed-by: Dan Clark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261510}
Configuration menu - View commit details
-
Copy full SHA for f6f118d - Browse repository at this point
Copy the full SHA f6f118dView commit details -
Remove old OOF fragmentation spanner-awareness code.
This was needed back when OOFs didn't affect column balancing. We would in some cases have to manually create additional fragmentainers when starting layout of an OOF (with a sufficiently large block-offset) *after* the spanner, even though the OOF was defined before the spanner. We no longer do that, now that OOFs affect column balancing. The code that's now removed had no effect (as far as I can tell) in non-nested multicol, since we always make room for OOFs before the spanner. However, it did do something in nested multicol with spanners, because we'll fail to make enough room for OOFs in cases where they would cross an outer fragmentainer boundary. What this code did was wrong in such cases anyway. It would push additional fragmentainers below the spanner, and not set the right block-size, resulting in overflowing the outer fragmentation context in the block direction. By removing this code, we'll now just create additional fragmentainers at the same block-offset as the last one, progressing in the inline direction. This is the best we can do (and what we did in all other cases, anyway), since we don't support creation of additional outer fragmentainers for OOFs. Two unit tests have to be updated, because of the above. One of them now behave correctly, while the other one still isn't quite there. Add a web test for it as well. By removing this code, UpdatedFragmentainerOffset() ended up only adding fragmentainer_progression, if it was a new fragment. Just remove the function and do the job at the call site instead. In LayoutOOFsInFragmentainer(), if we find the last fragmentainer *before* calling GetFragmentainerConstraintSpace(), we won't have to do the same job in there, since GetFragmentainerConstraintSpace() no longer needs to know whether it's a new fragmentainer or not. This doesn't really fix crbug.com/40775119 , but it does improve the rendering of the demo there. Bug: 40775119 Change-Id: I98094ee5da428a190355d72da8eff0f901b2b874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5300220 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Alison Maher <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261525}
Configuration menu - View commit details
-
Copy full SHA for f74d912 - Browse repository at this point
Copy the full SHA f74d912View commit details -
Implement constructor in RTCEncodedVideoFrame
This is inline with the algorithm described in w3c/webrtc-encoded-transform@main...palak8669:webrtc-encoded-transform:constructor_frame Bug: 14709 Change-Id: I19f096f7f4cbcdc0a3050d45f8cce8c4f622c479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5295578 Commit-Queue: Palak Agarwal <[email protected]> Reviewed-by: Guido Urdaneta <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261585}
Configuration menu - View commit details
-
Copy full SHA for e6dbd29 - Browse repository at this point
Copy the full SHA e6dbd29View commit details -
Enable CSS display-mode support for picture-in-picture by default
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/_Ml1o8xYZc8 Bug: 41493667 Change-Id: I170a0ea3f1b694644c3c079a0a7f9ac79e543a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5290634 Reviewed-by: Yoav Weiss (@Shopify) <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261612}
Configuration menu - View commit details
-
Copy full SHA for 0f0f125 - Browse repository at this point
Copy the full SHA 0f0f125View commit details -
Remove replaceState from SoftNav heuristics
Change-Id: I09f109505cdd3e60ffc6ba5b6fa00dea3526c5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5292394 Reviewed-by: Scott Haseley <[email protected]> Commit-Queue: Ian Clelland <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Michal Mocny <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261621}
Configuration menu - View commit details
-
Copy full SHA for e35fb78 - Browse repository at this point
Copy the full SHA e35fb78View commit details -
[css-anchor-position] position-try shorthand parsing and computed
Bug: 40279608 Change-Id: I9af1dd56cba24a271da30fc01d573820d9e642c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5290844 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261631}
Configuration menu - View commit details
-
Copy full SHA for 196f4a5 - Browse repository at this point
Copy the full SHA 196f4a5View commit details -
Revert "Implement constructor in RTCEncodedVideoFrame"
This reverts commit 005fcd6a9a78ab12e97ad1dbca452ff37292f7ec. Reason for revert: Suspected of causing failures in RTCEncodedVideoFrame-metadata.https.html, see e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/141424/overview (occurring on many bots) Original change's description: > Implement constructor in RTCEncodedVideoFrame > > This is inline with the algorithm described in w3c/webrtc-encoded-transform@main...palak8669:webrtc-encoded-transform:constructor_frame > > Bug: 14709 > Change-Id: I19f096f7f4cbcdc0a3050d45f8cce8c4f622c479 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5295578 > Commit-Queue: Palak Agarwal <[email protected]> > Reviewed-by: Guido Urdaneta <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1261585} Bug: 14709 Change-Id: I146f0be73eb77ed68ba4e1188447700beb619efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5302242 Owners-Override: Stephen McGruer <[email protected]> Commit-Queue: Stephen McGruer <[email protected]> Reviewed-by: Palak Agarwal <[email protected]> Auto-Submit: Stephen McGruer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261654}
Configuration menu - View commit details
-
Copy full SHA for f3f2e7c - Browse repository at this point
Copy the full SHA f3f2e7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96f5143 - Browse repository at this point
Copy the full SHA 96f5143View commit details -
Make
inert-iframe-hittest.html
initialize pointer position before a……dding event listeners The test does not initialize the pointer event. Therefore, if the last test which moved pointer over the `<iframe>`, only the mouse boundary events may be flushed and the first pointer move causes only the pointer boundary events like the intermittent failures. Differential Revision: https://phabricator.services.mozilla.com/D201799 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879620 gecko-commit: 23d3f829ae2ac23c36e4b9b524a96dd780195135 gecko-reviewers: smaug
Configuration menu - View commit details
-
Copy full SHA for 0c8fd27 - Browse repository at this point
Copy the full SHA 0c8fd27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97001c3 - Browse repository at this point
Copy the full SHA 97001c3View commit details -
The problem with the test was that it was dragging not only out of the div that was to be overscrolled but also out of the window. This patch changes the touch dragging doesn't go out of the window. This doesn't seem to be an issue when run against content_shell but causes issues when test is run with Chrome/ChromeDriver and is actually reflected in wpt.fyi[1]. Bug: 40832230 [1]https://wpt.fyi/results/dom%2Fevents%2Fscrolling%2Foverscroll-event-fired-to-scrolled-element.html?label=experimental&label=master&aligned Change-Id: I723196406b6dc8fa174512b40a593b3bdeffd6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5297676 Reviewed-by: Steve Kobes <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261692}
Configuration menu - View commit details
-
Copy full SHA for e3b3857 - Browse repository at this point
Copy the full SHA e3b3857View commit details -
[bfcache]Update report strings for not restored reasons
This CL does the following: 1) Update the report strings for NotRestoredReasons API to be more concise. Mostly masking the reasons that are not actionable for web developers. This includes updating the test expectations accordingly. 2) Remove the unused reasons (NotMostRecentNavigationEntry and FencedFramesEmbedder) Bug: 1472637 Change-Id: I9b77bcdd3556cf6589dc422ed41ba6f9369ba129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5248405 Reviewed-by: Yuzu Saijo <[email protected]> Reviewed-by: Rakina Zata Amni <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Commit-Queue: Yuzu Saijo <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261697}
Configuration menu - View commit details
-
Copy full SHA for 553ce34 - Browse repository at this point
Copy the full SHA 553ce34View commit details -
This is part of cleanup work to remove CORB code, now that its successor ORB has been enabled. This particular CL removes rarely used functionality that we won't need going forward. This CL should be largely functionally neutral, but it affects two tests: - One subtest in PrefetchBrowserTest: It seems the test inadvertently relied on caching behaviour of ORB-blocked requests. By changing the content type to the empty string the resource is not affected by ORB at all, and the test should work as originally intended. - WPT preload/prefetch-document: The test assertions for cross-origin resources are not ORB compatible, because ORB would block those resources. The change here makes us pass the test 100%; makes Firefox (which has also implemented ORB) pass an additional subtest, and doesn't affect WebKit (which apparently doesn't implement prefetch). Ref: https://wpt.fyi/results/preload/prefetch-document.html?label=master&label=experimental&aligned&q=preload%2Fprefetch-document.html Bug: 324418206 Change-Id: I2fbaec1a51a0cfd5d6df731a831b8a3c09bf0693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5277068 Commit-Queue: Daniel Vogelheim <[email protected]> Reviewed-by: Noam Rosenthal <[email protected]> Reviewed-by: Kenichi Ishibashi <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261708}
Configuration menu - View commit details
-
Copy full SHA for 89869bd - Browse repository at this point
Copy the full SHA 89869bdView commit details -
[EditContext] Allow backwards range params in updateText
Per w3c/edit-context#90, EditContext.updateText() should allow the start/end parameters to be backwards. Bug: 40642681 Change-Id: Idde01fa7282120e0961eb60a9ccab58061f4062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301307 Reviewed-by: Anupam Snigdha <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Dan Clark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261748}
Configuration menu - View commit details
-
Copy full SHA for 86be793 - Browse repository at this point
Copy the full SHA 86be793View commit details -
Remove loaders constant from preload/prefetch-document.
I could not find any usage of this constant in the test. This is a drive-by cleanup of work to remove CORB code. Bug: 324418206 Change-Id: I506def1e4e10fe7223cc00caed8504656c53b321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273194 Commit-Queue: Daniel Vogelheim <[email protected]> Reviewed-by: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261751}
Configuration menu - View commit details
-
Copy full SHA for db543b1 - Browse repository at this point
Copy the full SHA db543b1View commit details -
'writingsuggestions' content attribute should reflect the given value
In CL:5247315, we set the content attribute to values 'true'/'false' during the IDL setter. However, it was raised in spec dicussions that the content attribute should just reflect the value set by the IDL setter to match the default reflection logic of enumerated attributes. E.g. when setting element.writingSuggestions = "invalid-value" Previously: getAttribute("writingsuggestions") == "true" Now: getAttribute("writingsuggestions") == "invalid-value" Bug: 1513953 Change-Id: Iebb008de9cda661509bab6cfe1ffa97566986639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5297548 Reviewed-by: Sanket Joshi <[email protected]> Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Dan Clark <[email protected]> Commit-Queue: Stephanie Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261866}
Configuration menu - View commit details
-
Copy full SHA for 6bad5f5 - Browse repository at this point
Copy the full SHA 6bad5f5View commit details -
In order for these to work we need to actually shim user interactions and permission grants. The prior code only works for content_shell. One thing we can't seem to test now is what happens if cookies are partitioned. That doesn't seem to be enabled here and the way we can fake that for content_shell doesn't work. Looking to fix: https://wpt.fyi/results/storage-access-api?label=experimental&label=master&aligned Using the commands from: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/run_web_platform_tests.md Change-Id: I122258d0cc9f3449d3e84526b689f86a92d84333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301177 Auto-Submit: Ari Chivukula <[email protected]> Reviewed-by: Kyra Seevers <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261875}
Configuration menu - View commit details
-
Copy full SHA for ee84ad2 - Browse repository at this point
Copy the full SHA ee84ad2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ece2f8c - Browse repository at this point
Copy the full SHA ece2f8cView commit details
Commits on Feb 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a415844 - Browse repository at this point
Copy the full SHA a415844View commit details -
Only check for matching mode in attachShadow
Per the new-new consensus, attachShadow will only verify that the existing declarative shadow root's `mode` matches the newly requested `mode`: whatwg/html#10107 (comment) Bug: 41483062,325598615 Change-Id: Ie3bac4ec297c0b85c40b45495e9c823dd47cb49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5283935 Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Di Zhang <[email protected]> Reviewed-by: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1262014}
Configuration menu - View commit details
-
Copy full SHA for a092215 - Browse repository at this point
Copy the full SHA a092215View commit details -
remove popover element only from top layer if it's not a dialog eleme…
…nt which is required to be on the top layer. Differential Revision: https://phabricator.services.mozilla.com/D197650 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1872778 gecko-commit: f65c6d83b6924a1df3a858a1203d9a0acd123d88
Configuration menu - View commit details
-
Copy full SHA for 504dbb9 - Browse repository at this point
Copy the full SHA 504dbb9View commit details
Commits on Feb 18, 2024
-
[webnn] Add tests for WebNN API constant (fillSequence) (web-platform…
…-tests#43801) * [webnn] Add tests for WebNN API constant (fillSequence) * [webnn] Update test data with negative start * [webnn] Update test data for integer test cases * [webnn] Add a test with negative integer step
Configuration menu - View commit details
-
Copy full SHA for 155f94a - Browse repository at this point
Copy the full SHA 155f94aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8f1e9c - Browse repository at this point
Copy the full SHA a8f1e9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32864fa - Browse repository at this point
Copy the full SHA 32864faView commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bbc413a - Browse repository at this point
Copy the full SHA bbc413aView commit details -
Remove user-find, make inert not findable.
As per the HTML spec. Differential Revision: https://phabricator.services.mozilla.com/D201906 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1868316 gecko-commit: 4eab1cec8f078b42355ff8472faef06c6487fe06 gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for 8fb5ee7 - Browse repository at this point
Copy the full SHA 8fb5ee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ca6fb2 - Browse repository at this point
Copy the full SHA 8ca6fb2View commit details -
Use GlobalTeardownObserver for consistency on workers.
This removes the manual global tracking which was only correctly hooked up for windows, but missed other global types, especially workers. Because GlobalTeardownObserver is reliably notified of when to disconnect, it is able to "safely" hold a raw non-owning pointer which simplifies cycle collection somewhat. (That design decision was originally part of DOMEventTargetHelper which GlobalTeardownObserver was extracted from.) It also provides a pre-cached window getter. This test includes a WPT test that reliably fails without the fix and passes with the fix. Differential Revision: https://phabricator.services.mozilla.com/D201188 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879259 gecko-commit: def4a6f94713c0d0e4b2808d42dd486520c00a60 gecko-reviewers: dom-storage-reviewers, janv
Configuration menu - View commit details
-
Copy full SHA for 2492b90 - Browse repository at this point
Copy the full SHA 2492b90View commit details -
Remove the popovertarget attribute or set it to an invalid value shou…
…ld clear the explicitly set attr-element. Differential Revision: https://phabricator.services.mozilla.com/D201711 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879001 gecko-commit: 6f0ebcced75f999a360fdd4f2e00d66fe811dc84 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 4926f1d - Browse repository at this point
Copy the full SHA 4926f1dView commit details -
Use valid pseudo-element syntax in pseudo-get-computed-style.html (we…
…b-platform-tests#44643) WebKit will reject the single colon syntax in `getComputedStyle()` because it is invalid.
Configuration menu - View commit details
-
Copy full SHA for 857a19c - Browse repository at this point
Copy the full SHA 857a19cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d643cf9 - Browse repository at this point
Copy the full SHA d643cf9View commit details -
Test Ed25519 with small- and mixed-order points (web-platform-tests#4…
…3751) Add tests to ensure that the Ed25519 Verify implementation performs checks for small-order keys and signature's point R. Additionally, add tests for mixed-order points, and check that the cofactorless (unbatched) verification equation is used, as required by the latest draft.
Configuration menu - View commit details
-
Copy full SHA for 0926ff5 - Browse repository at this point
Copy the full SHA 0926ff5View commit details -
Ignore lint error to unblock wpt-importer
Upstream added a new test which would trigger MISSING-LINK error. Bug: None Change-Id: I556ce91304fdcc09b616a505dfa7bf149a53e7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5308374 Commit-Queue: Weizhong Xia <[email protected]> Auto-Submit: Weizhong Xia <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1262474}
Configuration menu - View commit details
-
Copy full SHA for b31783e - Browse repository at this point
Copy the full SHA b31783eView commit details
Commits on Feb 20, 2024
-
Remove "contentinfo region scoped to main element is generic" WPT test.
Per the HTML-AAM spec, the contextual role restriction only applies to the <footer> element, not to any other instance of the ARIA contentinfo role. Even though <footer> maps to contentinfo, contentinfo does not necessarily map to <footer>. Thus, this test is incorrect. Differential Revision: https://phabricator.services.mozilla.com/D201928 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878363 gecko-commit: 5c67e50b735884a798f9a9c29b9117a1fc696ebe gecko-reviewers: nlapre
Configuration menu - View commit details
-
Copy full SHA for e955fbc - Browse repository at this point
Copy the full SHA e955fbcView commit details -
webrtc wpt: add test for codecs in subsequent offers
Asserting the "and also MUST include all currently available formats" https://www.rfc-editor.org/rfc/rfc8829.html#name-subsequent-offers See w3c/webrtc-pc#2938 BUG=None Change-Id: I7748ea94e58ba93cdf1043ee0235a7e560e260e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293377 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1262601}
Configuration menu - View commit details
-
Copy full SHA for 2898a8f - Browse repository at this point
Copy the full SHA 2898a8fView commit details -
Move some test input data from the test to the input data
Preparation for adding MutationObserver tests to the same file. See the following commits.
Configuration menu - View commit details
-
Copy full SHA for 3a15f9f - Browse repository at this point
Copy the full SHA 3a15f9fView commit details -
Add test that mutation observers receive the default policy value whe…
…n `setAttribute` is called As requested in <w3c/trusted-types#425 (comment)>.
Configuration menu - View commit details
-
Copy full SHA for b523d7b - Browse repository at this point
Copy the full SHA b523d7bView commit details