Add test for Trusted Types that mutation observers receive the default policy value when setAttribute is called
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: https://phabricator.services.mozilla.com/D195180 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1867569 gecko-commit: b26966a8b4176b72a71e58e606e42940a30d70d6 gecko-reviewers: emilio
Bumps [taskcluster](https://github.com/taskcluster/taskcluster) from 59.2.0 to 60.3.2. - [Release notes](https://github.com/taskcluster/taskcluster/releases) - [Changelog](https://github.com/taskcluster/taskcluster/blob/main/CHANGELOG.md) - [Commits](taskcluster/taskcluster@v59.2.0...v60.3.2) --- updated-dependencies: - dependency-name: taskcluster dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pygithub](https://github.com/pygithub/pygithub) from 2.1.1 to 2.2.0. - [Release notes](https://github.com/pygithub/pygithub/releases) - [Changelog](https://github.com/PyGithub/PyGithub/blob/main/doc/changes.rst) - [Commits](PyGithub/PyGithub@v2.1.1...v2.2.0) --- updated-dependencies: - dependency-name: pygithub dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
specified in: https://www.w3.org/TR/css-align-3/#valdef-align-content-space-around decision: w3c/csswg-drafts#5088 (comment) Bug: 1517655 Change-Id: I348273d53025d3a5389e1867e74c59aee291d0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5250231 Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255119}
The spec was merged here, so the tests should no longer be tentative: whatwg/html#8467 Bug: 1514397 Change-Id: I121e5e734145ff4cb122fb1bc2f7a5bc146dafca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5151685 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255129}
…PT less flaky Bug: 1515599, 1524064 Change-Id: I6ae7dab6bae07a08437e0f7aa5c815f9a7d6a9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258720 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Garrett Tanzer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255181}
…kie IDL) The Storage Access API provides access to unpartitioned cookies in third-party contexts. This CL is part of a series to extend that access to SharedWorkers. Before we actually provide access to SharedWorkers, we need a way for the renderer to limit the scope of SameSite cookies provided to the worker. Normally, a worker with a first-party storage key could access all cookies, but if access is via the SAA handle we want to limit that access to just SameSite: None cookies. This CL is part of a series to allow that limiting ability. For now, we expose the option in IDL but do not implement the change needed to limit cookie access in first-party contexts when the option is set to 'none'. The next CL will implement this limit. Note: The ability to request 'all' in a third-party context is not added here nor will it be added. We verify that an exception is thrown if this is attempted. Explainer: https://privacycg.github.io/saa-non-cookie-storage/shared-workers.html Part 1: Expose same-site cookie IPC Part 2: Expose same-site cookie IDL Part 3: Implement same-site cookie filtering Part 4: Add SharedWorker support to SAA handle Bug: 1484966 Change-Id: I8c56c02025950e119e3967afd49ed684446fd6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5251551 Reviewed-by: Weizhong Xia <[email protected]> Auto-Submit: Ari Chivukula <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Reviewed-by: Sun Yueru <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255183}
Similar to: https://chromium-review.googlesource.com/c/chromium/src/+/5250231 https://chromium-review.googlesource.com/c/chromium/src/+/5235235 Makes space-around/space-evenly fallback to safe centering alignment. See: w3c/csswg-drafts#5088 (comment) Bug: 1517655 Change-Id: I65b9b5e0540a53b61b61cd2c84d98b41f292ad76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258681 Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: Kurt Catti-Schmidt <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255220}
Bug: 1476927 Change-Id: Ia7361777d5fb1457a066d3f62cf73181c9b1f1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237290 Reviewed-by: Nicolás Peña <[email protected]> Commit-Queue: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255296}
Fixed: 1510241 Change-Id: I1ce3571c56fcfd6cc6d57458ff644162588d233a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259102 Reviewed-by: Mark Schillaci <[email protected]> Commit-Queue: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255303}
This CL implements DefineXnnNodeForMatmul() method that defines XNNPACK matmul Node by xnn_define_batch_matrix_multiply(). For unit tests, this CL implements MatmulTest of MLGraphTest that checks the compute results of matmul operators. Bug: 1273291 Change-Id: Ife8e1023804d4b9970bfff067fbeedbf12ba313e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5232604 Commit-Queue: Lisha Guo <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255409}
When crrev.com/c/5052124 started rewinding floats, its associated parallel flow break tokens should also be reset, but it didn't. This patch fixes it. The 3 tests are for the same cause, but may produce different crash points. The `1` and `2` variants are more minimized and easier to understand, but they produce different symptoms than the original case that they may not always spot this issue as the code evolves. Bug: 1520442 Change-Id: I3546dba37d0dd2324804ad6c6a408ed162934663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5251158 Commit-Queue: Koji Ishii <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255473}
- dir-3.html/dir-5.html: These are approximative verifications of overall RTL directionality using "covering rectangles". Export them with a a specific font in order to make them a bit more robust. For dir-5.html we use scripts-spaceafterscript3000.woff and adjust the rects accordingly but the test might change later depending on the outcome of w3c/mathml-core#217. - dir-4-ref.html: Removed (the test was removed in bug 1783995). Differential Revision: https://phabricator.services.mozilla.com/D199702 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876684 gecko-commit: eb00222e557742d5a6c66534f38345ddf71deaa5 gecko-reviewers: emilio
- mo-movablelimits-dynamic.html: This is the same as the WPT test mathml/presentation-markup/operators/mo-movablelimits-dynamic.html - munderover-accentunder-dynamic/munderover-accent-dynamic: There does not seem to be any equivalent tests. It's possible the tests need some refinement to make sure the attributes have an effect on this testcase, but for now it's safe to just export them as is. Differential Revision: https://phabricator.services.mozilla.com/D199738 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876684 gecko-commit: 607f0b698ed2f1632afa2168bb416bfdeb2a5e25 gecko-reviewers: emilio
Much like we suppress most (all?) other block-level scrollframes, see: https://searchfox.org/mozilla-central/rev/5c4a45eb17423373ecb71aea9819d41a6231613e/layout/base/nsCSSFrameConstructor.cpp#4392-4394 Otherwise we try to fragment a scrollframe, not good. Differential Revision: https://phabricator.services.mozilla.com/D200370 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1877591 gecko-commit: 24dacb4bb526be404f5617ca9413a4a12c5314b7 gecko-reviewers: dholbert
This patch adds a test, which was accidentally lost while renaming in PS8 of crrev.com/c/5251158. The content is the same as the one in PS7. Bug: 1520442 Change-Id: Ie9b72f63a9560b803f7cd3120c45cc3071302405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5261043 Reviewed-by: Morten Stenshorne <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255506}
This fixes a bug where dispatching an InvokeEvent with a null invoker will cause a nullptr exception as it tries to retarget the Invoker based on the currentTarget. The fix returns early nullptr if invoker is a nullptr, which also skips the CHECK_EQ on eventPhase(), as just guarding the Retarget call would skip to this check which would cause the check to fail if invoker was retrieved during the bubbling phase. Bug: 1511341 Change-Id: I6e0e250a47466a502daeb8ab32335ff1521edc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260418 Commit-Queue: Joey Arhar <[email protected]> Auto-Submit: Keith Cirkel <[email protected]> Reviewed-by: David Baron <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255591}
All element reflection IDL attributes must have their attribute name return true in IsElementReflectionAttribute, or else the attribute and javascript getter will not be kept in sync. This patch adds the popovertarget and anchor attributes to that list and also adds a DCHECK to make sure that when the generated IDL code sets an element attribute, that attribute is listed in IsElementReflectionAttribute. Fixed: 1523410 Change-Id: I919153b894884507530b2bb219c4cbf7327780a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260611 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255605}
The timeout is the likely culprit. If the test flakes again, we should put the TestExpectations entry back and re-investigate. Bug: 1430215 Change-Id: I27d450e37920072d04018b1e191b8e7efb1867dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5262097 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255607}
Intent-to-ship: https://groups.google.com/u/2/a/chromium.org/g/blink-dev/c/S67zJ1AYW2U Bug: 1466250 Change-Id: Idfa99b35a900440beb53b1c6a7a7af8bee2a66c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5261861 Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255674}
This reverts commit 572074cb06425797e7e110511db405134cf67e2f. Reason for revert: caused regression bug: crbug.com/1521614 Original change's description: > Remove empty closed paths > > As discussed in the github issue, > whatwg/html#1079, it's generally agreed to > skip drawing line caps for closed paths. This is a follow up cl of: > https://chromium-review.googlesource.com/c/chromium/src/+/4864061. > > In this cl, it verifies if each closed path is empty, then it removes > the empty closed subpaths from path. As the subpaths are removed, the > corresponding line caps are skipped. > > Bug: 644067 > > Change-Id: I14c5c4819a31eb9249d01574ff1b5c60826c3b9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916516 > Commit-Queue: Yi Xu <[email protected]> > Reviewed-by: Jean-Philippe Gravel <[email protected]> > Reviewed-by: Justin Novosad <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1247735} Bug: 644067 Change-Id: I33ecfd76574d6f60e6f8c471a38183f87757e3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258624 Reviewed-by: Aaron Krajeski <[email protected]> Reviewed-by: Jean-Philippe Gravel <[email protected]> Commit-Queue: Yi Xu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255711}
This test doesn't actually work since it references an idl file which isn't defined. I manually verified that the CustomStateSet idl is already tested by external/wpt/html/dom/idlharness.https.html so there is no need for this separate test file anymore. Change-Id: If4aca93159724cdb9e7d007933635a2d55d06f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5253030 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Stephen McGruer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255766}
This patch forbids nested <button>s and <datalist>s to avoid setting kInSelectMode while we are technically still in a <button> or <datalist>. This patch also replaces a call to SetInsertionMode() with ResetInsertionModeAppropriately() and moves it after processing the end tag in order to avoid ending up in kInSelectMode when there is not actually an open <select> tag. The clusterfuzz crash didn't have a minimal repro but I manually verified that the crash does not repro with this patch. Bug: 1511354 Fixed: 1519396 Change-Id: I4358973b36925ea0862f4050f27f804d2676288c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5254124 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255770}
Per spec: https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering this should be in the UA stylesheet: address, blockquote, center, div, figure, figcaption, footer, form, header, hr, legend, listing, main, p, plaintext, pre, summary, xmp, article, aside, h1, h2, h3, h4, h5, h6, hgroup, nav, section, search, table, caption, colgroup, col, thead, tbody, tfoot, tr, td, th, dir, dd, dl, dt, menu, ol, ul, li, bdi, output, [dir=ltr i], [dir=rtl i], [dir=auto i] { unicode-bidi: isolate; } To avoid breakage, I just added the elements, and not the [dir] related rules, nor did I change the <bdo> rules. Firefox and WebKit are both making the same change: https://bugzilla.mozilla.org/show_bug.cgi?id=1874033 https://bugs.webkit.org/show_bug.cgi?id=267887 The stylesheet change interacts with the code at [1], and that code also handles some of the cases such as [dir=auto] and bdi/bdo. I will clean up some of the code at [1] in a followup CL. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/html_element.cc;l=344-363;drc=20fecf94cc2226674dfefd698e96d8d44485b19c Fixed: 1520671 Change-Id: Icaa32061efc59d963942b0629327bb596ac224ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5240082 Auto-Submit: Mason Freed <[email protected]> Reviewed-by: David Baron <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1255819}
I could not find any usage of this constant in the test. This is a drive-by cleanup of work to remove CORB code. Bug: 324418206 Change-Id: I506def1e4e10fe7223cc00caed8504656c53b321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273194 Commit-Queue: Daniel Vogelheim <[email protected]> Reviewed-by: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261751}
In CL:5247315, we set the content attribute to values 'true'/'false'
during the IDL setter. However, it was raised in spec dicussions that
the content attribute should just reflect the value set by the IDL
setter to match the default reflection logic of enumerated attributes.
E.g. when setting element.writingSuggestions = "invalid-value"
Previously:
getAttribute("writingsuggestions") == "true"
Now:
getAttribute("writingsuggestions") == "invalid-value"
Bug: 1513953
Change-Id: Iebb008de9cda661509bab6cfe1ffa97566986639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5297548
Reviewed-by: Sanket Joshi <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Reviewed-by: Dan Clark <[email protected]>
Commit-Queue: Stephanie Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1261866}
In order for these to work we need to actually shim user interactions and permission grants. The prior code only works for content_shell. One thing we can't seem to test now is what happens if cookies are partitioned. That doesn't seem to be enabled here and the way we can fake that for content_shell doesn't work. Looking to fix: https://wpt.fyi/results/storage-access-api?label=experimental&label=master&aligned Using the commands from: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/run_web_platform_tests.md Change-Id: I122258d0cc9f3449d3e84526b689f86a92d84333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301177 Auto-Submit: Ari Chivukula <[email protected]> Reviewed-by: Kyra Seevers <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261875}
Per the new-new consensus, attachShadow will only verify that the existing declarative shadow root's `mode` matches the newly requested `mode`: whatwg/html#10107 (comment) Bug: 41483062,325598615 Change-Id: Ie3bac4ec297c0b85c40b45495e9c823dd47cb49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5283935 Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Di Zhang <[email protected]> Reviewed-by: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1262014}
…nt which is required to be on the top layer. Differential Revision: https://phabricator.services.mozilla.com/D197650 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1872778 gecko-commit: f65c6d83b6924a1df3a858a1203d9a0acd123d88
…-tests#43801) * [webnn] Add tests for WebNN API constant (fillSequence) * [webnn] Update test data with negative start * [webnn] Update test data for integer test cases * [webnn] Add a test with negative integer step
As per the HTML spec. Differential Revision: https://phabricator.services.mozilla.com/D201906 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1868316 gecko-commit: 4eab1cec8f078b42355ff8472faef06c6487fe06 gecko-reviewers: dholbert
This removes the manual global tracking which was only correctly hooked up for windows, but missed other global types, especially workers. Because GlobalTeardownObserver is reliably notified of when to disconnect, it is able to "safely" hold a raw non-owning pointer which simplifies cycle collection somewhat. (That design decision was originally part of DOMEventTargetHelper which GlobalTeardownObserver was extracted from.) It also provides a pre-cached window getter. This test includes a WPT test that reliably fails without the fix and passes with the fix. Differential Revision: https://phabricator.services.mozilla.com/D201188 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879259 gecko-commit: def4a6f94713c0d0e4b2808d42dd486520c00a60 gecko-reviewers: dom-storage-reviewers, janv
…ld clear the explicitly set attr-element. Differential Revision: https://phabricator.services.mozilla.com/D201711 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879001 gecko-commit: 6f0ebcced75f999a360fdd4f2e00d66fe811dc84 gecko-reviewers: emilio
…b-platform-tests#44643) WebKit will reject the single colon syntax in `getComputedStyle()` because it is invalid.
…3751) Add tests to ensure that the Ed25519 Verify implementation performs checks for small-order keys and signature's point R. Additionally, add tests for mixed-order points, and check that the cofactorless (unbatched) verification equation is used, as required by the latest draft.
Upstream added a new test which would trigger MISSING-LINK error. Bug: None Change-Id: I556ce91304fdcc09b616a505dfa7bf149a53e7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5308374 Commit-Queue: Weizhong Xia <[email protected]> Auto-Submit: Weizhong Xia <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1262474}
Per the HTML-AAM spec, the contextual role restriction only applies to the <footer> element, not to any other instance of the ARIA contentinfo role. Even though <footer> maps to contentinfo, contentinfo does not necessarily map to <footer>. Thus, this test is incorrect. Differential Revision: https://phabricator.services.mozilla.com/D201928 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878363 gecko-commit: 5c67e50b735884a798f9a9c29b9117a1fc696ebe gecko-reviewers: nlapre
Asserting the "and also MUST include all currently available formats" https://www.rfc-editor.org/rfc/rfc8829.html#name-subsequent-offers See w3c/webrtc-pc#2938 BUG=None Change-Id: I7748ea94e58ba93cdf1043ee0235a7e560e260e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293377 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1262601}
Preparation for adding MutationObserver tests to the same file. See the following commits.
…n `setAttribute` is called As requested in <w3c/trusted-types#425 (comment)>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in w3c/trusted-types#425 (comment).