-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft easy adding walls issue: #77 #78
Conversation
For documentation on how to use functions such as Issue #79 has been created for this. |
I am looking at it. Can you allow changes by other maintainers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your enthousiasm.
Why didn't you use the add_obstacle function that was already there?
Than if-clauses can be done entirely in MotionPlanningEnv?
I think that this would be neater.
urdfenvs/urdfCommon/urdf_env.py
Outdated
@@ -108,11 +107,39 @@ def check_box( | |||
return msg_ext | |||
|
|||
|
|||
def check_shape_dim(dim: np.ndarray, shape_type: str, dim_len: int, default: np.ndarray) -> np.ndarray: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check_shape_dim suggests that it returns a boolean, but it actually returns a filtered shape dimension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been renamed to filter_shape_dim( )
Why didn't you use the add_obstacle function that was already there? Additionally:
is a lot more code then: Than if-clauses can be done entirely in MotionPlanningEnv? |
I agree with keeping it like this for the moment. |
I modified a couple of things in the documentation and removed the mutable default arguments in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that I didn't update the docs everywhere. Nice catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Could you open the issue regarding moving this into MotionPlanningScenes?
#92 has been created for this. |
Ft easy adding walls issue: maxspahn#77
I changed my mind about createMultiBody vs. adding urdf files
It comes in handy to change the dimensions of the object to add. This is doable with createMultiBody because it
only can add 'simple' shapes to the environment. Eventually adding obstacles/shapes/walls in both ways is preferred. Because:
createMultiBody makes simple shapes, but the dimensions can easily be changed. good for adding walls
adding urdf files makes more complex obstacles. good for more interesting obstacles
The documentation will be updated