[MM-54465] Remove lowercase call when checking path names #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
added
2: Dev Review
marianunez
reviewed
Sep 13, 2023
| @@ -201,7 +201,7 @@ export function validateV0ConfigData(data: ConfigV0) { | |||
| function cleanURL(url: string): string { | |||
| let updatedURL = url; | |||
| if (updatedURL.includes('\\')) { | |||
| updatedURL = updatedURL.toLowerCase().replace(/\\/gi, '/'); | |||
There was a problem hiding this comment.
Are there any cases where later we compare the server url that it make break now if it's there any casing mistmatch?
There was a problem hiding this comment.
Shouldn't be. We were doing this to make sure the path name was lower case, and this function is mostly to get rid of double slashes. We do a lower case when we compared host and origin in other parts of the code.
esarafianou
approved these changes
Sep 14, 2023
larkox
approved these changes
Sep 14, 2023
amyblais
added
4: Reviews Complete
devinbinnie
removed
the
Do Not Merge
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/desktop
that referenced
this pull request
Sep 15, 2023
mattermost-build
added
CherryPick/Done
devinbinnie
added a commit
that referenced
this pull request
Sep 15, 2023
) (cherry picked from commit 128d15a) Co-authored-by: Devin Binnie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we were checking if two URLs were equal, we were assuming that like the URL's origin, the pathname was also not case-sensitive. This is not the case so it was possible that two URLs with different URLs could be considered equal.
This PR removed the call to
toLowerCase()to make sure we respect case sensitivity for path names.Ticket Link
https://mattermost.atlassian.net/browse/MM-54465