[MM-54465] Remove lowercase call when checking path names (#2831) (#2834

) (cherry picked from commit 128d15a) Co-authored-by: Devin Binnie <[email protected]>
mattermost · Sep 15, 2023 · e0f3493 · e0f3493
1 parent 4f266a3
commit e0f3493
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/src/common/Validator.ts b/src/common/Validator.ts
@@ -201,7 +201,7 @@ export function validateV0ConfigData(data: ConfigV0) {
 function cleanURL(url: string): string {
     let updatedURL = url;
     if (updatedURL.includes('\\')) {
-        updatedURL = updatedURL.toLowerCase().replace(/\\/gi, '/');
+        updatedURL = updatedURL.replace(/\\/gi, '/');
     }
     return updatedURL;
 }

diff --git a/src/common/utils/url.test.js b/src/common/utils/url.test.js
@@ -25,14 +25,9 @@ jest.mock('common/views/View', () => ({
 
 describe('common/utils/url', () => {
     describe('getFormattedPathName', () => {
-        it('should format all to lower case', () => {
-            const unformattedPathName = '/aAbBbB/cC/DdeR/';
-            expect(getFormattedPathName(unformattedPathName)).toBe('/aabbbb/cc/dder/');
-        });
-
         it('should add trailing slash', () => {
             const unformattedPathName = '/aAbBbB/cC/DdeR';
-            expect(getFormattedPathName(unformattedPathName)).toBe('/aabbbb/cc/dder/');
+            expect(getFormattedPathName(unformattedPathName)).toBe('/aAbBbB/cC/DdeR/');
         });
     });
     describe('parseURL', () => {

diff --git a/src/common/utils/url.ts b/src/common/utils/url.ts
@@ -6,7 +6,7 @@ import {isHttpsUri, isHttpUri, isUri} from 'valid-url';
 import buildConfig from 'common/config/buildConfig';
 import {customLoginRegexPaths, nonTeamUrlPaths, CALLS_PLUGIN_ID} from 'common/utils/constants';
 
-export const getFormattedPathName = (pn: string) => (pn.endsWith('/') ? pn.toLowerCase() : `${pn.toLowerCase()}/`);
+export const getFormattedPathName = (pn: string) => (pn.endsWith('/') ? pn : `${pn}/`);
 export const parseURL = (inputURL: string | URL) => {
     if (inputURL instanceof URL) {
         return inputURL;

diff --git a/src/main/windows/callsWidgetWindow.test.js b/src/main/windows/callsWidgetWindow.test.js
@@ -241,7 +241,7 @@ describe('main/windows/callsWidgetWindow', () => {
         beforeEach(() => {
             urlUtils.parseURL.mockImplementation((url) => new URL(url));
             urlUtils.getFormattedPathName.mockImplementation((pn) => {
-                return pn.endsWith('/') ? pn.toLowerCase() : `${pn.toLowerCase()}/`;
+                return pn.endsWith('/') ? pn : `${pn}/`;
             });
             callsWidgetWindow.options = {
                 callID: 'test-call-id',