Better permanent restriction protection #3662
Annotations
7 errors and 1 warning
|
Run lint:
l1-contracts/contracts/governance/L2AdminFactory.sol#L29
GC: [_additionalRestrictions] argument on Function [deployAdmin] could be [calldata] if it's not being updated
|
|
Run lint:
l1-contracts/contracts/governance/L2AdminFactory.sol#L34
GC: Found [ .length ] property in Loop condition. Suggestion: assign it to a variable
|
|
Run lint:
l1-contracts/contracts/governance/L2AdminFactory.sol#L34
GC: For [ i ] variable, increment/decrement by 1 using: [ ++variable ] to save gas
|
|
Run lint:
l1-contracts/contracts/governance/L2AdminFactory.sol#L37
GC: Found [ .length ] property in Loop condition. Suggestion: assign it to a variable
|
|
Run lint:
l1-contracts/contracts/governance/L2AdminFactory.sol#L37
GC: For [ i ] variable, increment/decrement by 1 using: [ ++variable ] to save gas
|
|
Run lint:
l1-contracts/contracts/governance/PermanentRestriction.sol#L63
Visibility modifier must be first in list of modifiers
|
|
Run lint
Process completed with exit code 1.
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Loading