Skip to content
System contracts CI

Better permanent restriction protection #3662

Sign in to view logs

Better permanent restriction protection

Better permanent restriction protection #3662

Triggered via pull request September 25, 2024 10:28
@StanislavBreadlessStanislavBreadless
opened #820
sb-better-governance-protection
Status Failure
Total duration 4m 55s
Artifacts –

system-contracts-ci.yaml

on: pull_request
build
4m 0s
build
lint
1m 19s
lint
check-hashes
35s
check-hashes
test-bootloader
0s
test-bootloader
test-contracts
0s
test-contracts
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 3 warnings
lint: l1-contracts/contracts/governance/L2AdminFactory.sol#L29
GC: [_additionalRestrictions] argument on Function [deployAdmin] could be [calldata] if it's not being updated
lint: l1-contracts/contracts/governance/L2AdminFactory.sol#L34
GC: Found [ .length ] property in Loop condition. Suggestion: assign it to a variable
lint: l1-contracts/contracts/governance/L2AdminFactory.sol#L34
GC: For [ i ] variable, increment/decrement by 1 using: [ ++variable ] to save gas
lint: l1-contracts/contracts/governance/L2AdminFactory.sol#L37
GC: Found [ .length ] property in Loop condition. Suggestion: assign it to a variable
lint: l1-contracts/contracts/governance/L2AdminFactory.sol#L37
GC: For [ i ] variable, increment/decrement by 1 using: [ ++variable ] to save gas
lint: l1-contracts/contracts/governance/PermanentRestriction.sol#L63
Visibility modifier must be first in list of modifiers
lint
Process completed with exit code 1.
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache/save@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
check-hashes
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache/restore@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/