refactor(protobuf): relocate types from zksync_protobuf_config (BFT-407)
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoffranca
changed the title
ProtoRepr traitProtoRepr trait (BFT-407)
brunoffranca
approved these changes
Feb 13, 2024
pompon0
reviewed
Feb 14, 2024
pompon0
reviewed
Feb 14, 2024
pompon0
approved these changes
Feb 14, 2024
|
Added a few more types/utils. |
moshababo
changed the title
ProtoRepr trait (BFT-407)zksync_protobuf_config (BFT-407)
6 tasks
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this pull request
Feb 27, 2024
…ing (BFT-407) (#1047) ## What ❔ Adding `zksync_types::Transaction` support for cannonical-protobuf encoding. Existing `serde` encoding remains intact—protobuf is used only for the construction of the consensus block payload. Closing [BFT-407](https://linear.app/matterlabs/issue/BFT-407/optimize-rlp-encoding-of-transaction-struct). --- In addition, `zksync_consensus_*` dependencies were updated to include matter-labs/era-consensus#66, and the relocated types were adjusted. --- <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ * Better composability with the consensus block payload * Support for potential version control / backward compatibility * Having a deterministic + unique scheme <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`. --------- Co-authored-by: perekopskiy <[email protected]>
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this pull request
Feb 28, 2024
…ing (BFT-407) (#1047) ## What ❔ Adding `zksync_types::Transaction` support for cannonical-protobuf encoding. Existing `serde` encoding remains intact—protobuf is used only for the construction of the consensus block payload. Closing [BFT-407](https://linear.app/matterlabs/issue/BFT-407/optimize-rlp-encoding-of-transaction-struct). --- In addition, `zksync_consensus_*` dependencies were updated to include matter-labs/era-consensus#66, and the relocated types were adjusted. --- <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ * Better composability with the consensus block payload * Support for potential version control / backward compatibility * Having a deterministic + unique scheme <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`. --------- Signed-off-by: Danil <[email protected]> Co-authored-by: perekopskiy <[email protected]> Co-authored-by: koloz193 <[email protected]> Co-authored-by: Fedor Sakharov <[email protected]> Co-authored-by: Danil <[email protected]> Co-authored-by: Ivan Schasny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Relocating
ProtoReprzksync_protobuf_config(zksync-era) intozksync_protobuf(era-consensus). This PR just adds them to the new location.ProtoReprread_required_reprencode<P: ProtoRepr>decode<P: ProtoRepr>RandomValueGenValueWhy ❔
To make them usable as a shared utility.