-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(dal):
zksync_types::Transaction
to use protobuf for wire encod…
…ing (BFT-407) (#1047) ## What ❔ Adding `zksync_types::Transaction` support for cannonical-protobuf encoding. Existing `serde` encoding remains intact—protobuf is used only for the construction of the consensus block payload. Closing [BFT-407](https://linear.app/matterlabs/issue/BFT-407/optimize-rlp-encoding-of-transaction-struct). --- In addition, `zksync_consensus_*` dependencies were updated to include matter-labs/era-consensus#66, and the relocated types were adjusted. --- <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ * Better composability with the consensus block payload * Support for potential version control / backward compatibility * Having a deterministic + unique scheme <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`. --------- Signed-off-by: Danil <[email protected]> Co-authored-by: perekopskiy <[email protected]> Co-authored-by: koloz193 <[email protected]> Co-authored-by: Fedor Sakharov <[email protected]> Co-authored-by: Danil <[email protected]> Co-authored-by: Ivan Schasny <[email protected]>
- Loading branch information
1 parent
c8bbeac
commit ee94bee
Showing
44 changed files
with
644 additions
and
232 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.