Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breakage with aiohttp>=3.10.0 when using GCM and an HTTP proxy #395

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix breakage with aiohttp>=3.10.0 when using GCM and an HTTP proxy #395

merged 4 commits into from
Oct 2, 2024

Commits on Oct 2, 2024

  1. Only call aiohttp.ClientSession from async func 

    Since `aiohttp==3.10.0`, instantiating `aiohttp.ClientSession` must be
done from an async function. Calling this from a non-async function
relied on deprecated behaviour in Python, which broke in recent
releases.
aio-libs/aiohttp#8555 (comment)
explains the situation.

Rather than pin `aiohttp` to an older version, let's just fix the
behaviour.
    @anoadragon453
    anoadragon453 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c7a280e View commit details
    Browse the repository at this point in the history

  2. newsfile

    @anoadragon453
    anoadragon453 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f85dd9b View commit details
    Browse the repository at this point in the history

  3. just use create, an async constructor

    @anoadragon453
    anoadragon453 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0cab5e6 View commit details
    Browse the repository at this point in the history

  4. Add a comment explaining why we do this in create

    @anoadragon453
    anoadragon453 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6a3f447 View commit details
    Browse the repository at this point in the history