Fix breakage with aiohttp>=3.10.0 when using GCM and an HTTP proxy
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
changed the title
aiohttp.ClientSession from async funcaiohttp>=3.10.0 by calling aiohttp.ClientSession from an async function
anoadragon453
force-pushed
the
anoa/aiohttp_client_session
branch
from
9981314
to
13a4d75
Compare
anoadragon453
changed the title
aiohttp>=3.10.0 by calling aiohttp.ClientSession from an async functionaiohttp>=3.10.0 when using GCM and an HTTP proxy
anoadragon453
force-pushed
the
anoa/aiohttp_client_session
branch
2 times, most recently
from
4667760
to
81ec6d3
Compare
Since `aiohttp==3.10.0`, instantiating `aiohttp.ClientSession` must be done from an async function. Calling this from a non-async function relied on deprecated behaviour in Python, which broke in recent releases. aio-libs/aiohttp#8555 (comment) explains the situation. Rather than pin `aiohttp` to an older version, let's just fix the behaviour.
anoadragon453
force-pushed
the
anoa/aiohttp_client_session
branch
from
81ec6d3
to
f85dd9b
Compare
erikjohnston
reviewed
Oct 2, 2024
erikjohnston
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
aiohttp==3.10.0, instantiatingaiohttp.ClientSessionmust be done from an async function. Calling this from a non-async function relied on deprecated behaviour in Python, which broke in recent releases. aio-libs/aiohttp#8555 (comment) explains the situation.We would do this when using GCM + an HTTP proxy:
sygnal/sygnal/gcmpushkin.py
Lines 213 to 217 in 345aa61
Rather than pin
aiohttpto an older version, let's just fix the behaviour. Supersedes #394.