Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API errors #4652

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Improve API errors #4652

wants to merge 2 commits into from

Conversation

Leo-Besancon
Copy link
Contributor

@Leo-Besancon Leo-Besancon commented Feb 22, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Notes:

  • We kept the same behaviour as with send_operation, that if one request is invalid in the Vec of requests, then the whole call throws.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.78%. Comparing base (df156f3) to head (2ca579c).

Files Patch % Lines
massa-api/src/public.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4652   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve caller_address usage in read_only API Throw an error when sender does not exists on the ledger
2 participants