Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#38] [Chore] UI Integration Testing - Question page and Completion page #89

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[#38] [Chore] UI Integration Testing - Question page and Completion page #89

merged 2 commits into from
Sep 14, 2023

Conversation

manh-t
Copy link
Owner

@manh-t manh-t commented Jul 25, 2023

Close #38

What happened 👀

  • Add the integration test for Question page.
  • Add the integration test for Question Complete page

Insight 📝

N/A

Proof Of Work 📹

image

@manh-t manh-t added this to the 0.7.0 milestone Jul 25, 2023
@manh-t manh-t requested a review from hoangmirs July 25, 2023 09:02
@manh-t manh-t self-assigned this Jul 25, 2023
@manh-t
Copy link
Owner Author

manh-t commented Jul 25, 2023 •
edited
Loading

🚀 Deployed on https://6502bfb0bc538d33159c08bb--manh-react-survey.netlify.app

@manh-t manh-t temporarily deployed to pull request July 25, 2023 09:04 Inactive
@manh-t
Copy link
Owner Author

manh-t commented Jul 25, 2023 •
edited
Loading

Messages
📖 Coverage is a little low, take a look

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/../MultiInputs/index.tsx (6/11) 55% (6/11) 55% (2/5) 40% (0/0) NaN%
src/../TextArea/index.tsx (5/8) 63% (5/8) 63% (1/2) 50% (0/2) 0%
src/tests/error.ts (2/3) 67% (2/3) 67% (1/2) 50% (1/3) 33%
src/../AppSlider/index.tsx (3/4) 75% (3/4) 75% (1/2) 50% (3/3) 100%
src/../Rating/index.tsx (16/20) 80% (16/20) 80% (6/6) 100% (4/13) 31%
src/screens/Question/index.tsx (35/40) 88% (35/40) 88% (12/13) 92% (20/28) 71%
src/../Survey/index.ts (23/26) 88% (23/26) 88% (6/7) 86% (0/0) NaN%
src/../Answer/index.tsx (34/38) 89% (34/38) 89% (7/8) 88% (20/33) 61%
src/../Content/index.tsx (14/15) 93% (14/15) 93% (7/7) 100% (6/9) 67%
src/helpers/deserializer.ts (17/18) 94% (17/18) 94% (7/7) 100% (10/12) 83%
src/../MultiChoice/index.tsx (19/20) 95% (19/20) 95% (7/8) 88% (7/8) 88%
src/../v1/requestManager.ts (19/20) 95% (19/20) 95% (6/6) 100% (3/5) 60%
src/App.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
src/index.tsx (3/3) 100% (3/3) 100% (0/0) NaN% (0/0) NaN%
src/../Authentication/index.ts (4/4) 100% (4/4) 100% (2/2) 100% (0/0) NaN%
Other (50 more) (344/344) 100% (344/344) 100% (130/132) 98% (104/110) 95%
Total (547/577) 95% (547/577) 95% (196/208) 94% (178/226) 79%

Generated by 🚫 dangerJS against 3c85d61

@manh-t manh-t added the @0.7.0 label Jul 27, 2023
@manh-t manh-t force-pushed the feature/22-confirm-dialog branch 4 times, most recently from 7f353e3 to b194256 Compare September 14, 2023 02:44
@manh-t manh-t force-pushed the feature/38-integration-test-question-page-and-question-complete-page branch from d111e8c to bb86d5a Compare September 14, 2023 02:48
@manh-t manh-t temporarily deployed to pull request September 14, 2023 02:50 Inactive
@manh-t manh-t force-pushed the feature/38-integration-test-question-page-and-question-complete-page branch from bb86d5a to 69db1d3 Compare September 14, 2023 03:04
@manh-t manh-t temporarily deployed to pull request September 14, 2023 03:05 Inactive
nvminhtue
nvminhtue approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@nvminhtue nvminhtue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

congratz 🥳

@manh-t manh-t temporarily deployed to pull request September 14, 2023 08:09 Inactive
Base automatically changed from feature/22-confirm-dialog to develop September 14, 2023 08:26
@manh-t manh-t merged commit d493c4b into develop Sep 14, 2023
4 checks passed
@manh-t manh-t deleted the feature/38-integration-test-question-page-and-question-complete-page branch September 14, 2023 08:27
@manh-t manh-t mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangmirs hoangmirs hoangmirs approved these changes

@nvminhtue nvminhtue nvminhtue approved these changes

@tyrro tyrro Awaiting requested review from tyrro tyrro is a code owner

Assignees

@manh-t manh-t

Labels
type: chore @0.7.0
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

[Chore] UI Integration Testing - Question page and Completion page
3 participants
@manh-t @hoangmirs @nvminhtue