Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 0.7.0 #90

Merged
merged 31 commits into from
Sep 14, 2023
Merged

Release - 0.7.0 #90

merged 31 commits into from
Sep 14, 2023

Conversation

manh-t
Copy link
Owner

@manh-t manh-t commented Jul 26, 2023 •
edited
Loading

@manh-t manh-t added this to the 0.7.0 milestone Jul 26, 2023
@manh-t manh-t requested a review from hoangmirs July 26, 2023 04:07
@manh-t manh-t self-assigned this Jul 26, 2023
@manh-t manh-t added the @0.7.0 label Jul 27, 2023
manh-t and others added 25 commits September 8, 2023 14:48
@manh-t
[CHORE] Bump version to 0.7.0
3c0fd42
@manh-t
Merge pull request #81 from manh-t/chore/bump-version-to-0.7.0
c671ad8 
[CHORE] Bump version to 0.7.0
@manh-t
[#24] Create NPS component
6fad3d6
@manh-t
[#24] Use fabricator for test data
2b7ff1c
@manh-t
[#24] Remove redundant flex-row
bd8c056
@manh-t
[#24] Add comment to explain the verification in the test
ff160bc
@manh-t
Merge pull request #82 from manh-t/feature/24-ui-nps-component
d4c4f30 
[#24] [UI] As a user, I can see the NPS component in the Question page
@manh-t
[#31] Implement the backend POST submit survey
22f79e6
@manh-t
[#30] Fill the data into the Question page
cd0f75b
@manh-t
[#30] Add more test cases
0df20fe
@manh-t
[#30] Fix convert string to enum for question displayType and update …
c68c7a7 
…test to use fabricator
@manh-t
[#30] Remove redundant code
9d2af08
@manh-t
[#30] Remove useEffect in components
40ba64a
@manh-t
[#30] Create a function to handle onValueChanged and onValuesChanged
6991c5f
@manh-t
Merge pull request #83 from manh-t/feature/31-backend-submit-survey
37bf717 
[#31] [Backend] As a user, I can submit the answers for the survey
@manh-t
[#30] Fix CI failed
29a92e8
@manh-t
Merge pull request #84 from manh-t/feature/30-integrate-question-page
7551322 
[#30] Fill the data into the Question page
@manh-t
[#32] Navigate to survey completion screen after submitting the surve…
b7da4c6 
…y successfully
@manh-t
[#32] Update after rebasing
a71d26a
@manh-t
[#32] Optimize code a bit
dba62af
@manh-t
[#32] Create function inside useEffect
f968500
@manh-t
[#32] Create a reusable function for toast error
7ac6657
@manh-t
[#33] Implement Question Complete page
11d2ddf
@manh-t
Merge pull request #85 from manh-t/feature/32-submit-answers-for-the-…
fd2de21 
…survey

[#32] [Integrate] As a user, I can submit the answers for the survey
@manh-t
Merge pull request #87 from manh-t/feature/33-ui-question-complete-page
5f2ba6f 
[#33] [#34] As a user, I can see the Completion page
manh-t and others added 6 commits September 14, 2023 09:44
@manh-t
Copy link
Owner Author

manh-t commented Sep 14, 2023

🚀 Deployed on https://6502c4d039a87134c76c0c42--manh-react-survey.netlify.app

@manh-t
Copy link
Owner Author

manh-t commented Sep 14, 2023

Messages
📖 Coverage is a little low, take a look

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/../MultiInputs/index.tsx (6/11) 55% (6/11) 55% (2/5) 40% (0/0) NaN%
src/../TextArea/index.tsx (5/8) 63% (5/8) 63% (1/2) 50% (0/2) 0%
src/tests/error.ts (2/3) 67% (2/3) 67% (1/2) 50% (1/3) 33%
src/../AppSlider/index.tsx (3/4) 75% (3/4) 75% (1/2) 50% (3/3) 100%
src/../Rating/index.tsx (16/20) 80% (16/20) 80% (6/6) 100% (4/13) 31%
src/screens/Question/index.tsx (35/40) 88% (35/40) 88% (12/13) 92% (20/28) 71%
src/../Survey/index.ts (23/26) 88% (23/26) 88% (6/7) 86% (0/0) NaN%
src/../Answer/index.tsx (34/38) 89% (34/38) 89% (7/8) 88% (20/33) 61%
src/../Content/index.tsx (14/15) 93% (14/15) 93% (7/7) 100% (6/9) 67%
src/helpers/deserializer.ts (17/18) 94% (17/18) 94% (7/7) 100% (10/12) 83%
src/../MultiChoice/index.tsx (19/20) 95% (19/20) 95% (7/8) 88% (7/8) 88%
src/../v1/requestManager.ts (19/20) 95% (19/20) 95% (6/6) 100% (3/5) 60%
src/App.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
src/index.tsx (3/3) 100% (3/3) 100% (0/0) NaN% (0/0) NaN%
src/../Authentication/index.ts (4/4) 100% (4/4) 100% (2/2) 100% (0/0) NaN%
Other (50 more) (344/344) 100% (344/344) 100% (130/132) 98% (104/110) 95%
Total (547/577) 95% (547/577) 95% (196/208) 94% (178/226) 79%

Generated by 🚫 dangerJS against d493c4b

@manh-t manh-t marked this pull request as ready for review September 14, 2023 08:35
nvminhtue
nvminhtue approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@nvminhtue nvminhtue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳🥳

@manh-t manh-t merged commit 4051d39 into main Sep 14, 2023
4 checks passed
@manh-t manh-t deleted the release/0.7.0 branch September 14, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangmirs hoangmirs hoangmirs approved these changes

@nvminhtue nvminhtue nvminhtue approved these changes

@tyrro tyrro Awaiting requested review from tyrro tyrro is a code owner

Assignees

@manh-t manh-t

Labels
type: chore @0.7.0
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manh-t @hoangmirs @nvminhtue