Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#33] [#34] As a user, I can see the Completion page #87

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[#33] [#34] As a user, I can see the Completion page #87

merged 1 commit into from
Sep 14, 2023

Conversation

manh-t
Copy link
Owner

@manh-t manh-t commented Jul 24, 2023 •
edited
Loading

Close #33
Close #34

What happened 👀

  • Add react-lottie-player to play the lottie animation.
  • Create the Question Complete screen.
  • After the animation ends, we navigates to Dashboard screen after one second.

Insight 📝

The unittest is failed after using react-lottie-player package. I fixed it by adding jest-canvas-mock to setupTest.ts. Ref

Proof Of Work 📹

Screen.Recording.2023-07-24.at.14.26.32.mov

@manh-t manh-t added this to the 0.7.0 milestone Jul 24, 2023
@manh-t manh-t requested a review from hoangmirs July 24, 2023 07:56
@manh-t manh-t self-assigned this Jul 24, 2023
@manh-t manh-t changed the title [#33] [UI] As a user, I can see the Completion page [#33] [#34] As a user, I can see the Completion page Jul 24, 2023
@manh-t
Copy link
Owner Author

manh-t commented Jul 24, 2023 •
edited
Loading

🚀 Deployed on https://65012f348625642d04d8449f--manh-react-survey.netlify.app

@manh-t manh-t temporarily deployed to pull request July 24, 2023 07:57 Inactive
@manh-t
Copy link
Owner Author

manh-t commented Jul 24, 2023 •
edited
Loading

Messages
📖 Coverage is a little low, take a look

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/../Survey/action.ts (4/10) 40% (4/10) 40% (2/6) 33% (0/0) NaN%
src/../MultiInputs/index.tsx (6/11) 55% (6/11) 55% (2/5) 40% (0/0) NaN%
src/../TextArea/index.tsx (5/8) 63% (5/8) 63% (1/2) 50% (0/2) 0%
src/../Complete/index.tsx (5/8) 63% (5/8) 63% (1/4) 25% (0/2) 0%
src/routes/index.tsx (4/6) 67% (4/6) 67% (0/1) 0% (0/0) NaN%
src/tests/error.ts (2/3) 67% (2/3) 67% (1/2) 50% (1/3) 33%
src/../Survey/index.ts (18/26) 69% (18/26) 69% (4/7) 57% (0/0) NaN%
src/../AppSlider/index.tsx (3/4) 75% (3/4) 75% (1/2) 50% (3/3) 100%
src/screens/Question/index.tsx (27/36) 75% (27/36) 75% (8/11) 73% (16/28) 57%
src/../Rating/index.tsx (16/20) 80% (16/20) 80% (6/6) 100% (4/13) 31%
src/../Answer/index.tsx (34/38) 89% (34/38) 89% (7/8) 88% (20/33) 61%
src/../Content/index.tsx (14/15) 93% (14/15) 93% (7/7) 100% (6/9) 67%
src/helpers/deserializer.ts (17/18) 94% (17/18) 94% (7/7) 100% (10/12) 83%
src/../MultiChoice/index.tsx (19/20) 95% (19/20) 95% (7/8) 88% (7/8) 88%
src/../v1/requestManager.ts (19/20) 95% (19/20) 95% (6/6) 100% (3/5) 60%
Other (48 more) (316/316) 100% (316/316) 100% (119/120) 99% (95/101) 94%
Total (509/559) 91% (509/559) 91% (179/202) 89% (165/219) 75%

Generated by 🚫 dangerJS against 11d2ddf

@manh-t manh-t added the @0.7.0 label Jul 27, 2023
@manh-t manh-t force-pushed the feature/32-submit-answers-for-the-survey branch 4 times, most recently from 908abee to dba62af Compare September 13, 2023 02:59
@manh-t manh-t force-pushed the feature/33-ui-question-complete-page branch from 5b3e544 to 1e3be18 Compare September 13, 2023 03:35
@manh-t manh-t temporarily deployed to pull request September 13, 2023 03:37 Inactive
@manh-t manh-t force-pushed the feature/33-ui-question-complete-page branch from 1e3be18 to 11d2ddf Compare September 13, 2023 03:38
@manh-t manh-t temporarily deployed to pull request September 13, 2023 03:40 Inactive
nvminhtue
nvminhtue approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@nvminhtue nvminhtue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Base automatically changed from feature/32-submit-answers-for-the-survey to develop September 13, 2023 09:58
@manh-t manh-t merged commit 5f2ba6f into develop Sep 14, 2023
4 checks passed
@manh-t manh-t deleted the feature/33-ui-question-complete-page branch September 14, 2023 02:14
@manh-t manh-t mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangmirs hoangmirs hoangmirs approved these changes

@nvminhtue nvminhtue nvminhtue approved these changes

@tyrro tyrro Awaiting requested review from tyrro tyrro is a code owner

Assignees

@manh-t manh-t

Labels
type: feature @0.7.0
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

[Integrate] As a user, I can see the Completion page [UI] As a user, I can see the Completion page
3 participants
@manh-t @hoangmirs @nvminhtue