[#30] Fill the data into the Question page #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage in All Files
|
manh-t
force-pushed
the
feature/30-integrate-question-page
branch
from
7893715
to
762934a
Compare
manh-t
force-pushed
the
feature/31-backend-submit-survey
branch
2 times, most recently
from
b4d8567
to
da6188c
Compare
manh-t
force-pushed
the
feature/30-integrate-question-page
branch
2 times, most recently
from
cea1c44
to
1e925a5
Compare
manh-t
force-pushed
the
feature/31-backend-submit-survey
branch
from
da6188c
to
22f79e6
Compare
manh-t
force-pushed
the
feature/30-integrate-question-page
branch
from
ae7e948
to
c68c7a7
Compare
manh-t
commented
Sep 8, 2023
| @@ -12,7 +12,7 @@ const ElevatedButton = ({ children, isFullWidth, ...rest }: ElevatedButtonProps) | |||
| 'bg-white text-black-chinese font-bold text-regular tracking-survey-tight rounded-[10px] focus:outline-none focus:shadow-outline h-14'; | |||
|
|
|||
| return ( | |||
| <button type="button" className={classNames(DEFAULT_CLASS_NAMES, { 'w-full': isFullWidth })} {...rest}> | |||
| <button type="button" className={classNames(DEFAULT_CLASS_NAMES, { 'w-full': isFullWidth, 'px-8': !isFullWidth })} {...rest}> | |||
There was a problem hiding this comment.
Add some padding when the button width is wrap-content
manh-t
force-pushed
the
feature/30-integrate-question-page
branch
from
beb64a6
to
8e26642
Compare
manh-t
force-pushed
the
feature/30-integrate-question-page
branch
from
8e26642
to
40ba64a
Compare
nvminhtue
reviewed
Sep 11, 2023
Base automatically changed from
feature/31-backend-submit-survey
to
develop
September 11, 2023 10:59
hoangmirs
approved these changes
Sep 12, 2023
nvminhtue
approved these changes
Sep 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #30
What happened 👀
MultiInputscomponent to add multiple inputs according to the number of answers.Answercomponent to display the corresponding components according todisplayType.questionIdas it's redundant.Insight 📝
N/A
Proof Of Work 📹
Screen.Recording.2023-09-11.at.11.00.40.mov