check if entity exists before accessing

[LaserWitch]

I've run into a few panics with world access if you happen to hold on to entity values between frames. I'm not certain this is the ideal way to handle them, so feel free to suggest changes or go with an alternate implementation if desired.

[makspll]

Great catch! Would you be okay adding similar checks where we use w.entity or w.entity_mut. Much appreciated!

[LaserWitch]

Great catch! Would you be okay adding similar checks where we use w.entity or w.entity_mut. Much appreciated!

Yeah, I'll do a search and see how many other places I can add it in.

I'm honestly tempted to try to implement an option or result style construct in lua, perhaps leverage multiple value return, but I think I can experiment with that a bit further down stream for the time being.

[makspll]

Yeah, I'll do a search and see how many other places I can add it in.

Thanks!

I'm honestly tempted to try to implement an option or result style construct in lua, perhaps leverage multiple value return, but I think I can experiment with that a bit further down stream for the time being.

I've considered something like this in the past, although I've stuck with the mlua convention of converting None -> nil and Error -> Runtime Error, while creating proxy types for things like Vec when maintaining pass-by-reference behavior's.

[LaserWitch]

I've been lost in some other weeds the past week but I'll see if I can get this done this weekend.

[LaserWitch]

I have some more bases covered now. There's some other things that look like potential cases that could be checked, but I wouldn't really want to mess with them without first having a test case that is known to fail, and building those tests cases is not something I'm up for doing at the moment

[makspll]

Looks good, if we need any more checks anywhere else we can add later. Thanks!

[LaserWitch]

Looks like I've finally made CI happy. Not sure why it says I dismissed the review above, that must have been something automatic.

[makspll]

Yeah it's automatic, might disable that as the message looks quite confusing.