Small cleaning up + Fix for crash when looping through empty Vec

[zwazel]

This pull request cleans the Rhai side of the project up a bit.

• Removed a second get_children that didn't even work
• fixed the get_parent, before it wasn't found by Scripts, presumably because not the correct World was asked for (&ScriptWorld instead of ScriptWorld). Also made it return a Entity if a parent was found, and a i32 of value -1 if not, instead of Option, as that isnt really supported by Rhai.
• added an additional check for accessing an entity in the reload_script as the game often crashed there. This adds on check if entity exists before accessing #68
• Also made a partial fix for Crash when trying to loop through empty Vec #86. As the app no longer crashes, but we still get an error in the console (better documented in the issue itself).
  • is now fully fixed
  • closes Crash when trying to loop through empty Vec #86

[makspll]

Great catches, just a few comments

[zwazel]

I suggest we move the existing Wrapper example into lua, as it only really shows how to work with Lua.
I'm working on the example for Rhai right now, so we can test the fixes

[zwazel]

btw while working with the Wrappers in Rhai, i noticed that i always have to manually implement RhaiCopy, even though it's completely empty.

#[derive(Resource, Reflect, Default, Clone, Debug)]
#[reflect(Resource, RhaiProxyable)]
pub struct MyThing {
    usize: usize,
    string: String,
    array: Vec<usize>,
}

impl RhaiCopy for MyThing {}

Is this wanted or an oversight?

[zwazel]

As i'm working on the wrapper example for rhai, i noticed following thing:
When I Reflect on RhaiProxyable, I no longer can access the values of my Struct. seen in: c282ada
When I don't use RhaiProxyable, everything works fine. as seen in: 59ac562

Am I misunderstanding the need for RhaiProxyable?

[makspll]

Some more discussion, and minor changes

[makspll]

As i'm working on the wrapper example for rhai, i noticed following thing: When I Reflect on RhaiProxyable, I no longer can access the values of my Struct. seen in: c282ada When I don't use RhaiProxyable, everything works fine. as seen in: 59ac562

Am I misunderstanding the need for RhaiProxyable?

So the discussion above might shed some more light on this but let me know if you are still confused. Basically if you don't register RhaiProxyable yourself, you will receive a ReflectedValue type object, which means you are operating using pure reflection, and have no function support.

Registering it yourself is needed when you need a custom proxy type which has custom methods and behaviours attached. But because Rhai doesn't have support for generating those nicely it's not easilly available here yet as seen in lua.

The need for RhaiCopy arises from the automatic implementation for RhaiProxyable which assumes your type is its own proxy and that it is converted into this proxy by copying, hence the name of the trait. This lets you register all Rhai goodies on your type in your APIProvider and use them that way. But of course since you are not using ReflectedValue anymore you lose the automatically generated getters for reflected fields.

Hope this makes sense

[zwazel]

So this pull request should be good now, applied all your suggestions. And am looking forward for the wrapper rewrite ;)

[makspll]

LGTM, thanks again, great work!