Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim's Airport Challenge #2500

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions lib/airport.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
require 'airport'
require 'plane'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add a Constant variable for capacity to reduce use of magic numbers.

class Airport

attr_accessor :hanger

def initialize(capacity = 5)

@capacity = capacity
@hanger = []

end

def random_weather

rand(10)

end

def can_take_off?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you made two separate methods for 'can_take_off?' and 'can_land?' you've made it easy to understand.


if random_weather <= 3
fail "It's blowin' a gale out there, hold your horses"
end

end

def take_off(plane)

if @hanger.include?(plane)
@hanger.delete(plane)
else
fail "That plane is not available for take off"
end

end

def can_land?

if random_weather <= 3
fail "It's blowin' a gale out there, hold your horses"
end

end

def land(plane)

if full?
fail "The airport is full, please wait"
elsif @hanger.include?(plane)
fail "That plane has already landed"
else
@hanger << plane
end

end

def full?

@hanger.count >= @capacity

end

end
6 changes: 6 additions & 0 deletions lib/plane.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
require 'airport'
require 'plane'

class Plane

end
77 changes: 77 additions & 0 deletions spec/airport_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
require 'airport'
require 'plane'

describe Airport do

it "lands plane when instructed" do

plane = Plane.new
subject.land(plane)
expect(subject.hanger).to include plane

end

it "takes off from airport when instructed, and is no longer at the airport" do

plane = Plane.new
subject.hanger << plane
subject.take_off(plane)
expect(subject.hanger).not_to include plane

end

it "checks whether the airport hanger is full" do

plane = Plane.new
5.times { subject.hanger << plane }
expect(subject.full?).to eq true

end

it "prevents landing when the aiport hanger is full" do

plane = Plane.new
5.times { subject.hanger << plane }
expect { subject.land(plane) }.to raise_error("The airport is full, please wait")

end

it "prevents take off when weather is stormy" do

plane = Plane.new
allow(subject).to receive(:random_weather) { 3 }
expect { subject.can_take_off? }.to raise_error("It's blowin' a gale out there, hold your horses")

end

it "prevents landing when weather is stormy" do

plane = Plane.new
allow(subject).to receive(:random_weather) { 3 }
expect { subject.can_land? }.to raise_error("It's blowin' a gale out there, hold your horses")

end

it "random_weather should generate a random number between 1 and 10" do

expect(subject.random_weather).to be < 11
expect(subject.random_weather).to be > 0

end

it "attempting to take off a plane that isn't present should raise an error" do

plane = Plane.new
expect { subject.take_off(plane) }.to raise_error("That plane is not available for take off")

end

it "attempting to land a plane that has already landed should raise an error" do

plane = Plane.new
subject.hanger << plane
expect { subject.land(plane) }.to raise_error("That plane has already landed")

end

end
13 changes: 13 additions & 0 deletions spec/plane_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
require 'airport'
require 'plane'

describe Plane do

it "Instances of Plane should be true" do

plane = Plane.new
expect(plane).to eq plane

end

end