Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim's Airport Challenge #2500

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

timbo-graham
Copy link

@timbo-graham timbo-graham commented Apr 23, 2022

Your name

Tim Graham

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

  • [+] User story 1: "I want to instruct a plane to land at an airport"
  • [+] User story 2: "I want to instruct a plane to take off from an airport and confirm that it is no longer in the airport"
  • [+] User story 3: "I want to prevent landing when the airport is full"
  • [+] User story 4: "I would like a default airport capacity that can be overridden as appropriate"
  • [+] User story 5: "I want to prevent takeoff when weather is stormy"
  • [+] User story 6: "I want to prevent landing when weather is stormy"

README checklist

Does your README contains instructions for

  • [+] how to install,
  • [+] how to run,
  • [+] and how to test your code?

Here is a pill that can help you write a great README!

@timbo-graham timbo-graham changed the title Tim' Tim's Airport Challenge Apr 23, 2022

end

def can_take_off?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you made two separate methods for 'can_take_off?' and 'can_land?' you've made it easy to understand.

@@ -0,0 +1,65 @@
require 'airport'
require 'plane'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add a Constant variable for capacity to reduce use of magic numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants