refacto: pass new CI

.github/workflows/pull-request.yml

@@ -7,8 +7,7 @@ on:
     branches: [main]
 
 concurrency:
-  group:
-    pr-checks-${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  group: pr-checks-${{ github.workflow }}-${{ github.head_ref || github.run_id }}
   cancel-in-progress: true
 
 jobs:

.github/workflows/rust-check.yml

@@ -17,8 +17,7 @@ jobs:
         with:
           path: |
             target/release/deoxys
-          key:
-            ${{ runner.os }}-cargo-${{ hashFiles('Cargo.lock') }}-${{
+          key: ${{ runner.os }}-cargo-${{ hashFiles('Cargo.lock') }}-${{
             github.run_id }}
           restore-keys: |
             ${{ runner.os }}-cargo-${{ hashFiles('Cargo.lock') }}

.markdownlint.json

@@ -0,0 +1,10 @@
+{
+  "MD033": false,
+  "MD041": false,
+  "MD045": false,
+  "MD003": false,
+  "MD013": {
+    "code_blocks": false,
+    "line_length": 135
+  }
+}

CHANGELOG.md

@@ -2,6 +2,7 @@ git # Deoxys Changelog
 
 ## Next release
 
+- refactor: pass new CI
 - fix(workflows): Fix deoxys CI
 - feat(rpc): add_invoke_tx, add_deploy_account_tx, add_declare_tx
 - feat(rpc): tx_receipt, re-execute tx

Cargo.toml

@@ -244,6 +244,7 @@ mc-mapping-sync = { path = "crates/client/mapping-sync" }
 mc-rpc = { path = "crates/client/rpc" }
 mc-rpc-core = { path = "crates/client/rpc-core" }
 mc-storage = { path = "crates/client/storage" }
+mc-deoxys = { path = "crates/client/deoxys" }
 
 # Madara runtime
 madara-runtime = { path = "crates/runtime" }

crates/client/db/src/bonsai_db.rs

@@ -56,9 +56,9 @@ pub struct BonsaiDb<B: BlockT> {
 
 pub fn key_type(key: &DatabaseKey) -> KeyType {
     match key {
-        DatabaseKey::Trie(_) => return KeyType::Trie,
-        DatabaseKey::Flat(_) => return KeyType::Flat,
-        DatabaseKey::TrieLog(_) => return KeyType::TrieLog,
+        DatabaseKey::Trie(_) => KeyType::Trie,
+        DatabaseKey::Flat(_) => KeyType::Flat,
+        DatabaseKey::TrieLog(_) => KeyType::TrieLog,
     }
 }
 
@@ -119,7 +119,7 @@ impl<B: BlockT> BonsaiDatabase for &BonsaiDb<B> {
         let mut result = Vec::new();
 
         for pair in self.db.iter_with_prefix(column, prefix_slice) {
-            let pair = pair.map_err(|e| BonsaiDbError::from(e))?;
+            let pair = pair.map_err(BonsaiDbError::from)?;
             result.push((pair.0.into_vec(), pair.1));
         }
 

crates/client/db/src/db_opening_utils/mod.rs

@@ -27,6 +27,7 @@ use sp_database::Database;
 
 use crate::{DatabaseSettings, DatabaseSource, DbHash};
 
+#[allow(clippy::type_complexity)]
 pub(crate) fn open_database(
     config: &DatabaseSettings,
 ) -> Result<(Arc<dyn KeyValueDB>, Arc<dyn Database<DbHash>>), String> {
@@ -48,6 +49,7 @@ pub(crate) fn open_database(
     Ok(dbs)
 }
 
+#[allow(clippy::type_complexity)]
 pub fn open_kvdb_rocksdb(
     path: &Path,
     create: bool,

crates/client/mapping-sync/Cargo.toml

@@ -18,9 +18,9 @@ futures = { workspace = true, default-features = true }
 futures-timer = "3.0.2"
 log = { workspace = true, default-features = true }
 mc-db = { workspace = true }
-mc-sync = { workspace = true }
 mc-rpc-core = { workspace = true }
 mc-storage = { workspace = true }
+mc-sync = { workspace = true }
 mp-digest-log = { workspace = true }
 mp-felt = { workspace = true }
 mp-hashers = { workspace = true }

crates/client/rpc/Cargo.toml

@@ -23,9 +23,9 @@ pallet-starknet = { workspace = true, default-features = true }
 pallet-starknet-runtime-api = { workspace = true, default-features = true }
 # Madara client
 mc-db = { workspace = true }
-mc-sync = { workspace = true }
 mc-rpc-core = { workspace = true }
 mc-storage = { workspace = true }
+mc-sync = { workspace = true }
 # Substate primitives
 frame-support = { workspace = true }
 frame-system = { workspace = true }
@@ -43,8 +43,8 @@ sc-network-sync = { workspace = true }
 blockifier = { workspace = true, default-features = true }
 starknet-core = { workspace = true }
 starknet-ff = { workspace = true }
-starknet_api = { workspace = true, default-features = true }
 starknet-providers = { workspace = true }
+starknet_api = { workspace = true, default-features = true }
 # Others
 anyhow = { workspace = true }
 hex = { workspace = true, default-features = true }

crates/client/rpc/src/events/mod.rs

@@ -1,6 +1,3 @@
-#[cfg(test)]
-mod tests;
-
 use jsonrpsee::core::RpcResult;
 use log::error;
 use mc_rpc_core::utils::get_block_by_block_hash;
@@ -74,7 +71,7 @@ where
                 .collect()
         } else {
             starknet_block
-                .transactions_hashes::<H>(chain_id.into(), Some(starknet_block.header().block_number))
+                .transactions_hashes::<H>(chain_id, Some(starknet_block.header().block_number))
                 .map(FieldElement::from)
                 .collect()
         };
@@ -83,10 +80,10 @@ where
         // the txs hashes are found by the index of the ordered event
         let tx_hash_and_events: Vec<(Felt252Wrapper, _)> = starknet_block
             .events()
-            .into_iter()
+            .iter()
             .flat_map(|ordered_event| {
                 let tx_hash = block_txs_hashes[ordered_event.index() as usize];
-                ordered_event.events().into_iter().map(move |events| (tx_hash.into(), events.clone()))
+                ordered_event.events().iter().map(move |events| (tx_hash.into(), events.clone()))
             })
             .collect();