Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refacto: pass new CI #6

Merged
merged 7 commits into from
Mar 5, 2024
Merged

refacto: pass new CI #6

merged 7 commits into from
Mar 5, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Mar 5, 2024 •
edited
Loading

Pull Request type

  • Refactoring (no functional changes, no API changes)

What is the current behavior?

What is the new behavior?

  • Removal of unnecessary into() calls
  • Removal of unnecessary clone() calls and dereferencing when necessary
  • Change implementations Into into to From when not bidirectional
  • add `./.markdownlint.json' for CI

Does this introduce a breaking change?

🤷‍♂️

Other information

@jbcaron jbcaron requested a review from Trantorian1 March 5, 2024 16:41
Trantorian1
Trantorian1 requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the above issues.

crates/client/sync/src/l1.rs Show resolved Hide resolved
crates/primitives/contract/src/class.rs Show resolved Hide resolved
crates/primitives/contract/src/class.rs Outdated Show resolved Hide resolved
crates/primitives/transactions/src/from_broadcasted_transactions.rs Show resolved Hide resolved
@jbcaron jbcaron self-assigned this Mar 5, 2024
@antiyro antiyro merged commit 7d938f5 into madara-alliance:main Mar 5, 2024
5 of 6 checks passed
Mohiiit pushed a commit that referenced this pull request Oct 19, 2024
@akhercha
feat: Pragma ExEx (#6)
b2cdbfc 
* feat(pragma_exex): Pragma ExEx

* feat(pragma_exex): Enough context now
!

* feat(pragma_exex): CHANGELOG

* feat(pragma_exex): Pragma ExEx

* feat(pragma_exex):  available in ExExContext

* feat(pragma_exex): Cleaning

* feat(pragma_exex): Cleaning

* feat(pragma_exex): Cleaned ExEx

* feat(pragma_exex): Devnet config

* feat(pragma_exex): Max fee

* feat(pragma_exex): Renaming

* feat(pragma_exex): get feeds from contract!

* feat(pragma_exex): Smarter!

* feat(pragma_exex):

* feat(pragma_exex): logs

* feat(pragma_exex): Logs

* feat(pragma_exex): Interval constant

* feat(pragma_exex): Status & receipt

* feat(pragma_exex):

* feat(pragma_exex): Clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trantorian1 Trantorian1 Trantorian1 requested changes

@antiyro antiyro antiyro approved these changes

Assignees

@jbcaron jbcaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbcaron @antiyro @Trantorian1