Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calib update #1083

Merged
merged 73 commits into from
Aug 11, 2023
Merged
Changes from 60 commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
186abae
Added WIP Image Align for visualization
saching13 Aug 9, 2022
5113b6b
Working calibration with SYnc
saching13 Aug 10, 2022
fcc4f4c
added board config files
saching13 Aug 10, 2022
e52e734
Updated the ar0234 res
saching13 Aug 15, 2022
562d331
Updated mono in json
saching13 Aug 15, 2022
d9105b1
Added Output Scale factor and removed the orientation check
saching13 Aug 15, 2022
48cdb67
Fixed the osf
saching13 Aug 15, 2022
f177b01
Fixed capture issue with different names
saching13 Aug 15, 2022
507ede9
updated links translation
saching13 Aug 16, 2022
46f8b1f
WIP structure and vertical Stereo calibration
saching13 Aug 17, 2022
03766f3
Fixed flashing issues
saching13 Aug 19, 2022
84dd899
updatec req condfitions
saching13 Aug 22, 2022
16f6e28
added exception msg
saching13 Aug 22, 2022
7b81117
removed try catch and writing board names
saching13 Aug 22, 2022
1b356df
adding rect data
saching13 Aug 22, 2022
64d5828
Updated rectification flash
saching13 Aug 22, 2022
c9bc18e
Removed comments
saching13 Aug 24, 2022
38e6102
Added rotation to polygons
saching13 Sep 8, 2022
861f9e3
Polygon flex (#789)
saching13 Sep 12, 2022
00acebb
Modified the board file
saching13 Sep 14, 2022
63b5adb
added debugs
saching13 Sep 15, 2022
7372329
tweaked intrinsics in use
saching13 Sep 17, 2022
085b4a6
iterative method added but commented
saching13 Sep 17, 2022
6d3964a
cleanedup image sizes and better ep errors
saching13 Sep 30, 2022
1067cb2
Fixed config error
saching13 Oct 13, 2022
c452188
Tweaked replay
saching13 Dec 13, 2022
029aff0
Added optional rect from projection matrix
saching13 Dec 20, 2022
6f186a6
updated depthai version
saching13 Feb 20, 2023
9deb126
Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option
alex-luxonis Feb 20, 2023
691f680
Peripheral calibration - fisheye camera model (#952)
njezersek Feb 22, 2023
abc566e
Fix fiheye calibration rotated rectified image
njezersek Feb 23, 2023
d1054c5
new lines from corner to corners
saching13 Mar 3, 2023
9db8704
update calibration handler with cameraModel
saching13 Mar 23, 2023
4d9e428
WIP vermeer
Mar 24, 2023
3be4d44
Fix fisheye calibration
njezersek Mar 28, 2023
023db9c
Merge remote-tracking branch 'origin/peripheral_calibration' into per…
Mar 28, 2023
e0ae7d7
Fixes for RVC3
Apr 11, 2023
9645a5e
Add mouse trigger, save calibration, custom dataset options
Apr 18, 2023
185c2f7
Update depthai version
Apr 18, 2023
5f7e746
Add options for dataset custom path
Apr 19, 2023
6d74171
Add an option to manually specify the number of charucos
Apr 19, 2023
cfff50f
Fixed default dataset path
njezersek Apr 26, 2023
ed1a21d
Support for GRAY8 img type, fix scaling issues
njezersek May 3, 2023
316526a
Lower the threshold for synced frames
May 12, 2023
3a33796
Remove the CALIB_CHECK_COND
May 15, 2023
bc9f90d
Cleared old opencv dependencies versioning
saching13 May 17, 2023
53445f2
Peripheral calibration rvc3 (#1040)
saching13 May 27, 2023
e4e7bea
fixed the requirements.txt
saching13 May 29, 2023
8601c51
saving converge files
saching13 May 31, 2023
d5da79f
modified calibration parameters
saching13 Jun 14, 2023
469d6df
added json for no vertical testing
saching13 Jun 14, 2023
d7af1ad
Changes
MaticTonin Jun 22, 2023
4c04197
Adding_display_option
MaticTonin Jun 22, 2023
3bc52a9
Adding_display_option
MaticTonin Jun 22, 2023
33296e4
Changes
MaticTonin Jun 23, 2023
446699e
Merge branch 'calibration_rvc3'
MaticTonin Jun 23, 2023
b2717b4
Merge branch 'main' of https://github.com/luxonis/depthai
MaticTonin Jul 13, 2023
d8ef733
Merge
MaticTonin Jul 18, 2023
3fa3437
Adding changes in parameteres
MaticTonin Jul 20, 2023
86d35e3
Testing on OAK-D-PRO and small changes
MaticTonin Jul 20, 2023
18c828e
Change in rescale of text in combined images
MaticTonin Jul 22, 2023
25038f1
Adding the combinedCoverageimages
MaticTonin Jul 27, 2023
d2fdd0a
Merge branch 'main' of https://github.com/luxonis/depthai
MaticTonin Jul 27, 2023
4234a59
Update on calibrate.py
MaticTonin Jul 27, 2023
9f55bcd
Adding the submodules and calibration file
MaticTonin Jul 27, 2023
65df223
Path to depthai_calibtraion
MaticTonin Jul 27, 2023
1a17f19
Path to submodule
MaticTonin Jul 27, 2023
8b16e61
Adding output scale factor as arg
MaticTonin Jul 27, 2023
e213741
Merge of calib_update into main_Matic Tonin
MaticTonin Jul 27, 2023
029870f
Fixing traceLvl and timesync
MaticTonin Aug 4, 2023
4a1f482
Merge branch 'calib_update'
MaticTonin Aug 4, 2023
5850728
Merge branch 'main' of https://github.com/luxonis/depthai
MaticTonin Aug 4, 2023
2f0b3fe
Changed traceLevel as argument
MaticTonin Aug 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions calibrate.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,6 @@ def parse_args():
help="number of chessboard squares in Y direction in charuco boards.")
parser.add_argument("-rd", "--rectifiedDisp", default=True, action="store_false",
help="Display rectified images with lines drawn for epipolar check")
parser.add_argument("-drgb", "--disableRgb", default=False, action="store_true",
help="Disable rgb camera Calibration")
parser.add_argument("-slr", "--swapLR", default=False, action="store_true",
help="Interchange Left and right camera port.")
parser.add_argument("-m", "--mode", default=['capture', 'process'], nargs='*', type=str, required=False,
Expand All @@ -129,7 +127,7 @@ def parse_args():
parser.add_argument("-ih", "--invertHorizontal", dest="invert_h", default=False, action="store_true",
help="Invert horizontal axis of the camera for the display")
parser.add_argument("-ep", "--maxEpiploarError", default="0.7", type=float, required=False,
help="Sets the maximum epiploar allowed with rectification")
help="Sets the maximum epiploar allowed with rectification. Default: %(default)s")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this default set to.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is set to 0.7. Should I set it lower?

parser.add_argument("-cm", "--cameraMode", default="perspective", type=str,
required=False, help="Choose between perspective and Fisheye")
parser.add_argument("-rlp", "--rgbLensPosition", default=135, type=int,
Expand Down Expand Up @@ -160,7 +158,8 @@ def parse_args():
help="Set to trace the steps in calibration. Number from 1 to 5. If you want to display all, set trace number to 10.")
parser.add_argument('-edms', '--enableDebugMessageSync', default=False, action="store_true",
help="Display all the information in calibration.")

parser.add_argument('-mst', '--minSyncTimestamp', type=float, default=0.03,
help="Minimum time difference between pictures taken from different cameras. Default: %(default)s ")
options = parser.parse_args()

# Set some extra defaults, `-brd` would override them
Expand Down Expand Up @@ -616,7 +615,7 @@ def capture_images_sync(self):
prev_time = None
curr_time = None
self.display_name = "Image Window"
syncCollector = MessageSync(len(self.camera_queue), 0.3 ) # 3ms tolerance
syncCollector = MessageSync(len(self.camera_queue), self.args.minSyncTimestamp) # 3ms tolerance
syncCollector.enableDebugMessageSync = self.args.enableDebugMessageSync
self.mouseTrigger = False
while not finished:
Expand Down Expand Up @@ -903,7 +902,7 @@ def calibrate(self):
right_cam = result_config['cameras'][cam_info['extrinsics']['to_cam']]['name']
left_cam = cam_info['name']

epipolar_threshold = 0.6
epipolar_threshold = self.args.maxEpiploarError

if cam_info['extrinsics']['epipolar_error'] > epipolar_threshold:
color = red
Expand Down