Calib update #1083
Merged
Calib update #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Optimization and trace levels introduced WIP * tweaked parameters and updated tracelevel
* Make sure the same points are present on all images * Use initUndistortRectifyMap from fisheye calib
saching13
reviewed
Jul 21, 2023
| @@ -129,7 +127,7 @@ def parse_args(): | |||
| parser.add_argument("-ih", "--invertHorizontal", dest="invert_h", default=False, action="store_true", | |||
| help="Invert horizontal axis of the camera for the display") | |||
| parser.add_argument("-ep", "--maxEpiploarError", default="0.7", type=float, required=False, | |||
| help="Sets the maximum epiploar allowed with rectification") | |||
| help="Sets the maximum epiploar allowed with rectification. Default: %(default)s") | |||
There was a problem hiding this comment.
what is this default set to.?
There was a problem hiding this comment.
It is set to 0.7. Should I set it lower?
|
update this branch to be on-top of main |
saching13
suggested changes
Aug 5, 2023
saching13
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing the disableRGB,
adding the epipolarThreshold parameter and
minSyncTimestamp parameter for sync of images from different cameras.
Clearing the OAK-D-1 problem with stereo on one camera (line 791)