-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Coveralls bug #1100
Address Coveralls bug #1100
Conversation
…ons/OpenOversight into fix_test_coverage_error
Could you take a look at this build, @sea-kelp, and tell me if anything looks obviously wrong: https://github.com/lucyparsons/OpenOversight/actions/runs/9335574698/job/25695125327?pr=1100 It's linked to this PR: #1082 I'm also seeing that the branches have not been updated on here since April 17th: https://coveralls.io/github/lucyparsons/OpenOversight |
@michplunkett fixed - I think what happened is that the coverage file was being created by docker when setting up the bind mount, which gave it weird permissions. I haven't dug into the linked PR so not sure why that change in particular broke this workflow Can you check that the coverage has been uploaded successfully? |
The file is mounted from the host machine onto the container filesystem, so the file would need to be created on the host side |
Fixes issue
#1099
Description of Changes
Fixing the Coveralls upload bug.
Tests and Linting
develop
branch.pytest
passes on my local development environment.pre-commit
passes on my local development environment.