Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issue with coverage file not uploading #1099

Closed
michplunkett opened this issue May 4, 2024 · 1 comment · Fixed by #1100
Closed

Address issue with coverage file not uploading #1099

michplunkett opened this issue May 4, 2024 · 1 comment · Fixed by #1100
Assignees
@michplunkett
Labels
bug

Comments

@michplunkett
Copy link
Collaborator

What issue are you seeing?

It's somehow linked to this PR, #1082, but I'll hunt it down later.

Failed job: https://github.com/lucyparsons/OpenOversight/actions/runs/8952227770/job/24589381732
@michplunkett michplunkett self-assigned this May 4, 2024
@michplunkett michplunkett mentioned this issue May 22, 2024
Merged
3 tasks
@michplunkett michplunkett linked a pull request May 22, 2024 that will close this issue
Address Coveralls bug #1100
Merged
3 tasks
@michplunkett
Copy link
Collaborator Author

Here's the issue: #1100 (comment)

michplunkett added a commit that referenced this issue Jun 4, 2024
@michplunkett @sea-kelp
Address Coveralls bug (#1100)
5e0e0d7 
## Fixes issue
#1099

## Description of Changes
Fixing the Coveralls upload bug.

## Tests and Linting
 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.

<img width="1102" alt="Screenshot 2024-06-03 at 4 51 04 PM"
src="https://github.com/lucyparsons/OpenOversight/assets/5885605/b1067a79-8027-48cb-bfb9-fc4785e23c64">

---------

Co-authored-by: sea-kelp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michplunkett michplunkett

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address Coveralls bug lucyparsons/OpenOversight
1 participant
@michplunkett