Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-45722: CRITICAL logs on empty quantum graph #440

Merged
merged 4 commits into from
Aug 28, 2024
Merged

DM-45722: CRITICAL logs on empty quantum graph #440

merged 4 commits into from
Aug 28, 2024

Commits on Aug 28, 2024

  1. Remove Readme line that only applies to daf_butler.

    @kfindeisen
    kfindeisen committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    799fe71 View commit details
    Browse the repository at this point in the history

  2. Remove "other" from news fragment readme. 

    The "other" category was merged with "misc" in 2022.
    @kfindeisen
    kfindeisen committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    471c626 View commit details
    Browse the repository at this point in the history

  3. Demote initial ID query explanation to error. 

    Critical is not an appropriate level for informational logs, especially
since whether or not a failed query is truly critical (in the sense
that the program cannot continue) depends on the program.
    @kfindeisen
    kfindeisen committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e2fa2c8 View commit details
    Browse the repository at this point in the history

  4. Coalesce data ID query explanation into a single log. 

    Logging a single statement as multiple logs causes problems with Loki,
because each line may be rearranged or independently filtered. Logging
a single multiline message fixes this problem, without changing
behavior for console users.

Constructing the multiline message makes it impossible to defer string
evaluation, but for an error-level log this is unlikely to come up
in practice.
    @kfindeisen
    kfindeisen committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f6f0254 View commit details
    Browse the repository at this point in the history