DM-45722: CRITICAL logs on empty quantum graph #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
- Coverage 81.19% 81.15% -0.04%
==========================================
Files 96 96
Lines 10931 10937 +6
Branches 2086 2086
==========================================
+ Hits 8875 8876 +1
- Misses 1698 1703 +5
Partials 358 358 ☔ View full report in Codecov by Sentry. |
2 tasks
The "other" category was merged with "misc" in 2022.
Critical is not an appropriate level for informational logs, especially since whether or not a failed query is truly critical (in the sense that the program cannot continue) depends on the program.
Logging a single statement as multiple logs causes problems with Loki, because each line may be rearranged or independently filtered. Logging a single multiline message fixes this problem, without changing behavior for console users. Constructing the multiline message makes it impossible to defer string evaluation, but for an error-level log this is unlikely to come up in practice.
kfindeisen
force-pushed
the
tickets/DM-45722
branch
from
640d5d9
to
f6f0254
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demotes the explanation of empty quantum graph queries from critical to error (to avoid confusion with truly fatal errors that force termination), and also merges the explanation into a single multiline log (for compatibility with JSON/Loki output).
Checklist
doc/changes