Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test(e2e): Enable visual testing of rest of the components #1649

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Test(e2e): Enable visual testing of rest of the components #1649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions tests/e2e/demo-components-compare.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,7 @@ import { readdirSync } from 'fs';
import { formatPackageName, getServerUrl, takeScreenshot, waitForPageLoad } from '../helpers';

// Tests that are intentionally broken, but will be fixed in the future
const IGNORED_TESTS: string[] = [
'Accordion',
'Dropdown',
'Header',
'Icon',
'Spinner',
'Stack',
'Toast',
'UNSTABLE_Toggle',
'UNSTABLE_Truncate',
];
const IGNORED_TESTS: string[] = ['Header', 'Toast', 'UNSTABLE_Toggle'];

interface TestConfig {
packageDir: string;
Expand Down
Binary file modified tests/e2e/demo-components-compare.spec.ts-snapshots/accordion-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/e2e/demo-components-compare.spec.ts-snapshots/dropdown-chromium-linux.png
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh-uh 🙂
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a problem of this PR :)

It will solve itself when we merge #1648

And if I am seeing right the dropdown is not open in the screenshot so it won't change.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/e2e/demo-components-compare.spec.ts-snapshots/stack-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../demo-components-compare.spec.ts-snapshots/unstable-truncate-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading