Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test(e2e): Enable visual testing of rest of the components #1649

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested a review from a team as a code owner September 17, 2024 15:19
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 1c20db7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66ec484d5fb9a60008e525cd

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 1c20db7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66ec484d7338dd0008d10f1f
😎 Deploy Preview https://deploy-preview-1649--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 17, 2024

Coverage Status

coverage: 74.732% (-4.7%) from 79.452%
when pulling 1c20db7 on test/visual-tests
into 7d89994 on feat/v3-slider.

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DropdownPopover needs to be fixed (or maybe just re-enabled) for this to merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh-uh 🙂
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a problem of this PR :)

It will solve itself when we merge #1648

And if I am seeing right the dropdown is not open in the screenshot so it won't change.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2d42419 to 70fab2b Compare September 19, 2024 11:09
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 70fab2b to 8c59b37 Compare September 19, 2024 11:41
@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 19, 2024
@crishpeen crishpeen force-pushed the test/visual-tests branch 2 times, most recently from 113b15a to a7a8518 Compare September 19, 2024 14:23
Copy link
Contributor

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 7e531b9 to 7c9caf7 Compare September 19, 2024 15:48
@crishpeen crishpeen changed the base branch from integration/BC-v3-design-tokens to feat/v3-slider September 19, 2024 15:50
@crishpeen crishpeen merged commit 9ae7933 into feat/v3-slider Sep 19, 2024
23 checks passed
@crishpeen crishpeen deleted the test/visual-tests branch September 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants