-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test(e2e): Enable visual testing of rest of the components #1649
Conversation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DropdownPopover
needs to be fixed (or maybe just re-enabled) for this to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a problem of this PR :)
It will solve itself when we merge #1648
And if I am seeing right the dropdown is not open in the screenshot so it won't change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
2d42419
to
70fab2b
Compare
4e0eef6
to
b8f929f
Compare
70fab2b
to
8c59b37
Compare
b8f929f
to
81b05ec
Compare
113b15a
to
a7a8518
Compare
7138575
to
c3f52eb
Compare
a7a8518
to
65861b9
Compare
c3f52eb
to
7e531b9
Compare
65861b9
to
85fe458
Compare
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10943994371/artifacts/1953873276 |
7e531b9
to
7c9caf7
Compare
85fe458
to
1c20db7
Compare
Description
Additional context
Issue reference