clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964)

clang-tools-extra/docs/ReleaseNotes.rst

@@ -502,6 +502,12 @@ Changes in existing checks
   usages of ``std::string_view::compare``. Added a `StringLikeClasses` option
   to detect usages of ``compare`` method in custom string-like classes.
 
+- Improved :doc:`readability-redundant-smartptr-get
+  <clang-tidy/checks/readability/readability-redundant-smartptr-get>` identify
+  and fix redundant calls to the `get()` method on smart pointers. This
+  improves code readability and efficiency by removing unnecessary
+  dereferences.
+
 Removed checks
 ^^^^^^^^^^^^^^
 

clang-tools-extra/test/clang-tidy/checkers/readability/redundant-smartptr-get.cpp

@@ -1,5 +1,6 @@
 // RUN: %check_clang_tidy %s readability-redundant-smartptr-get %t
 
+
 #define NULL __null
 
 namespace std {
@@ -20,6 +21,46 @@ struct shared_ptr {
   explicit operator bool() const noexcept;
 };
 
+template <typename T>
+struct vector {
+  vector();
+  bool operator==(const vector<T>& other) const;
+  bool operator!=(const vector<T>& other) const;
+  unsigned long size() const;
+  bool empty() const;
+
+  // Basic iterator implementation for testing
+  struct iterator {
+    T* ptr;
+    iterator(T* p) : ptr(p) {}
+    T& operator*() { return *ptr; }
+    T* operator->() { return ptr; }
+    iterator& operator++() {
+      ++ptr;
+      return *this;
+    }
+    bool operator!=(const iterator& other) const { return ptr != other.ptr; }
+  };
+
+  iterator begin();
+  iterator end();
+
+  T* data;
+  unsigned long sz;
+};
+
+template <typename T>
+vector<T>::vector() : data(nullptr), sz(0) {}
+
+template <typename T>
+typename vector<T>::iterator vector<T>::begin() {
+  return iterator(data);
+}
+
+template <typename T>
+typename vector<T>::iterator vector<T>::end() {
+  return iterator(data + sz);
+}
 }  // namespace std
 
 struct Bar {
@@ -235,3 +276,13 @@ void Negative() {
   if (MACRO(x) == nullptr)
     ;
 }
+
+void test_redundant_get() {
+  std::vector<std::shared_ptr<int>> v;
+  auto f = [](int) {};
+  for (auto i = v.begin(); i != v.end(); ++i) {
+    f(*i->get());
+    // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: redundant get() call
+    // CHECK-FIXES: f(**i);
+  }
+}

libc/src/errno/CMakeLists.txt

@@ -18,7 +18,6 @@ add_entrypoint_object(
   SRCS
     libc_errno.cpp
   HDRS
-    errno.h
     libc_errno.h     # Include this
   COMPILE_OPTIONS
     ${full_build_flag}

libc/src/errno/libc_errno.cpp

@@ -7,7 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "libc_errno.h"
-#include "src/errno/errno.h"
 #include "src/__support/macros/config.h"
 
 // libc never stores a value; `errno` macro uses get link-time failure.
@@ -47,9 +46,6 @@ LIBC_ERRNO_MODE_SYSTEM
 
 namespace LIBC_NAMESPACE_DECL {
 
-// Define the global `libc_errno` instance.
-Errno libc_errno;
-
 #if LIBC_ERRNO_MODE == LIBC_ERRNO_MODE_UNDEFINED
 
 void Errno::operator=(int) {}
@@ -61,9 +57,7 @@ namespace {
 LIBC_THREAD_LOCAL int thread_errno;
 }
 
-extern "C" {
-int *__llvm_libc_errno() { return &thread_errno; }
-}
+extern "C" int *__llvm_libc_errno() noexcept { return &thread_errno; }
 
 void Errno::operator=(int a) { thread_errno = a; }
 Errno::operator int() { return thread_errno; }
@@ -74,9 +68,7 @@ namespace {
 int shared_errno;
 }
 
-extern "C" {
-int *__llvm_libc_errno() { return &shared_errno; }
-}
+extern "C" int *__llvm_libc_errno() noexcept { return &shared_errno; }
 
 void Errno::operator=(int a) { shared_errno = a; }
 Errno::operator int() { return shared_errno; }
@@ -93,4 +85,7 @@ Errno::operator int() { return errno; }
 
 #endif
 
+// Define the global `libc_errno` instance.
+Errno libc_errno;
+
 } // namespace LIBC_NAMESPACE_DECL

libc/src/errno/libc_errno.h

@@ -33,6 +33,8 @@
 
 namespace LIBC_NAMESPACE_DECL {
 
+extern "C" int *__llvm_libc_errno() noexcept;
+
 struct Errno {
   void operator=(int);
   operator int();