clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964) #98757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vm#97964) added a check to remove '->' if exists
|
@llvm/pr-subscribers-libc @llvm/pr-subscribers-clang-tidy Author: None (akshaykumars614) Changesadded a check to remove '->' if exists Full diff: https://github.com/llvm/llvm-project/pull/98757.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp b/clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp
index 8837ac16e8828..be52af77ae0a5 100644
--- a/clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp
@@ -164,6 +164,10 @@ void RedundantSmartptrGetCheck::check(const MatchFinder::MatchResult &Result) {
StringRef SmartptrText = Lexer::getSourceText(
CharSourceRange::getTokenRange(Smartptr->getSourceRange()),
*Result.SourceManager, getLangOpts());
+ // Check if the last two characters are "->" and remove them
+ if (SmartptrText.ends_with("->")) {
+ SmartptrText = SmartptrText.drop_back(2);
+ }
// Replace foo->get() with *foo, and foo.get() with foo.
std::string Replacement = Twine(IsPtrToPtr ? "*" : "", SmartptrText).str();
diag(GetCall->getBeginLoc(), "redundant get() call on smart pointer")
|
|
I am not sure if I need to write a test case for clang-tidy |
Yes, and release notes entry, |
|
can you tell me where to add test case and release notes entry |
|
I am new here |
EugeneZelenko
requested review from
PiotrZSL,
SimplyDanny,
5chmidti and
HerrCai0907
Tests: Release notes: |
This addresses the build error introduced in llvm#98287 where src/errno/errno.h is included instead of the system errno.h. We instead move the declaration to libc_errno.h.
The declaration must match the previous declaration in errno.h.
The definitions must match the previous declaration in errno.h.
…97964) Added test case and updated Release Notes
PiotrZSL
requested changes
Jul 15, 2024
…97964) Added test case and updated Release Notes
PiotrZSL
reviewed
Jul 17, 2024
clang-tools-extra/test/clang-tidy/checkers/readability/redundant-smartptr-get.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a check to remove '->' if exists
Fixes #97964