Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir] Fix missing FuncOps.h.inc #97885

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[mlir] Fix missing FuncOps.h.inc #97885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ add_mlir_dialect_library(MLIRAffineAnalysis
ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine

DEPENDS
MLIRFuncOpsIncGen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem like the right dependency to me: we should depend on the FuncDialect here. The IncGen targets are meant to be depending on by the dialects themselves.

You can also see this as a transitive dependency issue: you're skipping one step in the dependency chain.


LINK_LIBS PUBLIC
MLIRAffineDialect
MLIRAnalysis
Expand Down
Loading