[mlir] Fix missing FuncOps.h.inc #97885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-affine @llvm/pr-subscribers-mlir Author: Julien Schueller (jschueller) ChangesCloses #84568 Similar to #71691 /cc @tblah Full diff: https://github.com/llvm/llvm-project/pull/97885.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt b/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
index 61e49b0da8b2d..3a1996349dbed 100644
--- a/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
+++ b/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
@@ -8,6 +8,9 @@ add_mlir_dialect_library(MLIRAffineAnalysis
ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine
+ DEPENDS
+ MLIRFuncOpsIncGen
+
LINK_LIBS PUBLIC
MLIRAffineDialect
MLIRAnalysis
|
joker-eph
approved these changes
Jul 6, 2024
tblah
approved these changes
Jul 8, 2024
|
hello @tblah, maybe this could be merged ? |
Yeah this LGTM. Do you need help merging? |
|
yes, I dont have write access, could you please merge it ? |
joker-eph
reviewed
Jul 29, 2024
| @@ -8,6 +8,9 @@ add_mlir_dialect_library(MLIRAffineAnalysis | |||
| ADDITIONAL_HEADER_DIRS | |||
| ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine | |||
|
|
|||
| DEPENDS | |||
| MLIRFuncOpsIncGen | |||
There was a problem hiding this comment.
This does not seem like the right dependency to me: we should depend on the FuncDialect here. The IncGen targets are meant to be depending on by the dialects themselves.
You can also see this as a transitive dependency issue: you're skipping one step in the dependency chain.
banach-space
pushed a commit
to banach-space/llvm-project
that referenced
this pull request
Aug 7, 2024
Closes llvm#84568 Similar to llvm#71691 (reproduce with make -j1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84568
Similar to #71691 (reproduce with make -j1)
/cc @tblah