Fix/transaction crashes 240 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kcw-grunt <[email protected]>
Updated the timer intervals to allow more time for CPU to process Signed-off-by: kcw-grunt <[email protected]>
Signed-off-by: kcw-grunt <[email protected]>
version bump Signed-off-by: kcw-grunt <[email protected]>
kcw-grunt
added
the
🦟 critical bug
|
@hassanashraf92 will you convert this to a regular PR when you are comfortable? |
kcw-grunt
commented
May 10, 2024
There was a problem hiding this comment.
one of the dev leaks I have ignored so long @hassanashraf92
josikie
approved these changes
May 10, 2024
| @@ -24,8 +24,7 @@ enum BartyCrouch { | |||
| case turkey = "tr" | |||
| } | |||
|
|
|||
| static func translate(key: String, translations: [SupportedLanguage: String], comment _: String? = nil) -> String | |||
| { | |||
| static func translate(key: String, translations: [SupportedLanguage: String], comment _: String? = nil) -> String { | |||
| let typeName = String(describing: BartyCrouch.self) | |||
| let methodName = #function | |||
| } | ||
|
|
||
| static var isIPhone5: Bool { | ||
| return (UIScreen.main.bounds.size.height == 568.0) && (E.is32Bit) | ||
| } | ||
|
|
||
| static var isIPhoneX: Bool { | ||
| return (UIScreen.main.bounds.size.height == 812.0) | ||
| return UIScreen.main.bounds.size.height == 812.0 |
| static let is32Bit: Bool = { | ||
| MemoryLayout<Int>.size == MemoryLayout<UInt32>.size | ||
| }() | ||
| static let is32Bit: Bool = MemoryLayout<Int>.size == MemoryLayout<UInt32>.size |
There was a problem hiding this comment.
Is it allowed to compare Int data type to UInt32 data type in Swift?
| self.view.addSubview(self.blurView) | ||
| self.blurView.constrain(toSuperviewEdges: nil) | ||
| } | ||
| NotificationCenter.default.addObserver(forName: UIScene.willDeactivateNotification, object: nil, queue: nil) { _ in |
There was a problem hiding this comment.
what is _ in? I saw it many times the _ doesn't have comma, only space
| @@ -4,8 +4,8 @@ extension CGContext { | |||
| func addLineThrough(_ points: [(CGFloat, CGFloat)]) { | |||
| guard let first = points.first else { return } | |||
| move(to: CGPoint(x: first.0, y: first.1)) | |||
| points.dropFirst().forEach { | |||
| addLine(to: CGPoint(x: $0.0, y: $0.1)) | |||
| for point in points.dropFirst() { | |||
- Added enum Error for throws - Reset the PartnerData plist code - reset tags Signed-off-by: kcw-grunt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
Many users where experience a runtime crash during sync. It turns on the the syncing process is not at all performant and there was a very likely scenario where the user addresses would overflow the mem space during sync
This fix resolves and checks the data first