Fix/transaction crashes 240 (#243)

* Added note Signed-off-by: kcw-grunt <[email protected]> * fix: invalid data and incorrect subscripting in . * refactor: function inside WalletCoordinator * fix: tableview called in the background thread * auto linter changes Updated the timer intervals to allow more time for CPU to process Signed-off-by: kcw-grunt <[email protected]> * version bump Signed-off-by: kcw-grunt <[email protected]> * added privacy nutrition label version bump Signed-off-by: kcw-grunt <[email protected]> * Refactors - Added enum Error for throws - Reset the PartnerData plist code - reset tags Signed-off-by: kcw-grunt <[email protected]> --------- Signed-off-by: kcw-grunt <[email protected]> Co-authored-by: Hassan Ashraf <[email protected]>
litecoin-foundation · May 11, 2024 · 28cd0d5 · 28cd0d5
1 parent 9038d6e
commit 28cd0d5
Show file tree

Hide file tree

Showing 139 changed files with 6,006 additions and 779 deletions.
diff --git a/PrivacyInfo.xcprivacy b/PrivacyInfo.xcprivacy
@@ -0,0 +1,104 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>NSPrivacyTracking</key>
+	<false/>
+	<key>NSPrivacyCollectedDataTypes</key>
+	<array>
+		<dict>
+			<key>NSPrivacyCollectedDataTypeLinked</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypeTracking</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypePurposes</key>
+			<array>
+				<string></string>
+			</array>
+		</dict>
+		<dict>
+			<key>NSPrivacyCollectedDataType</key>
+			<string>NSPrivacyCollectedDataTypeOtherDiagnosticData</string>
+			<key>NSPrivacyCollectedDataTypeLinked</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypeTracking</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypePurposes</key>
+			<array>
+				<string></string>
+			</array>
+		</dict>
+		<dict>
+			<key>NSPrivacyCollectedDataType</key>
+			<string>NSPrivacyCollectedDataTypePerformanceData</string>
+			<key>NSPrivacyCollectedDataTypeLinked</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypeTracking</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypePurposes</key>
+			<array>
+				<string></string>
+			</array>
+		</dict>
+		<dict>
+			<key>NSPrivacyCollectedDataType</key>
+			<string>NSPrivacyCollectedDataTypeOtherUsageData</string>
+			<key>NSPrivacyCollectedDataTypeLinked</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypeTracking</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypePurposes</key>
+			<array>
+				<string></string>
+			</array>
+		</dict>
+		<dict>
+			<key>NSPrivacyCollectedDataType</key>
+			<string>NSPrivacyCollectedDataTypeDeviceID</string>
+			<key>NSPrivacyCollectedDataTypeLinked</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypeTracking</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypePurposes</key>
+			<array>
+				<string></string>
+			</array>
+		</dict>
+		<dict>
+			<key>NSPrivacyCollectedDataType</key>
+			<string>NSPrivacyCollectedDataTypeProductInteraction</string>
+			<key>NSPrivacyCollectedDataTypeLinked</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypeTracking</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypePurposes</key>
+			<array>
+				<string></string>
+			</array>
+		</dict>
+		<dict>
+			<key>NSPrivacyCollectedDataType</key>
+			<string>NSPrivacyCollectedDataTypeCrashData</string>
+			<key>NSPrivacyCollectedDataTypeLinked</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypeTracking</key>
+			<false/>
+			<key>NSPrivacyCollectedDataTypePurposes</key>
+			<array>
+				<string></string>
+			</array>
+		</dict>
+	</array>
+	<key>NSPrivacyAccessedAPITypes</key>
+	<array>
+		<dict>
+			<key>NSPrivacyAccessedAPIType</key>
+			<string>NSPrivacyAccessedAPICategoryUserDefaults</string>
+			<key>NSPrivacyAccessedAPITypeReasons</key>
+			<array>
+				<string>CA92.1</string>
+			</array>
+		</dict>
+	</array>
+</dict>
+</plist>
diff --git a/litewallet.xcodeproj/project.pbxproj b/litewallet.xcodeproj/project.pbxproj
diff --git a/litewallet.xcodeproj/project.xcworkspace/contents.xcworkspacedata b/litewallet.xcodeproj/project.xcworkspace/contents.xcworkspacedata
diff --git a/litewallet.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist b/litewallet.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>IDEDidComputeMac32BitWarning</key>
+	<true/>
+</dict>
+</plist>
diff --git a/litewallet/AddressFieldView.swift b/litewallet/AddressFieldView.swift
@@ -53,8 +53,7 @@ struct AddressFieldView: UIViewRepresentable {
 			parent = textField
 		}
 
-		func textField(_ textField: UITextField, shouldChangeCharactersIn range: NSRange, replacementString string: String) -> Bool
-		{
+		func textField(_ textField: UITextField, shouldChangeCharactersIn range: NSRange, replacementString string: String) -> Bool {
 			if let currentValue = textField.text as NSString? {
 				let proposedValue = currentValue.replacingCharacters(in: range, with: string) as String
 				parent.text = proposedValue

diff --git a/litewallet/AppDelegate.swift b/litewallet/AppDelegate.swift
@@ -12,8 +12,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
 	var resourceRequest: NSBundleResourceRequest?
 
-	func application(_ application: UIApplication, didFinishLaunchingWithOptions _: [UIApplication.LaunchOptionsKey: Any]?) -> Bool
-	{
+	func application(_ application: UIApplication, didFinishLaunchingWithOptions _: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
 		requestResourceWith(tag: ["initial-resources", "speakTag"]) { [self] in
 			// Ops
 			let startDate = Partner.partnerKeyPath(name: .litewalletStart)
@@ -77,13 +76,11 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 		applicationController.didEnterBackground()
 	}
 
-	func application(_: UIApplication, shouldAllowExtensionPointIdentifier _: UIApplication.ExtensionPointIdentifier) -> Bool
-	{
+	func application(_: UIApplication, shouldAllowExtensionPointIdentifier _: UIApplication.ExtensionPointIdentifier) -> Bool {
 		return false // disable extensions such as custom keyboards for security purposes
 	}
 
-	func application(_: UIApplication, open url: URL, options _: [UIApplication.OpenURLOptionsKey: Any] = [:]) -> Bool
-	{
+	func application(_: UIApplication, open url: URL, options _: [UIApplication.OpenURLOptionsKey: Any] = [:]) -> Bool {
 		return applicationController.open(url: url)
 	}
 

diff --git a/litewallet/ApplicationController.swift b/litewallet/ApplicationController.swift
@@ -273,8 +273,7 @@ class ApplicationController: Subscriber, Trackable {
 	func performBackgroundFetch() {
 		saveEvent("appController.performBackgroundFetch")
 		let group = DispatchGroup()
-		if let peerManager = walletManager?.peerManager, peerManager.syncProgress(fromStartHeight: peerManager.lastBlockHeight) < 1.0
-		{
+		if let peerManager = walletManager?.peerManager, peerManager.syncProgress(fromStartHeight: peerManager.lastBlockHeight) < 1.0 {
 			group.enter()
 			LWAnalytics.logEventWithParameters(itemName: ._20200111_DEDG)
 

diff --git a/litewallet/ArticleIds.swift b/litewallet/ArticleIds.swift
@@ -1,4 +1,5 @@
 import Foundation
+
 enum ArticleIds {
 	static let nothing = "nothing"
 }
diff --git a/litewallet/AssociatedObject.swift b/litewallet/AssociatedObject.swift
@@ -1,7 +1,6 @@
 import Foundation
 
-func associatedObject<T: AnyObject>(_ base: AnyObject, key: UnsafePointer<UInt8>, initialiser: () -> T) -> T
-{
+func associatedObject<T: AnyObject>(_ base: AnyObject, key: UnsafePointer<UInt8>, initialiser: () -> T) -> T {
 	if let associated = objc_getAssociatedObject(base, key) as? T {
 		return associated
 	}
@@ -10,8 +9,7 @@ func associatedObject<T: AnyObject>(_ base: AnyObject, key: UnsafePointer<UInt8>
 	return associated
 }
 
-func lazyAssociatedObject<T: AnyObject>(_ base: AnyObject, key: UnsafePointer<UInt8>, initialiser: () -> T?) -> T?
-{
+func lazyAssociatedObject<T: AnyObject>(_ base: AnyObject, key: UnsafePointer<UInt8>, initialiser: () -> T?) -> T? {
 	if let associated = objc_getAssociatedObject(base, key) as? T {
 		return associated
 	}

diff --git a/litewallet/BRAPIClient+Events.swift b/litewallet/BRAPIClient+Events.swift
@@ -28,7 +28,7 @@ private var emKey: UInt8 = 1
 extension BRAPIClient {
 	var events: EventManager? {
 		return lazyAssociatedObject(self, key: &emKey) {
-			return EventManager(adaptor: self)
+			EventManager(adaptor: self)
 		}
 	}
 
@@ -90,10 +90,10 @@ class EventManager {
 		defer { isSubscribed = true }
 
 		// slurp up app lifecycle events and save them as events
-		eventToNotifications.forEach { key, value in
+		for (key, value) in eventToNotifications {
 			NotificationCenter.default.addObserver(forName: value,
 			                                       object: nil,
-			                                       queue: self.queue,
+			                                       queue: queue,
 			                                       using: { [weak self] note in
 			                                       	self?.saveEvent(key)
 			                                       	if note.name == UIScene.didEnterBackgroundNotification {
@@ -121,7 +121,7 @@ class EventManager {
 
 	func down() {
 		guard isSubscribed else { return }
-		eventToNotifications.forEach { _, value in
+		for (_, value) in eventToNotifications {
 			NotificationCenter.default.removeObserver(self, name: value, object: nil)
 		}
 	}
@@ -163,8 +163,7 @@ class EventManager {
 				let dataToSerialize = myself.buffer.map { $0.dictionary }
 				guard JSONSerialization.isValidJSONObject(dataToSerialize) else { print("Invalid json"); return }
 				var error: NSError?
-				if JSONSerialization.writeJSONObject(dataToSerialize, to: outputStream, options: [], error: &error) == 0
-				{
+				if JSONSerialization.writeJSONObject(dataToSerialize, to: outputStream, options: [], error: &error) == 0 {
 					print("[EventManager] Unable to write JSON for events file: \(String(describing: error))")
 				} else {
 					print("[EventManager] saved \(myself.buffer.count) events to disk")
@@ -178,7 +177,7 @@ class EventManager {
 		queue.addOperation { [weak self] in
 			guard let myself = self else { return }
 			guard let files = try? FileManager.default.contentsOfDirectory(atPath: myself.unsentDataDirectory) else { return }
-			files.forEach { baseName in
+			for baseName in files {
 				let fileName = NSString(string: myself.unsentDataDirectory).appendingPathComponent("/\(baseName)")
 				do {
 					try FileManager.default.removeItem(atPath: fileName)