-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Blindex integration #83
Open
MichalSzreder
wants to merge
12
commits into
liquality:master
Choose a base branch
from
BlindexDAO:feat/blindex-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b8aec1f
Added blindex tokens to rsk swap
MSAdvisor 2906d4c
Merge branch 'master' into feat/blindex-integration
MSAdvisor 767b859
Merge pull request #1 from BlindexDAO/feat/blindex-integration
MichalSzreder ad72c80
Merge branch 'master' into feat/blindex-integration
MichalSzreder 14ea367
Merge branch 'liquality:master' into master
MichalSzreder 3f3402d
Merge branch 'feat/blindex-integration' of github.com:BlindexDAO/cryp…
MSAdvisor adaf3cb
Added bXAU and bGBP tokens for Blindex
MSAdvisor 9500509
Merge branch 'master' into feat/blindex-integration
MichalSzreder 3ed0303
Merge branch 'master' into feat/blindex-integration
MichalSzreder 1921b57
Added coingeckoid and matchingasset for xusd and eths tokens
MSAdvisor 9d7b3dc
Merge branch 'feat/blindex-integration' of github.com:BlindexDAO/cryp…
MSAdvisor f019859
Merge branch 'master' into feat/blindex-integration
MichalSzreder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2593,5 +2593,8 @@ | |
], | ||
"watafan.com": [ | ||
"rsk" | ||
], | ||
"app.blindex.io": [ | ||
"rsk" | ||
] | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichalSzreder let's add our new tokens: bXAU and bGBP on both PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If some of these tokens is listed on coingecko, can you add the property
"coinGeckoId".
If coinGeckoId is not available, because the tokens are not listed on coingecko, you can also use
"matchingAsset": - (it links the price of your token to the price of some other token. e.g you can link the price of your stable $ token to USDC)
example for other token
"PUSDC": {
"name": "Polygon USD Coin",
"code": "USDC",
"decimals": 6,
"contractAddress": "0x2791Bca1f2de4661ED88A30C99A7a9449Aa84174",
"color": "#5b31b9",
"coinGeckoId": "usd-coin",
"matchingAsset": "USDC"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not sure if matchingAsset is what we want since the prices can, and will differ slightly, which could make a difference for bigger swaps and confuse users. @tkeidar WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree @MichalSzreder.
@tima-t can you elaborate on what this price is used for?
basically, the actual token price is determined by our AMM, which is a Uniswap V2, can we use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see it is used only for displaying token price in USD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, coingeckoId is used to display the price in USD.
I was trying to say that if the price of your BUSD and XUSD is always equal to approx. 1 dollar.
You can link your tokens to the price feed of coingeckoId and the price of USD. That way it will be more user friendly.
This will work in case the price of you token is stable and the price range is between than 0.99 to 1.01.
It is only for informational purposes (this usd price), but we do not want to show wrong price.
Same thing I am proposing for ETHs if the price of ETHs is always equal to the price of ETH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichalSzreder For XUSD we can use the price of USDT and ETH for ETHs.
The other tokens we will keep empty for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tokens are stable but the price is not always between that range for BDUS nor USDC @tkeidar WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added these for XUSD and ETHs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For our tokens lets keep it as is (without the coingecko id) and once our tokens will be live on coingecko we will add it