feat: Blindex integration #83
Conversation
Added blindex tokens to rsk tokens
src/assets/erc20/rsk-tokens.json
Outdated
| "code": "ETHs", | ||
| "decimals": 18, | ||
| "contractAddress": "0x1d931bf8656d795e50ef6d639562c5bd8ac2b78f", | ||
| "color": "#333333" |
There was a problem hiding this comment.
@MichalSzreder let's add our new tokens: bXAU and bGBP on both PRs
There was a problem hiding this comment.
If some of these tokens is listed on coingecko, can you add the property
"coinGeckoId".
If coinGeckoId is not available, because the tokens are not listed on coingecko, you can also use
"matchingAsset": - (it links the price of your token to the price of some other token. e.g you can link the price of your stable $ token to USDC)
example for other token
"PUSDC": {
"name": "Polygon USD Coin",
"code": "USDC",
"decimals": 6,
"contractAddress": "0x2791Bca1f2de4661ED88A30C99A7a9449Aa84174",
"color": "#5b31b9",
"coinGeckoId": "usd-coin",
"matchingAsset": "USDC"
},
There was a problem hiding this comment.
Hmm, I'm not sure if matchingAsset is what we want since the prices can, and will differ slightly, which could make a difference for bigger swaps and confuse users. @tkeidar WDYT?
There was a problem hiding this comment.
I agree @MichalSzreder.
@tima-t can you elaborate on what this price is used for?
basically, the actual token price is determined by our AMM, which is a Uniswap V2, can we use it?
There was a problem hiding this comment.
As far as I can see it is used only for displaying token price in USD
There was a problem hiding this comment.
Yes, coingeckoId is used to display the price in USD.
I was trying to say that if the price of your BUSD and XUSD is always equal to approx. 1 dollar.
You can link your tokens to the price feed of coingeckoId and the price of USD. That way it will be more user friendly.
This will work in case the price of you token is stable and the price range is between than 0.99 to 1.01.
It is only for informational purposes (this usd price), but we do not want to show wrong price.
Same thing I am proposing for ETHs if the price of ETHs is always equal to the price of ETH
There was a problem hiding this comment.
@MichalSzreder For XUSD we can use the price of USDT and ETH for ETHs.
The other tokens we will keep empty for now
There was a problem hiding this comment.
The tokens are stable but the price is not always between that range for BDUS nor USDC @tkeidar WDYT?
There was a problem hiding this comment.
I have added these for XUSD and ETHs
There was a problem hiding this comment.
For our tokens lets keep it as is (without the coingecko id) and once our tokens will be live on coingecko we will add it
…toassets into feat/blindex-integration
MichalSzreder
force-pushed
the
feat/blindex-integration
branch
from
e17df2d
to
adaf3cb
Compare
…toassets into feat/blindex-integration
Description
Add Blindex tokens (BDX and stablecoins) with XUSD and ETHs to RSK tokens list.
Submission Checklist 📝