Skip to content

sync: from linuxdeepin/dtkwidget #143

sync: from linuxdeepin/dtkwidget

sync: from linuxdeepin/dtkwidget #143

Triggered via pull request July 18, 2024 09:57
Status Success
Total duration 44s
Artifacts

cppcheck.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

4 warnings
cppcheck: src/widgets/private/dindeterminateprogressbar_p.h#L17
Class 'DIndeterminateProgressbarPrivate' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
cppcheck: src/widgets/private/dindeterminateprogressbar_p.h#L23
The class 'DIndeterminateProgressbarPrivate' is unsafe, wrong usage can cause memory/resource leaks for 'DIndeterminateProgressbarPrivate::m_animation'. This can for instance be fixed by adding proper cleanup in the destructor.
cppcheck: src/widgets/private/dprogressbar_p.h#L16
Class 'DProgressBarPrivate' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
cppcheck
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/