Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #65

Merged
merged 1 commit into from
Sep 25, 2024
Merged

sync: from linuxdeepin/dtkwidget #65

merged 1 commit into from
Sep 25, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-589-nosync branch 3 times, most recently from 4c33e70 to 8c43d1b Compare July 23, 2024 08:00
@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-589-nosync branch 5 times, most recently from eb28185 to a1b0858 Compare August 2, 2024 06:48
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DIndeterminateProgressbarPrivate类的构造函数中,m_sliderWidgetm_spotWidget被初始化为新的QWidget实例,但没有提供父窗口或父布局。这可能会导致这些小部件无法正确显示,因为它们没有在布局中。
  • m_timerm_animation成员变量被初始化为new QTimernew QPropertyAnimation,但没有指定父对象。这可能会导致内存泄漏,因为这些对象没有被正确地删除。
  • paintEvent方法中,使用setClipping(true)setClipping(false)来启用和禁用剪切路径。这种方法可能不是最清晰或最稳定的,建议使用QPainterPath对象来定义剪切路径。
  • DIndeterminateProgressbar类的resizeEvent方法中,创建了一个QPainterPath对象来绘制圆角矩形,但没有指定圆角的半径。这可能会导致圆角没有正确显示,因为默认的圆角半径可能不适用于所有情况。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #74

@FeiWang1119 FeiWang1119 merged commit 97c146a into master Sep 25, 2024
11 of 14 checks passed
@FeiWang1119 FeiWang1119 deleted the sync-pr-589-nosync branch September 25, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants