Pass RenderLayers to VelloCanvas #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a config option to `VelloPlugin` and `VelloRenderPlugin` that can control the `RenderLayers` that the `VelloCanvas` is on. This allows fully taking advantage of `RenderLayers` as before the canvas was rendering on the default layer, layer 0, which meant any camera that wanted to render it also had to render everything else on the default layer, layer 0.
This was referenced Aug 3, 2024
simbleau
approved these changes
Aug 3, 2024
|
swapped to |
|
Thank you for that! I have a slightly different vision where the settings are not an optional resource. I'll apply that directly to your branch. :) |
|
sounds good, feel free to take it away. |
|
@simbleau heads up that the way the Resource is inserted in the new changes here forces consumers to insert the resource after the plugin, or it will silently throw the user's Resource away and use the defaults instead. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 4, 2024
Addresses some friction where the `VelloRenderer` was not a resource and required Locals temporarily. This was mainly observed in the `cube3d` example. Likewise, the rendering params such as `use_cpu` and `antialiasing` were not configurable and the use of `RenderLayers` were cleaned up after @ChristopherBiscardi brought up some comments after #71. @ChristopherBiscardi Please let me know if you still have concerns with RenderLayers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix I talked about in #70 and the PR that would be merged (the other should be closed)
This PR adds a config option to
VelloPluginandVelloRenderPluginthat can control theRenderLayersthat theVelloCanvasis on. This allows fully taking advantage ofRenderLayersas before the canvas was rendering on the default layer, layer 0, which meant any camera that wanted to render it also had to render everything else on the default layer, layer 0.