Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: core pipeline changes #73

Merged
merged 8 commits into from
Aug 4, 2024
Merged

refactor: core pipeline changes #73

merged 8 commits into from
Aug 4, 2024

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Aug 4, 2024

Addresses some friction where the VelloRenderer was not a resource and required Locals temporarily. This was mainly observed in the cube3d example. Likewise, the rendering params such as use_cpu and antialiasing were not configurable and the use of RenderLayers were cleaned up after @ChristopherBiscardi brought up some comments after #71.

@ChristopherBiscardi Please let me know if you still have concerns with RenderLayers.

@simbleau simbleau requested a review from seabassjh August 4, 2024 17:28
@simbleau simbleau linked an issue Aug 4, 2024 that may be closed by this pull request
@simbleau simbleau enabled auto-merge August 4, 2024 19:10
@ChristopherBiscardi
Copy link
Contributor

The RenderLayers functionality has been working out great since #71 ! This enabled me to use bevy_vello for in-game ui in addition to menus, so thank you!

here's a demo of a 2d camera with a button on top of a 3d scene, using renderlayers to target all ui to the 2d camera and everything else to the 3d.

screenshot-2024-08-04-at-12.04.22.mp4

@simbleau simbleau added this pull request to the merge queue Aug 4, 2024
Merged via the queue into main with commit e801777 Aug 4, 2024
6 checks passed
@simbleau simbleau deleted the simbleau/cleanup branch August 4, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow anti-aliasing/use cpu in settings
3 participants