Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path pattern builder #809
base: main
Are you sure you want to change the base?
Path pattern builder #809
Changes from 36 commits
cb49cfa
dd52fb4
1e5be70
8a04af4
c709286
de9fe40
2ee5317
316bb2a
0376f6d
c799e63
f524a6d
5d610a0
1fd3bcd
dc5fd40
da40567
a53edb2
06662c6
986df3a
b460bfe
0cf67c9
9a2b815
67bb127
dbb142c
3f5ab60
33ccb30
96f14ce
469020d
1ff349c
fe03245
6e67360
dac0a50
fe145a0
aff50dd
43aaa0c
09a4e3a
7c87563
49b5d3f
0d85d78
53ebe9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, a new constructor for
DefaultPathPattern(List<PathPattern> verifiedPatterns)
was introduced that would skip the validatePathPattern step.I changed the argument type from
List<PathPattern>
-> varargsPathPattern...
in commit 0d85d78.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just use
PathPattern
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this class is needed at all. Why do we need to create a
PathPattern
lazily? Can't we just create it as early as possible?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have merged
PathPatternOptions
andPathPatternOption
withPathPatternBuilder